qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
	qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: [PATCH v2 0/8] iotests: Fix 129 and expand 297’s reach
Date: Wed, 13 Jan 2021 18:57:44 +0100	[thread overview]
Message-ID: <20210113175752.403022-1-mreitz@redhat.com> (raw)

v1 cover letter:
https://lists.nongnu.org/archive/html/qemu-block/2021-01/msg00254.html

Hi,

See the cover letter above for the main point of this series (it’s just
that all patch indices are shifted up by one in v2).

In addition to that, I’ve added patch 1 that makes some changes to 297
so it checks all Python files in qemu-iotests/ by default (with an
extensive skip list for now).  With Vladimir’s changes to test naming,
we’ll need to extend this to include files under qemu-iotests/tests/,
but that shouldn’t be a problem.

v2:
- Added patch 1 so 297 checks all Python files in qemu-iotests/ by
  default, skipping “only” files given in an explicit list.  This list
  is extremely long right now, but at least patch 8 makes it one entry
  shorter.

- Patch 5:
  - Use multi-line string concatenation without +
  - Drop block-job-cancel

- Patch 6:
  - Use multi-line string concatenation without +

- Patch 7:
  - Changed the commit message from implying that 'stop' shouldn’t drain
    the block job (it does and it should) to stating that 'stop'
    shouldn’t make the block job try to complete

- Patch 8:
  - Remove 129 from 297’s new skip list


git-backport-diff against v1:

Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch
[down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively

001/8:[down] 'iotests/297: Allow checking all Python test files'
002/8:[----] [--] 'iotests: Move try_remove to iotests.py'
003/8:[----] [--] 'iotests/129: Remove test images in tearDown()'
004/8:[----] [--] 'iotests/129: Do not check @busy'
005/8:[0008] [FC] 'iotests/129: Use throttle node'
006/8:[0002] [FC] 'iotests/129: Actually test a commit job'
007/8:[----] [--] 'iotests/129: Limit mirror job's buffer size'
008/8:[0003] [FC] 'iotests/129: Clean up pylint and mypy complaints'


Max Reitz (8):
  iotests/297: Allow checking all Python test files
  iotests: Move try_remove to iotests.py
  iotests/129: Remove test images in tearDown()
  iotests/129: Do not check @busy
  iotests/129: Use throttle node
  iotests/129: Actually test a commit job
  iotests/129: Limit mirror job's buffer size
  iotests/129: Clean up pylint and mypy complaints

 tests/qemu-iotests/124        |  8 +---
 tests/qemu-iotests/129        | 74 +++++++++++++++++++++--------------
 tests/qemu-iotests/297        | 66 ++++++++++++++++++++++++++++---
 tests/qemu-iotests/297.out    |  7 +++-
 tests/qemu-iotests/iotests.py | 11 ++++--
 5 files changed, 119 insertions(+), 47 deletions(-)

-- 
2.29.2



             reply	other threads:[~2021-01-13 17:59 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-13 17:57 Max Reitz [this message]
2021-01-13 17:57 ` [PATCH v2 1/8] iotests/297: Allow checking all Python test files Max Reitz
2021-01-13 19:01   ` Eric Blake
2021-01-14  9:23     ` Max Reitz
2021-01-13 19:27   ` Vladimir Sementsov-Ogievskiy
2021-01-13 20:28     ` Vladimir Sementsov-Ogievskiy
2021-01-14  9:31       ` Max Reitz
2021-01-14 10:53         ` Vladimir Sementsov-Ogievskiy
2021-01-14  9:27     ` Max Reitz
2021-01-13 17:57 ` [PATCH v2 2/8] iotests: Move try_remove to iotests.py Max Reitz
2021-01-13 19:28   ` Vladimir Sementsov-Ogievskiy
2021-01-13 17:57 ` [PATCH v2 3/8] iotests/129: Remove test images in tearDown() Max Reitz
2021-01-13 17:57 ` [PATCH v2 4/8] iotests/129: Do not check @busy Max Reitz
2021-01-13 17:57 ` [PATCH v2 5/8] iotests/129: Use throttle node Max Reitz
2021-01-13 19:02   ` Eric Blake
2021-01-13 20:33   ` Vladimir Sementsov-Ogievskiy
2021-01-13 17:57 ` [PATCH v2 6/8] iotests/129: Actually test a commit job Max Reitz
2021-01-13 17:57 ` [PATCH v2 7/8] iotests/129: Limit mirror job's buffer size Max Reitz
2021-01-13 17:57 ` [PATCH v2 8/8] iotests/129: Clean up pylint and mypy complaints Max Reitz
2021-01-13 19:04   ` Eric Blake
2021-01-13 20:38   ` Vladimir Sementsov-Ogievskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210113175752.403022-1-mreitz@redhat.com \
    --to=mreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).