From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FFC6C433DB for ; Thu, 14 Jan 2021 09:36:29 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C7D2222CE3 for ; Thu, 14 Jan 2021 09:36:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C7D2222CE3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60932 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kzz3L-0003gF-RA for qemu-devel@archiver.kernel.org; Thu, 14 Jan 2021 04:36:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50580) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzz28-0002g1-OL for qemu-devel@nongnu.org; Thu, 14 Jan 2021 04:35:12 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:39365) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kzz26-0000RZ-Tj for qemu-devel@nongnu.org; Thu, 14 Jan 2021 04:35:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610616910; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=n6alxUJVO4HQG6wR5agsW6NkY2ZUnAv+dedVGMDRB4Q=; b=PA1DmT9vsYEl4EVGwpd8mkQt//5UKN9NqxIy0IbIb0hhTgHt0eFoSz66g9H1f7Tya7H97v caGcEko0x9lRXPJYebzTbdECdtWIHsg8yzNQmxcU5OUsa/6ym5PjeUtczSv1y56MHkevIk ySU1F6yH7O4odB44mAo4IV2IcURN+q4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-391-GhMVSrBdMqi424dF7Si8Nw-1; Thu, 14 Jan 2021 04:34:54 -0500 X-MC-Unique: GhMVSrBdMqi424dF7Si8Nw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C991A190A7A0; Thu, 14 Jan 2021 09:34:51 +0000 (UTC) Received: from redhat.com (ovpn-115-77.ams2.redhat.com [10.36.115.77]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C03C26A8F2; Thu, 14 Jan 2021 09:34:38 +0000 (UTC) Date: Thu, 14 Jan 2021 09:34:36 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: David Gibson Subject: Re: [PATCH v7 02/13] confidential guest support: Introduce new confidential guest support class Message-ID: <20210114093436.GB1643043@redhat.com> References: <20210113235811.1909610-1-david@gibson.dropbear.id.au> <20210113235811.1909610-3-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210113235811.1909610-3-david@gibson.dropbear.id.au> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Received-SPF: pass client-ip=216.205.24.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.25, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: pair@us.ibm.com, cohuck@redhat.com, brijesh.singh@amd.com, kvm@vger.kernel.org, David Hildenbrand , qemu-devel@nongnu.org, frankja@linux.ibm.com, pragyansri.pathi@intel.com, mst@redhat.com, mdroth@linux.vnet.ibm.com, pasic@linux.ibm.com, borntraeger@de.ibm.com, andi.kleen@intel.com, thuth@redhat.com, Eduardo Habkost , Richard Henderson , dgilbert@redhat.com, Greg Kurz , qemu-s390x@nongnu.org, jun.nakajima@intel.com, Marcelo Tosatti , qemu-ppc@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Jan 14, 2021 at 10:58:00AM +1100, David Gibson wrote: > Several architectures have mechanisms which are designed to protect guest > memory from interference or eavesdropping by a compromised hypervisor. AMD > SEV does this with in-chip memory encryption and Intel's MKTME can do > similar things. POWER's Protected Execution Framework (PEF) accomplishes a > similar goal using an ultravisor and new memory protection features, > instead of encryption. > > To (partially) unify handling for these, this introduces a new > ConfidentialGuestSupport QOM base class. "Confidential" is kind of vague, > but "confidential computing" seems to be the buzzword about these schemes, > and "secure" or "protected" are often used in connection to unrelated > things (such as hypervisor-from-guest or guest-from-guest security). > > The "support" in the name is significant because in at least some of the > cases it requires the guest to take specific actions in order to protect > itself from hypervisor eavesdropping. > > Signed-off-by: David Gibson > --- > backends/confidential-guest-support.c | 33 ++++++++++++++++++++ > backends/meson.build | 1 + > include/exec/confidential-guest-support.h | 38 +++++++++++++++++++++++ > include/qemu/typedefs.h | 1 + > target/i386/sev.c | 3 +- > 5 files changed, 75 insertions(+), 1 deletion(-) > create mode 100644 backends/confidential-guest-support.c > create mode 100644 include/exec/confidential-guest-support.h > > diff --git a/backends/confidential-guest-support.c b/backends/confidential-guest-support.c > new file mode 100644 > index 0000000000..9b0ded0db4 > --- /dev/null > +++ b/backends/confidential-guest-support.c > @@ -0,0 +1,33 @@ > +/* > + * QEMU Confidential Guest support > + * > + * Copyright: David Gibson, Red Hat Inc. 2020 > + * > + * Authors: > + * David Gibson > + * > + * This work is licensed under the terms of the GNU GPL, version 2 or > + * later. See the COPYING file in the top-level directory. > + * > + */ > + > +#include "qemu/osdep.h" > + > +#include "exec/confidential-guest-support.h" > + > +OBJECT_DEFINE_ABSTRACT_TYPE(ConfidentialGuestSupport, > + confidential_guest_support, > + CONFIDENTIAL_GUEST_SUPPORT, > + OBJECT) > + > +static void confidential_guest_support_class_init(ObjectClass *oc, void *data) > +{ > +} > + > +static void confidential_guest_support_init(Object *obj) > +{ > +} > + > +static void confidential_guest_support_finalize(Object *obj) > +{ > +} > diff --git a/backends/meson.build b/backends/meson.build > index 484456ece7..d4221831fc 100644 > --- a/backends/meson.build > +++ b/backends/meson.build > @@ -6,6 +6,7 @@ softmmu_ss.add([files( > 'rng-builtin.c', > 'rng-egd.c', > 'rng.c', > + 'confidential-guest-support.c', > ), numa]) > > softmmu_ss.add(when: 'CONFIG_POSIX', if_true: files('rng-random.c')) > diff --git a/include/exec/confidential-guest-support.h b/include/exec/confidential-guest-support.h > new file mode 100644 > index 0000000000..5f131023ba > --- /dev/null > +++ b/include/exec/confidential-guest-support.h > @@ -0,0 +1,38 @@ > +/* > + * QEMU Confidential Guest support > + * This interface describes the common pieces between various > + * schemes for protecting guest memory or other state against a > + * compromised hypervisor. This includes memory encryption (AMD's > + * SEV and Intel's MKTME) or special protection modes (PEF on POWER, > + * or PV on s390x). > + * > + * Copyright: David Gibson, Red Hat Inc. 2020 > + * > + * Authors: > + * David Gibson > + * > + * This work is licensed under the terms of the GNU GPL, version 2 or > + * later. See the COPYING file in the top-level directory. > + * > + */ > +#ifndef QEMU_CONFIDENTIAL_GUEST_SUPPORT_H > +#define QEMU_CONFIDENTIAL_GUEST_SUPPORT_H > + > +#ifndef CONFIG_USER_ONLY > + > +#include "qom/object.h" > + > +#define TYPE_CONFIDENTIAL_GUEST_SUPPORT "confidential-guest-support" > +OBJECT_DECLARE_SIMPLE_TYPE(ConfidentialGuestSupport, CONFIDENTIAL_GUEST_SUPPORT) > + > +struct ConfidentialGuestSupport { > + Object parent; > +}; > + > +typedef struct ConfidentialGuestSupportClass { > + ObjectClass parent; > +} ConfidentialGuestSupportClass; > + > +#endif /* !CONFIG_USER_ONLY */ > + > +#endif /* QEMU_CONFIDENTIAL_GUEST_SUPPORT_H */ > diff --git a/include/qemu/typedefs.h b/include/qemu/typedefs.h > index 976b529dfb..33685c79ed 100644 > --- a/include/qemu/typedefs.h > +++ b/include/qemu/typedefs.h > @@ -36,6 +36,7 @@ typedef struct BusState BusState; > typedef struct Chardev Chardev; > typedef struct CompatProperty CompatProperty; > typedef struct CoMutex CoMutex; > +typedef struct ConfidentialGuestSupport ConfidentialGuestSupport; > typedef struct CPUAddressSpace CPUAddressSpace; > typedef struct CPUState CPUState; > typedef struct DeviceListener DeviceListener; > diff --git a/target/i386/sev.c b/target/i386/sev.c > index 1546606811..6b49925f51 100644 > --- a/target/i386/sev.c > +++ b/target/i386/sev.c > @@ -31,6 +31,7 @@ > #include "qom/object.h" > #include "exec/address-spaces.h" > #include "monitor/monitor.h" > +#include "exec/confidential-guest-support.h" > > #define TYPE_SEV_GUEST "sev-guest" > OBJECT_DECLARE_SIMPLE_TYPE(SevGuestState, SEV_GUEST) > @@ -322,7 +323,7 @@ sev_guest_instance_init(Object *obj) > > /* sev guest info */ > static const TypeInfo sev_guest_info = { > - .parent = TYPE_OBJECT, > + .parent = TYPE_CONFIDENTIAL_GUEST_SUPPORT, If you're changing the parent QOM type, then you also need to change the parent struct field type in SevguestState to match > .name = TYPE_SEV_GUEST, > .instance_size = sizeof(SevGuestState), > .instance_finalize = sev_guest_finalize, Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|