From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EDD3C433DB for ; Thu, 14 Jan 2021 11:16:16 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 70AC6238A1 for ; Thu, 14 Jan 2021 11:16:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 70AC6238A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41070 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l00bu-0000yK-EJ for qemu-devel@archiver.kernel.org; Thu, 14 Jan 2021 06:16:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47184) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l00aX-0000RA-MM for qemu-devel@nongnu.org; Thu, 14 Jan 2021 06:14:50 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:34324) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l00aU-00019e-Gx for qemu-devel@nongnu.org; Thu, 14 Jan 2021 06:14:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610622884; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MCHSzEvvPCCRMMlsk99p3Tb0RtDamWKQZ3uzTYWIa7s=; b=M4it5BJmMv9MuBGQOMm24miMwawPMwdKBIcwUbpRYGhTU6dNQcfdi8hp8qCF+zctY7wmtE SM3YgVtTYl6Iki88JMgQGZZjdO/CHEQvZsLTNbhm6/8KwX1mg4B/NsUTahYXViQmuTm4Cu RcShEUn9ytIbog3c0dC7J1Rodd7Gdpw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-398-HYXdpfkxO02kF9yjJiwqwA-1; Thu, 14 Jan 2021 06:14:42 -0500 X-MC-Unique: HYXdpfkxO02kF9yjJiwqwA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D3A3F18C8C01; Thu, 14 Jan 2021 11:14:40 +0000 (UTC) Received: from merkur.fritz.box (ovpn-115-18.ams2.redhat.com [10.36.115.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F0E4918A60; Thu, 14 Jan 2021 11:14:37 +0000 (UTC) Date: Thu, 14 Jan 2021 12:14:36 +0100 From: Kevin Wolf To: Vladimir Sementsov-Ogievskiy Subject: Re: [PATCH v6 08/11] iotests: add testenv.py Message-ID: <20210114111436.GC6058@merkur.fritz.box> References: <20210109122631.167314-1-vsementsov@virtuozzo.com> <20210109122631.167314-9-vsementsov@virtuozzo.com> <4bc3f007-65c1-ce8e-0e16-3e6087918d8f@virtuozzo.com> MIME-Version: 1.0 In-Reply-To: <4bc3f007-65c1-ce8e-0e16-3e6087918d8f@virtuozzo.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kwolf@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=63.128.21.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.25, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, mreitz@redhat.com, den@openvz.org, jsnow@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 14.01.2021 um 05:28 hat Vladimir Sementsov-Ogievskiy geschrieben: > 09.01.2021 15:26, Vladimir Sementsov-Ogievskiy wrote: > > Add TestEnv class, which will handle test environment in a new python > > iotests running framework. > > > > Difference with current ./check interface: > > - -v (verbose) option dropped, as it is unused > > > > - -xdiff option is dropped, until somebody complains that it is needed > > - same for -n option > > One more thing dropped is looking for binaries in $build_iotests > directory. Do someone use this feature? Or we can drop it, and > reimplement when someone report the degradation? I seem to have socket_scm_helper only there, but you use self.build_iotests for that, so I suppose this is different from what you mean? My tools and system emulator binaries are in the standard location in the build directory, not in the iotests build directory, so they don't need it. Kevin