From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 359B1C433DB for ; Fri, 15 Jan 2021 01:10:49 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AE70B208D5 for ; Fri, 15 Jan 2021 01:10:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE70B208D5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50708 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l0DdX-0006zL-JX for qemu-devel@archiver.kernel.org; Thu, 14 Jan 2021 20:10:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56682) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l0DaI-00041h-MN; Thu, 14 Jan 2021 20:07:26 -0500 Received: from ozlabs.org ([2401:3900:2:1::2]:34989) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l0DaC-0003QB-PW; Thu, 14 Jan 2021 20:07:23 -0500 Received: by ozlabs.org (Postfix, from userid 1007) id 4DH31b6W02z9sWD; Fri, 15 Jan 2021 12:07:15 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1610672835; bh=se0TKPLrPaRB+8U+0iptuhC9dWqrKC3eKk/NRRSYD30=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=C39xRqOoQZuRdnJmN0NAUXDQ6y9ShM0Lic8325YYTylvwqQaQrnNb6Tmj4j4z9RQf 3YsmogkBP8Ht8lwja0D9eWRvnndYRvbaA9un+rym0ho/VG1YOIzElyEEXJ52/tfKV2 WQDQcfiiX8fYS2yryyOFFd/ZQBr/Q+QylMySN9qI= Date: Fri, 15 Jan 2021 11:49:35 +1100 From: David Gibson To: Daniel Henrique Barboza Subject: Re: [PATCH v1 5/7] spapr_cpu_core.c: use g_auto* in spapr_create_vcpu() Message-ID: <20210115004935.GU435587@yekko.fritz.box> References: <20210114180628.1675603-1-danielhb413@gmail.com> <20210114180628.1675603-6-danielhb413@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ULJ2Z7kCM1hyNsWd" Content-Disposition: inline In-Reply-To: <20210114180628.1675603-6-danielhb413@gmail.com> Received-SPF: pass client-ip=2401:3900:2:1::2; envelope-from=dgibson@ozlabs.org; helo=ozlabs.org X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.248, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, groug@kaod.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --ULJ2Z7kCM1hyNsWd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 14, 2021 at 03:06:26PM -0300, Daniel Henrique Barboza wrote: > Use g_autoptr() with Object and g_autofree with the string to > avoid the need of a cleanup path. >=20 > Signed-off-by: Daniel Henrique Barboza Applied to ppc-for-6.0, thanks. > --- > hw/ppc/spapr_cpu_core.c | 12 +++--------- > 1 file changed, 3 insertions(+), 9 deletions(-) >=20 > diff --git a/hw/ppc/spapr_cpu_core.c b/hw/ppc/spapr_cpu_core.c > index 2f7dc3c23d..4f316a6f9d 100644 > --- a/hw/ppc/spapr_cpu_core.c > +++ b/hw/ppc/spapr_cpu_core.c > @@ -277,8 +277,8 @@ static PowerPCCPU *spapr_create_vcpu(SpaprCpuCore *sc= , int i, Error **errp) > { > SpaprCpuCoreClass *scc =3D SPAPR_CPU_CORE_GET_CLASS(sc); > CPUCore *cc =3D CPU_CORE(sc); > - Object *obj; > - char *id; > + g_autoptr(Object) obj =3D NULL; > + g_autofree char *id =3D NULL; > CPUState *cs; > PowerPCCPU *cpu; > =20 > @@ -293,23 +293,17 @@ static PowerPCCPU *spapr_create_vcpu(SpaprCpuCore *= sc, int i, Error **errp) > cs->start_powered_off =3D true; > cs->cpu_index =3D cc->core_id + i; > if (!spapr_set_vcpu_id(cpu, cs->cpu_index, errp)) { > - goto err; > + return NULL; > } > =20 > cpu->node_id =3D sc->node_id; > =20 > id =3D g_strdup_printf("thread[%d]", i); > object_property_add_child(OBJECT(sc), id, obj); > - g_free(id); > =20 > cpu->machine_data =3D g_new0(SpaprCpuState, 1); > =20 > - object_unref(obj); > return cpu; > - > -err: > - object_unref(obj); > - return NULL; > } > =20 > static void spapr_cpu_core_realize(DeviceState *dev, Error **errp) --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --ULJ2Z7kCM1hyNsWd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdfRlhq5hpmzETofcbDjKyiDZs5IFAmAA5p8ACgkQbDjKyiDZ s5JPUhAA4OvKkiXZ6OVBPUi4hEYZQcPYOLBeZbmxFuSOVhh+vlWKZcJUXwoaB8Oi 0TtDAcB4gTGxA+Oq+M+ESTFo9S3QFZbnMqjQRXN3uhz0YMjcuzxpmZlB9W+0JyEj N1qe3XkPG1uUVTtTkNnK2oPfqlWoYXbXPVhauWPtujw810G1coDSByXDwrtkNTiE 2CU3JOly4iuQ+DxMRFpdMBjG453nxKZXaXpfzN5zyQg2CaAZCPZ9WbgfLQNCyNPc erQg/y/+D9KHa5mhXTXHHDm13cRbsbDEQjK65CQP73IRVIEcMEp4hfbNtNxK3st9 OouaK6U8GJqHscSTwbJF1N4CeM1bcEq4APTLoL8YoeD6zomL+c/yJ2JrbknHmCXX 7jo1ELsG8d9VN0QNqm758m4fa724rHyR6UNHKqGLS0wRxXrdTDxiGuNuGvUK5EXA jgBQRYjJ2eK50SCm3FhLtea4NwGg/MTBsa6oddLKXIgOjQ1/65aEllYQYxTyZHNO ablchSt83OIF/vazXiWw5uolL+vsN0lhUTZSAErXynCzZ1KX8v4fUjFHRb/GMT4y txd9ayaQQWPa23hFufmGzwL0srjofo5IlZH37AkEcG9ANfghjZdqHDOOMGhbkEWc KGzYyPcMTbevPzh0bXjsOEwWhQLgPRJ/+Tg6cxZnC0+JI0GTqaA= =um0k -----END PGP SIGNATURE----- --ULJ2Z7kCM1hyNsWd--