From: Peter Krempa <pkrempa@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Igor Mammedov <imammedo@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Michal Privoznik <mprivozn@redhat.com>
Subject: Re: [PATCH v2] machine: add missing doc for memory-backend option
Date: Fri, 15 Jan 2021 11:43:10 +0100 [thread overview]
Message-ID: <20210115104310.GA2794356@angien.pipo.sk> (raw)
In-Reply-To: <CAFEAcA843rP6rvktc0FSZEjK8C9E8h_5_PbCBUXYM4XJRE7KHQ@mail.gmail.com>
On Fri, Jan 15, 2021 at 10:02:04 +0000, Peter Maydell wrote:
> On Thu, 14 Jan 2021 at 23:48, Igor Mammedov <imammedo@redhat.com> wrote:
> >
> > Add documentation for '-machine memory-backend' CLI option and
> > how to use it.
> >
> > And document that x-use-canonical-path-for-ramblock-id,
> > is considered to be stable to make sure it won't go away by accident.
>
> That's not what the x- prefix is supposed to mean.
This is the exact reason I was asking on behalf of the libvirt team for
adding such statement if we were to use it. We want guarantee that it's
considered stable since without that it will not be accepted into
libvirt.
> If we have an internal constraint that we mustn't delete
> the option in order to support some other must-be-stable
> interface (eg migration of some machines) we can document
> that in a comment, but that doesn't mean that we should
> document to users that direct use of an x-prefix option
> is supported as a stable interface.
AFAIK the issue is that with the new approach to configure system memory
(via a memory-backend=id, since the old one was deprecated) migration
fails from/to older qemus ...
> Alternatively, if the option is really stable for direct
> use by users then we should commit to making it so by
> removing the x-.
... thus the idea behind keeping this interface as is is it also fixes
the migration compatibility for qemu 5.0/5.1/5.2 which were already
released.
Removing the 'x-' will fix it only starting with qemu-6.0 and any
downstream which backports the removal of the prefix.
Obviously not using 'x-' prefixed options is strongly preferred in
libvirt.
next prev parent reply other threads:[~2021-01-15 10:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 23:46 [PATCH v2] machine: add missing doc for memory-backend option Igor Mammedov
2021-01-15 9:36 ` Michal Privoznik
2021-01-20 10:20 ` Igor Mammedov
2021-01-15 10:02 ` Peter Maydell
2021-01-15 10:43 ` Peter Krempa [this message]
2021-01-15 10:56 ` Peter Krempa
2021-01-20 13:51 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210115104310.GA2794356@angien.pipo.sk \
--to=pkrempa@redhat.com \
--cc=imammedo@redhat.com \
--cc=mprivozn@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).