From: Lukas Straub <lukasstraub2@web.de>
To: "Zhang, Chen" <chen.zhang@intel.com>
Cc: Jason Wang <jasowang@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
qemu-dev <qemu-devel@nongnu.org>,
Zhang Chen <zhangckid@gmail.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH 3/3] net/colo-compare: Add handler for passthrough connection
Date: Fri, 15 Jan 2021 17:06:29 +0100 [thread overview]
Message-ID: <20210115170629.39cc364f@gecko.fritz.box> (raw)
In-Reply-To: <63df670857ed4a278fab273557ee97d6@intel.com>
[-- Attachment #1: Type: text/plain, Size: 2145 bytes --]
On Fri, 15 Jan 2021 09:07:47 +0000
"Zhang, Chen" <chen.zhang@intel.com> wrote:
> > -----Original Message-----
> > From: Lukas Straub <lukasstraub2@web.de>
> > Sent: Thursday, January 14, 2021 9:45 PM
> > To: Zhang, Chen <chen.zhang@intel.com>
> > Cc: Jason Wang <jasowang@redhat.com>; qemu-dev <qemu-
> > devel@nongnu.org>; Eric Blake <eblake@redhat.com>; Dr. David Alan
> > Gilbert <dgilbert@redhat.com>; Markus Armbruster <armbru@redhat.com>;
> > Zhang Chen <zhangckid@gmail.com>
> > Subject: Re: [PATCH 3/3] net/colo-compare: Add handler for passthrough
> > connection
> >
> > On Thu, 24 Dec 2020 09:09:18 +0800
> > Zhang Chen <chen.zhang@intel.com > wrote:
> >
> > > From: Zhang Chen <chen.zhang@intel.com>
> > >
> > > Currently, we just use guest's TCP/UDP source port as the key to
> > > bypass certain network traffic.
> > >
> > > Signed-off-by: Zhang Chen <chen.zhang@intel.com>
> > > ---
> > > net/colo-compare.c | 49
> > > ++++++++++++++++++++++++++++++++++++++++++++++
> > > net/colo-compare.h | 2 ++
> > > net/net.c | 27 +++++++++++++++++++++++++
> > > 3 files changed, 78 insertions(+)
> > >
> > > diff --git a/net/colo-compare.c b/net/colo-compare.c index
> > > 337025b44f..11a32caa9b 100644
> > > --- a/net/colo-compare.c
> > > +++ b/net/colo-compare.c
> > > @@ -46,6 +46,9 @@ static QTAILQ_HEAD(, CompareState) net_compares =
> > > static NotifierList colo_compare_notifiers =
> > > NOTIFIER_LIST_INITIALIZER(colo_compare_notifiers);
> > >
> > > +static QLIST_HEAD(, PassthroughEntry) passthroughlist =
> > > + QLIST_HEAD_INITIALIZER(passthroughlist);
> > > +
> >
> > Hi,
> > I think this should be per colo-compare instance e.g. inside 'struct
> > CompareState'.
>
> It looks QMP and HMP also need to add colo-compare object ID to control it.
> Do we need make this command more general?
Yes, it gives more flexibility. For example if the VM a "public" and a separate "management" network interface, passthrough can then be enabled just on the "management" interface.
Regards,
Lukas Straub
> Thanks
> Chen
>
> >
> > > [...]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-01-15 16:07 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-24 1:09 [PATCH 0/3] Bypass specific network traffic in COLO Zhang Chen
2020-12-24 1:09 ` [PATCH 1/3] qapi/net: Add new QMP command for COLO passthrough Zhang Chen
2020-12-25 6:20 ` Jason Wang
2020-12-28 0:38 ` Zhang, Chen
2020-12-28 7:11 ` Jason Wang
2020-12-29 2:56 ` Zhang, Chen
2020-12-30 3:56 ` Jason Wang
2021-01-05 3:28 ` Zhang, Chen
2021-01-05 4:17 ` Jason Wang
2021-01-05 6:29 ` Zhang, Chen
2021-01-19 19:32 ` Eric Blake
2021-01-21 1:50 ` Zhang, Chen
2020-12-24 1:09 ` [PATCH 2/3] hmp-commands: Add new HMP " Zhang Chen
2020-12-24 1:09 ` [PATCH 3/3] net/colo-compare: Add handler for passthrough connection Zhang Chen
2021-01-14 13:45 ` Lukas Straub
2021-01-15 9:07 ` Zhang, Chen
2021-01-15 16:06 ` Lukas Straub [this message]
2021-01-14 13:50 ` Lukas Straub
2021-01-15 9:08 ` Zhang, Chen
2020-12-25 6:23 ` [PATCH 0/3] Bypass specific network traffic in COLO Jason Wang
2020-12-28 0:38 ` Zhang, Chen
2021-01-04 13:06 ` Dr. David Alan Gilbert
2021-01-05 3:28 ` Zhang, Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210115170629.39cc364f@gecko.fritz.box \
--to=lukasstraub2@web.de \
--cc=armbru@redhat.com \
--cc=chen.zhang@intel.com \
--cc=dgilbert@redhat.com \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zhangckid@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).