From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
Willian Rampazzo <wrampazz@redhat.com>
Subject: [PATCH v4 03/10] iotests: Move try_remove to iotests.py
Date: Fri, 15 Jan 2021 18:43:08 +0100 [thread overview]
Message-ID: <20210115174315.30949-4-mreitz@redhat.com> (raw)
In-Reply-To: <20210115174315.30949-1-mreitz@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
tests/qemu-iotests/124 | 8 +-------
tests/qemu-iotests/iotests.py | 11 +++++++----
2 files changed, 8 insertions(+), 11 deletions(-)
diff --git a/tests/qemu-iotests/124 b/tests/qemu-iotests/124
index 3705cbb6b3..e40eeb50b9 100755
--- a/tests/qemu-iotests/124
+++ b/tests/qemu-iotests/124
@@ -22,6 +22,7 @@
import os
import iotests
+from iotests import try_remove
def io_write_patterns(img, patterns):
@@ -29,13 +30,6 @@ def io_write_patterns(img, patterns):
iotests.qemu_io('-c', 'write -P%s %s %s' % pattern, img)
-def try_remove(img):
- try:
- os.remove(img)
- except OSError:
- pass
-
-
def transaction_action(action, **kwargs):
return {
'type': action,
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index 52facb8e04..a69b4cdc4e 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tests/qemu-iotests/iotests.py
@@ -523,12 +523,15 @@ class FilePath:
return False
+def try_remove(img):
+ try:
+ os.remove(img)
+ except OSError:
+ pass
+
def file_path_remover():
for path in reversed(file_path_remover.paths):
- try:
- os.remove(path)
- except OSError:
- pass
+ try_remove(path)
def file_path(*names, base_dir=test_dir):
--
2.29.2
next prev parent reply other threads:[~2021-01-15 17:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 17:43 [PATCH v4 00/10] iotests: Fix 129 and expand 297’s reach Max Reitz
2021-01-15 17:43 ` [PATCH v4 01/10] iotests.py: Assume a couple of variables as given Max Reitz
2021-01-15 18:44 ` Willian Rampazzo
2021-01-15 17:43 ` [PATCH v4 02/10] iotests/297: Rewrite in Python and extend reach Max Reitz
2021-01-15 19:27 ` Willian Rampazzo
2021-01-18 10:09 ` Max Reitz
2021-02-08 20:27 ` Willian Rampazzo
2021-01-15 17:43 ` Max Reitz [this message]
2021-01-15 18:30 ` [PATCH v4 03/10] iotests: Move try_remove to iotests.py Willian Rampazzo
2021-01-15 17:43 ` [PATCH v4 04/10] iotests/129: Remove test images in tearDown() Max Reitz
2021-01-15 17:43 ` [PATCH v4 05/10] iotests/129: Do not check @busy Max Reitz
2021-01-15 18:29 ` Willian Rampazzo
2021-01-15 17:43 ` [PATCH v4 06/10] iotests/129: Use throttle node Max Reitz
2021-01-15 18:28 ` Willian Rampazzo
2021-01-15 17:43 ` [PATCH v4 07/10] iotests/129: Actually test a commit job Max Reitz
2021-01-15 18:26 ` Willian Rampazzo
2021-01-15 17:43 ` [PATCH v4 08/10] iotests/129: Limit mirror job's buffer size Max Reitz
2021-01-15 17:43 ` [PATCH v4 09/10] iotests/129: Clean up pylint and mypy complaints Max Reitz
2021-01-15 17:43 ` [PATCH v4 10/10] iotests/300: " Max Reitz
2021-01-15 18:24 ` Willian Rampazzo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210115174315.30949-4-mreitz@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
--cc=wrampazz@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).