From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A28AC433E0 for ; Mon, 18 Jan 2021 03:06:52 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C0210223E8 for ; Mon, 18 Jan 2021 03:06:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C0210223E8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44516 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l1KsU-00009Q-IG for qemu-devel@archiver.kernel.org; Sun, 17 Jan 2021 22:06:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50220) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1KqS-0007fS-4M; Sun, 17 Jan 2021 22:04:44 -0500 Received: from bilbo.ozlabs.org ([203.11.71.1]:55449 helo=ozlabs.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1KqO-0002Oo-Ku; Sun, 17 Jan 2021 22:04:43 -0500 Received: by ozlabs.org (Postfix, from userid 1007) id 4DJxTZ20N5z9sVS; Mon, 18 Jan 2021 14:04:34 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1610939074; bh=19ZhsKQRbEsGZBpmPQe7yoYh0jntDutUTZZSvePFwCs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KeIVG9Z/nYNzUqbirHqkRt+kNHEH4qezfYP8nuriF6TClzIm58BdbOc7YCFXTRi/T njBmZD7YnAEPDUjW+WfMsOU91k5mOXP8vXJiGFDsamjk7I6MrwCZNkl4lUcZN/IjN1 3Wy3Jj2N84/D1B1i32MBg0JxpB/PsxmgncCWYDRY= Date: Mon, 18 Jan 2021 14:03:08 +1100 From: David Gibson To: Cornelia Huck Subject: Re: [PATCH v7 08/13] confidential guest support: Move SEV initialization into arch specific code Message-ID: <20210118030308.GG2089552@yekko.fritz.box> References: <20210113235811.1909610-1-david@gibson.dropbear.id.au> <20210113235811.1909610-9-david@gibson.dropbear.id.au> <20210115142425.540b6126.cohuck@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="1XWsVB21DFCvn2e8" Content-Disposition: inline In-Reply-To: <20210115142425.540b6126.cohuck@redhat.com> Received-SPF: pass client-ip=203.11.71.1; envelope-from=dgibson@ozlabs.org; helo=ozlabs.org X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pair@us.ibm.com, brijesh.singh@amd.com, kvm@vger.kernel.org, David Hildenbrand , qemu-devel@nongnu.org, frankja@linux.ibm.com, pragyansri.pathi@intel.com, mst@redhat.com, mdroth@linux.vnet.ibm.com, pasic@linux.ibm.com, borntraeger@de.ibm.com, andi.kleen@intel.com, thuth@redhat.com, Eduardo Habkost , Richard Henderson , dgilbert@redhat.com, Greg Kurz , qemu-s390x@nongnu.org, jun.nakajima@intel.com, berrange@redhat.com, Marcelo Tosatti , qemu-ppc@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --1XWsVB21DFCvn2e8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 15, 2021 at 02:24:25PM +0100, Cornelia Huck wrote: > On Thu, 14 Jan 2021 10:58:06 +1100 > David Gibson wrote: >=20 > > While we've abstracted some (potential) differences between mechanisms = for > > securing guest memory, the initialization is still specific to SEV. Gi= ven > > that, move it into x86's kvm_arch_init() code, rather than the generic > > kvm_init() code. > >=20 > > Signed-off-by: David Gibson > > --- > > accel/kvm/kvm-all.c | 14 -------------- > > accel/kvm/sev-stub.c | 4 ++-- > > target/i386/kvm/kvm.c | 12 ++++++++++++ > > target/i386/sev.c | 7 ++++++- > > 4 files changed, 20 insertions(+), 17 deletions(-) > >=20 >=20 > (...) >=20 > > @@ -2135,6 +2136,17 @@ int kvm_arch_init(MachineState *ms, KVMState *s) > > uint64_t shadow_mem; > > int ret; > > struct utsname utsname; > > + Error *local_err =3D NULL; > > + > > + /* > > + * if memory encryption object is specified then initialize the > > + * memory encryption context (no-op otherwise) > > + */ > > + ret =3D sev_kvm_init(ms->cgs, &local_err); >=20 > Maybe still leave a comment here, as the code will still need to be > modified to handle non-SEV x86 mechanisms? Uh.. I'm confused.. this hunk is adding a comment, not removing one.. >=20 > > + if (ret < 0) { > > + error_report_err(local_err); > > + return ret; > > + } > > =20 > > if (!kvm_check_extension(s, KVM_CAP_IRQ_ROUTING)) { > > error_report("kvm: KVM_CAP_IRQ_ROUTING not supported by KVM"); > > diff --git a/target/i386/sev.c b/target/i386/sev.c > > index 3d94635397..aa79cacabe 100644 > > --- a/target/i386/sev.c > > +++ b/target/i386/sev.c > > @@ -664,13 +664,18 @@ sev_vm_state_change(void *opaque, int running, Ru= nState state) > > =20 > > int sev_kvm_init(ConfidentialGuestSupport *cgs, Error **errp) > > { > > - SevGuestState *sev =3D SEV_GUEST(cgs); > > + SevGuestState *sev > > + =3D (SevGuestState *)object_dynamic_cast(OBJECT(cgs), TYPE_SEV= _GUEST); >=20 > This looks a bit ugly; maybe we want the generic code to generate a > separate version of the cast macro that doesn't assert? Just cosmetics, > though. I tend to the view that the clunkiness of this textually is outweighted by using object_dynamic_cast() which has well known semantics, rather than requiring someone reading the code to understand another intermediate macro. > > char *devname; > > int ret, fw_error; > > uint32_t ebx; > > uint32_t host_cbitpos; > > struct sev_user_data_status status =3D {}; > > =20 > > + if (!sev) { > > + return 0; > > + } > > + > > ret =3D ram_block_discard_disable(true); > > if (ret) { > > error_report("%s: cannot disable RAM discard", __func__); >=20 > Reviewed-by: Cornelia Huck >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --1XWsVB21DFCvn2e8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdfRlhq5hpmzETofcbDjKyiDZs5IFAmAE+mwACgkQbDjKyiDZ s5JmlQ//TxCrs3vQHpA/Vy+qnAXlrIP8nw9BCkEPRSFJUEy8MpuZ8UTtpgdCHvRg jqnJV0w+ybDGxk6gllJAGmHALhNyoLVIPdM/WpCHlyWzHW4Nqn2L/Hm2OLRgJi2X TfQiDiDwTfrasx9bledF15VojdBSQkeeLagCx19F7pK5YaquzMKcytD1evb2ADk5 quFxpmlX8QtMR6EjTI/GAxBk8vcZmNPvW7OuOQ4QiMCaozwRuku8nOQ/NnmQPTDh Iqp6isqO2DtXZb1IN9S8qwozMBoyS5HUjsBRT2JbV2MpaIxhkDiBfxeDo7YRHxVz OmfgaUbqCDrFa8Mkbl8yKSlW9+Rb87B5fg0/M1JCsaIKLHHDIMGyXKCpXjRDeDMw AxfuF9oYzXP+6/DvxgaT2QFdA2v7VBFjhViwlu6XSi3eRhIhokypt+R3MmWvjAYO EL/5g0py6oBNL3hcQRcREaOD7bCtwTrEK3CD3P0MeSaRKWEC7crmeCYH/LacnfRF 6YF2vvQwpBbZPgLeHmjqwSY0RpSt1uOhI0SLjHWpwn5TGqxnak0GqbYBBdXt/o+V kqK2aMPiHcL5fWmkSo//2ANJHGSxZKjSMRU5C0mc47xY8HYoZQDdhebwYemZFbqx Rj+lLwpduJow5zDW8jqBjIy0fKWa97npooF5mO85v9W/3neUcgw= =Dpic -----END PGP SIGNATURE----- --1XWsVB21DFCvn2e8--