From: David Edmondson <david.edmondson@oracle.com>
To: qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>,
Thomas Huth <thuth@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
David Edmondson <david.edmondson@oracle.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: [RFC PATCH 0/2] x86 CPU feature +/- fiddling and +kvm-no-defaults
Date: Tue, 19 Jan 2021 14:22:05 +0000 [thread overview]
Message-ID: <20210119142207.3443123-1-david.edmondson@oracle.com> (raw)
Currently "-cpu -feature,+feature" will disable -feature, which seems
contrary to the intention of the user. Fix this such that the later
flag wins. There are no changes to the interaction of +/- and =on/=off.
Enabling KVM currently causes a default set of KVM features to be
enabled. Allow this default set to be defeated, requiring all features
to be explicitly enabled.
David Edmondson (1):
hw/i386: -cpu model,-feature,+feature should enable feature
Joao Martins (1):
target/i386: Add "-cpu +kvm-no-defaults"
target/i386/cpu.c | 38 +++++++++++++++++++++++------
target/i386/cpu.h | 3 +++
tests/qtest/test-x86-cpuid-compat.c | 8 +++---
3 files changed, 38 insertions(+), 11 deletions(-)
--
2.29.2
next reply other threads:[~2021-01-19 14:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 14:22 David Edmondson [this message]
2021-01-19 14:22 ` [RFC PATCH 1/2] hw/i386: -cpu model, -feature, +feature should enable feature David Edmondson
2021-01-19 15:20 ` [RFC PATCH 1/2] hw/i386: -cpu model,-feature,+feature " Eduardo Habkost
2021-01-19 16:27 ` [External] : " David Edmondson
2021-01-19 16:30 ` Eduardo Habkost
2021-01-20 9:59 ` Igor Mammedov
2021-01-20 10:08 ` David Edmondson
2021-01-20 10:08 ` [External] : " Daniel P. Berrangé
2021-01-20 10:17 ` David Edmondson
2021-01-20 16:18 ` Eduardo Habkost
2021-01-20 19:21 ` Igor Mammedov
2021-01-20 20:12 ` [PATCH] docs/system: Deprecate `-cpu ...,+feature,-feature` syntax Eduardo Habkost
2021-01-20 20:19 ` [PATCH] docs/system: Deprecate `-cpu ..., +feature, -feature` syntax David Edmondson
2021-01-21 9:39 ` [PATCH] docs/system: Deprecate `-cpu ...,+feature,-feature` syntax Daniel P. Berrangé
2021-01-27 0:14 ` John Snow
2021-01-21 10:25 ` Igor Mammedov
2021-01-19 14:22 ` [RFC PATCH 2/2] target/i386: Add "-cpu +kvm-no-defaults" David Edmondson
2021-01-19 16:28 ` [RFC PATCH 0/2] x86 CPU feature +/- fiddling and +kvm-no-defaults Daniel P. Berrangé
2021-01-19 16:35 ` Eduardo Habkost
2021-01-19 16:41 ` Daniel P. Berrangé
2021-01-20 10:01 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210119142207.3443123-1-david.edmondson@oracle.com \
--to=david.edmondson@oracle.com \
--cc=ehabkost@redhat.com \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).