From: Gerd Hoffmann <kraxel@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH 7/9] meson: Do not configure audio if system-mode is not selected
Date: Wed, 20 Jan 2021 10:09:25 +0100 [thread overview]
Message-ID: <20210120090925.qulsekntrjvbfp2d@sirius.home.kraxel.org> (raw)
In-Reply-To: <166ad408-aa3c-7050-d586-6893f80d3560@redhat.com>
> > +##########################################
> > +# Disable features only meaningful for system-mode emulation
> > +if test "$softmmu" = "no"; then
> > + audio_drv_list=""
> > +fi
> > +
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
> > ##########################################
> > # Some versions of Mac OS X incorrectly define SIZE_MAX
> > cat > $TMPC << EOF
> > diff --git a/meson.build b/meson.build
> > index 575e34d88ac..e6c6d1518ef 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -2425,7 +2425,9 @@
> > # TODO: add back version
> > summary_info += {'virgl support': config_host.has_key('CONFIG_VIRGL')}
> > summary_info += {'curl support': curl.found()}
> > -summary_info += {'Audio drivers': config_host['CONFIG_AUDIO_DRIVERS']}
> > +if have_system
> > + summary_info += {'Audio drivers': config_host['CONFIG_AUDIO_DRIVERS']}
> > +endif
I guess there are alot more cfg options like that one. virgl support
for starters ;)
So maybe group them in a block?
take care,
Gerd
next prev parent reply other threads:[~2021-01-20 9:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 18:49 [PATCH 0/9] meson: Clarify summary Philippe Mathieu-Daudé
2021-01-19 18:49 ` [PATCH 1/9] meson: Summarize generic information first Philippe Mathieu-Daudé
2021-01-19 18:49 ` [PATCH 2/9] meson: Summarize compilation information altogether Philippe Mathieu-Daudé
2021-01-19 18:49 ` [PATCH 3/9] meson: Summarize host binaries altogether Philippe Mathieu-Daudé
2021-01-19 18:50 ` [PATCH 4/9] meson: Summarize accelerators altogether Philippe Mathieu-Daudé
2021-01-19 18:50 ` [PATCH 5/9] meson: Display if system emulation is selected in summary Philippe Mathieu-Daudé
2021-01-19 18:50 ` [PATCH 6/9] meson: Restrict system-mode specific accelerators Philippe Mathieu-Daudé
2021-01-19 18:50 ` [PATCH 7/9] meson: Do not configure audio if system-mode is not selected Philippe Mathieu-Daudé
2021-01-19 18:53 ` Philippe Mathieu-Daudé
2021-01-20 9:09 ` Gerd Hoffmann [this message]
2021-01-19 18:50 ` [PATCH 8/9] meson: Display if user-mode emulation is selected in summary Philippe Mathieu-Daudé
2021-01-19 18:50 ` [PATCH 9/9] meson: Summarize block layer information altogether Philippe Mathieu-Daudé
2021-01-20 17:10 ` [PATCH 0/9] meson: Clarify summary Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210120090925.qulsekntrjvbfp2d@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).