From: Gerd Hoffmann <kraxel@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] usb: add pcap support.
Date: Wed, 20 Jan 2021 10:13:25 +0100 [thread overview]
Message-ID: <20210120091325.5ol2oaogb5cibnmd@sirius.home.kraxel.org> (raw)
In-Reply-To: <97b56d63-870c-2c41-b20c-96411301dc62@redhat.com>
Hi,
> > diff --git a/hw/usb/pcap.c b/hw/usb/pcap.c
> > new file mode 100644
> > index 000000000000..d3162d65e5fe
> > --- /dev/null
> > +++ b/hw/usb/pcap.c
> > @@ -0,0 +1,242 @@
>
> Missing license.
Good point.
> > +struct pcap_hdr {
>
> QEMU_PACKED?
>
> > +struct pcaprec_hdr {
>
> QEMU_PACKED?
>
> > +struct usbmon_packet {
>
> QEMU_PACKED?
Doesn't hurt, but also doesn't make a difference.
The structs are carefully layout-ed to have all
fields properly aligned.
take care,
Gerd
prev parent reply other threads:[~2021-01-20 9:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 19:44 [PATCH] usb: add pcap support Gerd Hoffmann
2021-01-19 21:01 ` Philippe Mathieu-Daudé
2021-01-20 9:13 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210120091325.5ol2oaogb5cibnmd@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).