qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* How to run crypto benchmarks tests?
@ 2021-01-20 12:50 Philippe Mathieu-Daudé
  2021-01-20 13:06 ` Daniel P. Berrangé
  0 siblings, 1 reply; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-01-20 12:50 UTC (permalink / raw)
  To: Paolo Bonzini, Daniel P . Berrange; +Cc: qemu-devel

Hi,

Using the following "build tools and doc" config:

../configure --disable-system --disable-user
                                 ...
                     TLS priority: "NORMAL"
                   GNUTLS support: YES
                        libgcrypt: NO
                           nettle: YES
                              XTS: YES
                         libtasn1: YES
                              PAM: YES
                                 ...

$ make check-help
...
 make check-speed          Run qobject speed tests
...
Test targets:
  check                          - Run all tests (check-help for details)
  bench                          - Run all benchmarks
  docker                         - Help about targets running tests
inside containers

$ make check-speed
make: *** No rule to make target 'bench-speed', needed by 'check-speed'.
 Stop.
$ make bench-speed
make: *** No rule to make target 'bench-speed'.  Stop.
$ make check-bench
make: *** No rule to make target 'check-bench'.  Stop.
$ make bench
make: Nothing to be done for 'bench'.

I want to run these tests:

$ ls -1 tests/test-crypto-*c
tests/test-crypto-afsplit.c
tests/test-crypto-block.c
tests/test-crypto-cipher.c
tests/test-crypto-hash.c
tests/test-crypto-hmac.c
tests/test-crypto-ivgen.c
tests/test-crypto-pbkdf.c
tests/test-crypto-secret.c
tests/test-crypto-tlscredsx509.c
tests/test-crypto-tlssession.c
tests/test-crypto-xts.c

What am I doing wrong? IIRC "make check-speed" used to work,
maybe something went wrong in commit 9ed7247a596
("meson: convert the speed tests")?

Thanks,

Phil.



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: How to run crypto benchmarks tests?
  2021-01-20 12:50 How to run crypto benchmarks tests? Philippe Mathieu-Daudé
@ 2021-01-20 13:06 ` Daniel P. Berrangé
  2021-01-20 13:58   ` Philippe Mathieu-Daudé
  0 siblings, 1 reply; 4+ messages in thread
From: Daniel P. Berrangé @ 2021-01-20 13:06 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé; +Cc: Paolo Bonzini, qemu-devel

On Wed, Jan 20, 2021 at 01:50:48PM +0100, Philippe Mathieu-Daudé wrote:
> Hi,
> 
> Using the following "build tools and doc" config:
> 
> ../configure --disable-system --disable-user
>                                  ...
>                      TLS priority: "NORMAL"
>                    GNUTLS support: YES
>                         libgcrypt: NO
>                            nettle: YES
>                               XTS: YES
>                          libtasn1: YES
>                               PAM: YES
>                                  ...
> 
> $ make check-help
> ...
>  make check-speed          Run qobject speed tests
> ...
> Test targets:
>   check                          - Run all tests (check-help for details)
>   bench                          - Run all benchmarks
>   docker                         - Help about targets running tests
> inside containers
> 
> $ make check-speed
> make: *** No rule to make target 'bench-speed', needed by 'check-speed'.
>  Stop.
> $ make bench-speed
> make: *** No rule to make target 'bench-speed'.  Stop.
> $ make check-bench
> make: *** No rule to make target 'check-bench'.  Stop.
> $ make bench
> make: Nothing to be done for 'bench'.
> 
> I want to run these tests:
> 
> $ ls -1 tests/test-crypto-*c
> tests/test-crypto-afsplit.c
> tests/test-crypto-block.c
> tests/test-crypto-cipher.c
> tests/test-crypto-hash.c
> tests/test-crypto-hmac.c
> tests/test-crypto-ivgen.c
> tests/test-crypto-pbkdf.c
> tests/test-crypto-secret.c
> tests/test-crypto-tlscredsx509.c
> tests/test-crypto-tlssession.c
> tests/test-crypto-xts.c

These aren't benchmarks - they're regular unit tests - eg make check-unit 

The benchmarks are tests/benchmark-crypto*.c

Either way, all of this is surrounded by 'if have_block' in tests/meson.build
which should apply if you have tools enabled or system emulators enabled.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: How to run crypto benchmarks tests?
  2021-01-20 13:06 ` Daniel P. Berrangé
@ 2021-01-20 13:58   ` Philippe Mathieu-Daudé
  2021-01-20 14:23     ` Philippe Mathieu-Daudé
  0 siblings, 1 reply; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-01-20 13:58 UTC (permalink / raw)
  To: Daniel P. Berrangé; +Cc: Paolo Bonzini, qemu-devel

On 1/20/21 2:06 PM, Daniel P. Berrangé wrote:
> On Wed, Jan 20, 2021 at 01:50:48PM +0100, Philippe Mathieu-Daudé wrote:
>> Hi,
>>
>> Using the following "build tools and doc" config:
>>
>> ../configure --disable-system --disable-user
>>                                  ...
>>                      TLS priority: "NORMAL"
>>                    GNUTLS support: YES
>>                         libgcrypt: NO
>>                            nettle: YES
>>                               XTS: YES
>>                          libtasn1: YES
>>                               PAM: YES
>>                                  ...
>>
>> $ make check-help
>> ...
>>  make check-speed          Run qobject speed tests
>> ...
>> Test targets:
>>   check                          - Run all tests (check-help for details)
>>   bench                          - Run all benchmarks
>>   docker                         - Help about targets running tests
>> inside containers
>>
>> $ make check-speed
>> make: *** No rule to make target 'bench-speed', needed by 'check-speed'.
>>  Stop.
>> $ make bench-speed
>> make: *** No rule to make target 'bench-speed'.  Stop.
>> $ make check-bench
>> make: *** No rule to make target 'check-bench'.  Stop.
>> $ make bench
>> make: Nothing to be done for 'bench'.
>>
>> I want to run these tests:
>>
>> $ ls -1 tests/test-crypto-*c
>> tests/test-crypto-afsplit.c
>> tests/test-crypto-block.c
>> tests/test-crypto-cipher.c
>> tests/test-crypto-hash.c
>> tests/test-crypto-hmac.c
>> tests/test-crypto-ivgen.c
>> tests/test-crypto-pbkdf.c
>> tests/test-crypto-secret.c
>> tests/test-crypto-tlscredsx509.c
>> tests/test-crypto-tlssession.c
>> tests/test-crypto-xts.c
> 
> These aren't benchmarks - they're regular unit tests - eg make check-unit 
> 
> The benchmarks are tests/benchmark-crypto*.c

Oops indeed. I want to run both to be sure.

> Either way, all of this is surrounded by 'if have_block' in tests/meson.build
> which should apply if you have tools enabled or system emulators enabled.

That helped:

                      block layer: NO

I'll see why the tools are not automatically selected.

Thanks,

Phil.



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: How to run crypto benchmarks tests?
  2021-01-20 13:58   ` Philippe Mathieu-Daudé
@ 2021-01-20 14:23     ` Philippe Mathieu-Daudé
  0 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-01-20 14:23 UTC (permalink / raw)
  To: Daniel P. Berrangé; +Cc: Paolo Bonzini, qemu-devel

On 1/20/21 2:58 PM, Philippe Mathieu-Daudé wrote:
> On 1/20/21 2:06 PM, Daniel P. Berrangé wrote:
>> On Wed, Jan 20, 2021 at 01:50:48PM +0100, Philippe Mathieu-Daudé wrote:
>>> Hi,
>>>
>>> Using the following "build tools and doc" config:
>>>
>>> ../configure --disable-system --disable-user

So when using --disable-system, tools have to be explicitly selected
with --enable-tools.

>> Either way, all of this is surrounded by 'if have_block' in tests/meson.build
>> which should apply if you have tools enabled or system emulators enabled.
> 
> That helped:
> 
>                       block layer: NO
> 
> I'll see why the tools are not automatically selected.
> 
> Thanks,
> 
> Phil.
> 



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-01-20 14:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-20 12:50 How to run crypto benchmarks tests? Philippe Mathieu-Daudé
2021-01-20 13:06 ` Daniel P. Berrangé
2021-01-20 13:58   ` Philippe Mathieu-Daudé
2021-01-20 14:23     ` Philippe Mathieu-Daudé

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).