From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Cc: "Stefan Berger" <stefanb@linux.ibm.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Stefan Berger" <stefanb@linux.vnet.ibm.com>
Subject: [PULL 12/14] tests: Fix memory leak in tpm-util.c
Date: Wed, 20 Jan 2021 16:17:49 +0100 [thread overview]
Message-ID: <20210120151751.520597-13-thuth@redhat.com> (raw)
In-Reply-To: <20210120151751.520597-1-thuth@redhat.com>
From: Stefan Berger <stefanb@linux.vnet.ibm.com>
This patch fixes the following memory leak detected by asan:
Indirect leak of 560320 byte(s) in 136 object(s) allocated from:
#0 0x556b3b3f9b57 in calloc (/home/stefanb/tmp/qemu-tip/build/tests/qtest/tpm-crb-swtpm-test+0x23fb57)
#1 0x152b0e96b9b0 in g_malloc0 (/lib64/libglib-2.0.so.0+0x589b0)
#2 0x556b3b588f61 in parse_object /home/stefanb/tmp/qemu-tip/build/../qobject/json-parser.c:318:12
#3 0x556b3b588f61 in parse_value /home/stefanb/tmp/qemu-tip/build/../qobject/json-parser.c:546:16
#4 0x556b3b5886e8 in json_parser_parse /home/stefanb/tmp/qemu-tip/build/../qobject/json-parser.c:580:14
#5 0x556b3b52ff4a in json_message_process_token /home/stefanb/tmp/qemu-tip/build/../qobject/json-streamer.c:92:12
#6 0x556b3b59896f in json_lexer_feed_char /home/stefanb/tmp/qemu-tip/build/../qobject/json-lexer.c:313:13
#7 0x556b3b598443 in json_lexer_feed /home/stefanb/tmp/qemu-tip/build/../qobject/json-lexer.c:350:9
#8 0x556b3b436c70 in qmp_fd_receive /home/stefanb/tmp/qemu-tip/build/../tests/qtest/libqtest.c:614:9
#9 0x556b3b435871 in qtest_qmp_receive_dict /home/stefanb/tmp/qemu-tip/build/../tests/qtest/libqtest.c:636:12
#10 0x556b3b435871 in qtest_qmp_receive /home/stefanb/tmp/qemu-tip/build/../tests/qtest/libqtest.c:624:27
#11 0x556b3b435c59 in qtest_vqmp /home/stefanb/tmp/qemu-tip/build/../tests/qtest/libqtest.c:715:12
#12 0x556b3b435c59 in qtest_qmp /home/stefanb/tmp/qemu-tip/build/../tests/qtest/libqtest.c:756:16
#13 0x556b3b4328c7 in tpm_util_wait_for_migration_complete /home/stefanb/tmp/qemu-tip/build/../tests/qtest/tpm-util.c:245:15
#14 0x556b3b4333be in tpm_test_swtpm_migration_test /home/stefanb/tmp/qemu-tip/build/../tests/qtest/tpm-tests.c:117:5
#15 0x152b0e98e29d (/lib64/libglib-2.0.so.0+0x7b29d)
Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20210115204637.3332555-1-stefanb@linux.vnet.ibm.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/qtest/tpm-util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/tpm-util.c b/tests/qtest/tpm-util.c
index 5a33a6ef0f..b70cc32d60 100644
--- a/tests/qtest/tpm-util.c
+++ b/tests/qtest/tpm-util.c
@@ -250,7 +250,7 @@ void tpm_util_wait_for_migration_complete(QTestState *who)
status = qdict_get_str(rsp_return, "status");
completed = strcmp(status, "completed") == 0;
g_assert_cmpstr(status, !=, "failed");
- qobject_unref(rsp_return);
+ qobject_unref(rsp);
if (completed) {
return;
}
--
2.27.0
next prev parent reply other threads:[~2021-01-20 15:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 15:17 [PULL 00/14] gitlab-CI, qtests and misc patches Thomas Huth
2021-01-20 15:17 ` [PULL 01/14] osdep.h: Remove <sys/signal.h> include Thomas Huth
2021-01-20 15:17 ` [PULL 02/14] configure: Add sys/timex.h to probe clock_adjtime Thomas Huth
2021-01-20 15:17 ` [PULL 03/14] libvhost-user: Include poll.h instead of sys/poll.h Thomas Huth
2021-01-20 15:17 ` [PULL 04/14] hw/block/nand: Rename PAGE_SIZE to NAND_PAGE_SIZE Thomas Huth
2021-01-20 15:17 ` [PULL 05/14] elf2dmp: Rename PAGE_SIZE to ELF2DMP_PAGE_SIZE Thomas Huth
2021-01-20 15:17 ` [PULL 06/14] tests: Rename PAGE_SIZE definitions Thomas Huth
2021-01-20 15:17 ` [PULL 07/14] accel/kvm: avoid using predefined PAGE_SIZE Thomas Huth
2021-01-20 15:17 ` [PULL 08/14] tests/docker: Add dockerfile for Alpine Linux Thomas Huth
2021-01-20 15:17 ` [PULL 09/14] tests/check-block.sh: Refuse to run the iotests with BusyBox' sed Thomas Huth
2021-01-20 15:17 ` [PULL 10/14] gitlab-ci: Add alpine to pipeline Thomas Huth
2021-01-20 15:17 ` [PULL 11/14] qtest/npcm7xx_pwm-test: Fix memleak in pwm_qom_get Thomas Huth
2021-01-20 15:17 ` Thomas Huth [this message]
2021-01-20 15:17 ` [PULL 13/14] MAINTAINERS: Remove Ben Warren Thomas Huth
2021-01-20 15:17 ` [PULL 14/14] MAINTAINERS: Make status spellings consistent Thomas Huth
2021-01-21 9:40 ` [PULL 00/14] gitlab-CI, qtests and misc patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210120151751.520597-13-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanb@linux.ibm.com \
--cc=stefanb@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).