qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PATCH 3/3] configure: Emit warning when accelerator requested but not needed
Date: Wed, 20 Jan 2021 16:19:16 +0100	[thread overview]
Message-ID: <20210120151916.1167448-4-philmd@redhat.com> (raw)
In-Reply-To: <20210120151916.1167448-1-philmd@redhat.com>

In some configurations it might be pointless to check and
compile accelerator code. Do not deselect the accelerator,
but emit a warning.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 configure | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/configure b/configure
index a5159157a49..09e1cd8bfe6 100755
--- a/configure
+++ b/configure
@@ -5514,6 +5514,27 @@ if test $git_update = 'yes' ; then
     (cd "${source_path}" && GIT="$git" "./scripts/git-submodule.sh" update "$git_submodules")
 fi
 
+if [ "$softmmu" = "no" ]; then
+    if [ "$tcg" = "enabled" ]; then
+        echo "WARN: TCG accelerator selected but no target requires it"
+    fi
+    if [ "$kvm" = "enabled" ]; then
+        echo "WARN: KVM accelerator selected but no target requires it"
+    fi
+    if [ "$xen" = "enabled" ]; then
+        echo "WARN: Xen accelerator selected but no target requires it"
+    fi
+    if [ "$hax" = "enabled" ]; then
+        echo "WARN: HAX accelerator selected but no target requires it"
+    fi
+    if [ "$hvf" = "enabled" ]; then
+        echo "WARN: HVF accelerator selected but no target requires it"
+    fi
+    if [ "$whpx" = "enabled" ]; then
+        echo "WARN: WHPX accelerator selected but no target requires it"
+    fi
+fi
+
 config_host_mak="config-host.mak"
 
 echo "# Automatically generated by configure - do not modify" > $config_host_mak
-- 
2.26.2



  parent reply	other threads:[~2021-01-20 15:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-20 15:19 [PATCH 0/3] configure: Do not build TCG or link with capstone if not necessary Philippe Mathieu-Daudé
2021-01-20 15:19 ` [PATCH 1/3] configure: Do not build TCG " Philippe Mathieu-Daudé
2021-01-20 15:19 ` [PATCH 2/3] configure: Do not build/check for capstone when emulation is disabled Philippe Mathieu-Daudé
2021-01-20 15:19 ` Philippe Mathieu-Daudé [this message]
2021-01-20 16:33   ` [PATCH 3/3] configure: Emit warning when accelerator requested but not needed Thomas Huth
2021-01-20 17:00     ` Philippe Mathieu-Daudé
2021-01-20 16:46 ` [PATCH 0/3] configure: Do not build TCG or link with capstone if not necessary Paolo Bonzini
2021-01-20 17:02   ` Philippe Mathieu-Daudé
2021-01-20 17:35     ` Paolo Bonzini
2021-01-22 16:02       ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210120151916.1167448-4-philmd@redhat.com \
    --to=philmd@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).