From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1279C433E6 for ; Wed, 20 Jan 2021 16:16:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3C7F8233CE for ; Wed, 20 Jan 2021 16:16:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3C7F8233CE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56378 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2GAE-0006JS-2i for qemu-devel@archiver.kernel.org; Wed, 20 Jan 2021 11:16:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57044) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2G3V-0002hs-U0 for qemu-devel@nongnu.org; Wed, 20 Jan 2021 11:10:01 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:49111) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l2G3S-0000N3-7u for qemu-devel@nongnu.org; Wed, 20 Jan 2021 11:10:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611158995; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5D/CFWSOYl8XcLQUW2dTTNF9BKKi0+IWF0CIX2HcmZo=; b=Lqr1ZcN7WbHfjOm7H9/lzm2buOabrUgEM0ScqqLrb8VVfiAjoaac41syMEU+l8UoGAfsiT xmHQBEF6XJXhfIydLb8I3ET5GItdsV51+daY1uBWNQX3A89OAUHqKMxTMrnOg8unIIQHz3 8aBOWISu3E6RYqZqvL9F/mNFWu+UBJA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-199-RW5jSJHDO2yKwpB2XRnsvA-1; Wed, 20 Jan 2021 11:09:53 -0500 X-MC-Unique: RW5jSJHDO2yKwpB2XRnsvA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3B5E2806661; Wed, 20 Jan 2021 16:09:52 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-112-182.ams2.redhat.com [10.36.112.182]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BAB9219C81; Wed, 20 Jan 2021 16:09:48 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 2EC4E1800600; Wed, 20 Jan 2021 17:09:47 +0100 (CET) Date: Wed, 20 Jan 2021 17:09:47 +0100 From: Gerd Hoffmann To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Subject: Re: [PATCH v2 3/3] console: make QMP/HMP screendump run in coroutine Message-ID: <20210120160947.6nta7ghzn444ya6f@sirius.home.kraxel.org> References: <20201027133602.3038018-1-marcandre.lureau@redhat.com> <20201027133602.3038018-4-marcandre.lureau@redhat.com> <20210120141800.73j3xdew7ahvdewg@sirius.home.kraxel.org> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.167, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Markus Armbruster , QEMU , Stefan Hajnoczi , "Dr. David Alan Gilbert" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Jan 20, 2021 at 06:29:41PM +0400, Marc-André Lureau wrote: > Hi Gerd > > On Wed, Jan 20, 2021 at 6:18 PM Gerd Hoffmann wrote: > > > > On Tue, Oct 27, 2020 at 05:36:02PM +0400, marcandre.lureau@redhat.com wrote: > > > From: Marc-André Lureau > > > > > > Thanks to the monitors' coroutine support (merge commit b7092cda1b3), > > > the screendump handler can trigger a graphic_hw_update(), yield and let > > > the main loop run until update is done. Then the handler is resumed, and > > > ppm_save() will write the screen image to disk in the coroutine context. > > > > > > The IO is still blocking though, as the file is set blocking so far, > > > this could be addressed by some future change (with other caveats). > > > > > > Related to: > > > https://bugzilla.redhat.com/show_bug.cgi?id=1230527 > > > > > > Signed-off-by: Marc-André Lureau > > > Reviewed-by: Gerd Hoffmann > > > > Hmm, just noticed that with this patch applied screendump hangs for vms > > with "-device qxl" ("-device qxl-vga" works fine). > > > > Can you have a look? > > Weird, I cannot reproduce. I tried this way: > > $ qemu-system-x86_64 -m 4096 -enable-kvm -device qxl -qmp > unix:/tmp/qmp.sock,server -snapshot rhel8 -vga none or -nodefaults is needed, otherwise you'll get both VGA and qxl devices. Using gtk ui, just saying "screendump /tmp/x" in the monitor tab. > Can you also provide a backtrace? Thread 9 (Thread 0x7fab97638640 (LWP 2822854) "pool-qemu"): #0 0x00007fab9c8af30d in syscall () at /lib64/libc.so.6 #1 0x00007fab9db7f2ec in g_cond_wait_until () at /lib64/libglib-2.0.so.0 #2 0x00007fab9db033c1 in g_async_queue_pop_intern_unlocked () at /lib64/libglib-2.0.so.0 #3 0x00007fab9db03546 in g_async_queue_timeout_pop () at /lib64/libglib-2.0.so.0 #4 0x00007fab9db62ef9 in g_thread_pool_thread_proxy.lto_priv () at /lib64/libglib-2.0.so.0 #5 0x00007fab9db602b2 in g_thread_proxy () at /lib64/libglib-2.0.so.0 #6 0x00007fab9c9873f9 in start_thread () at /lib64/libpthread.so.0 #7 0x00007fab9c8b4903 in clone () at /lib64/libc.so.6 Thread 8 (Thread 0x7fab37dff640 (LWP 2822804) "SPICE Worker"): #0 0x00007fab9c8a980f in poll () at /lib64/libc.so.6 #1 0x00007fab9db846f6 in g_main_context_iterate.constprop () at /lib64/libglib-2.0.so.0 #2 0x00007fab9db32033 in g_main_loop_run () at /lib64/libglib-2.0.so.0 #3 0x00007fab9de87c66 in red_worker_main.lto_priv () at /lib64/libspice-server.so.1 #4 0x00007fab9c9873f9 in start_thread () at /lib64/libpthread.so.0 #5 0x00007fab9c8b4903 in clone () at /lib64/libc.so.6 Thread 7 (Thread 0x7fab95a8b640 (LWP 2822803) "qemu-system-x86"): #0 0x00007fab9c990ea0 in __lll_lock_wait () at /lib64/libpthread.so.0 #1 0x00007fab9c989763 in pthread_mutex_lock () at /lib64/libpthread.so.0 #2 0x000055f3f9c1c7e9 in qemu_mutex_lock_impl () #3 0x000055f3f9a1357f in qemu_mutex_lock_iothread_impl () #4 0x000055f3f9a52c86 in mttcg_cpu_thread_fn () #5 0x000055f3f9c1c689 in qemu_thread_start () #6 0x00007fab9c9873f9 in start_thread () at /lib64/libpthread.so.0 #7 0x00007fab9c8b4903 in clone () at /lib64/libc.so.6 Thread 6 (Thread 0x7fab96596640 (LWP 2822802) "dconf worker"): #0 0x00007fab9c8a980f in poll () at /lib64/libc.so.6 #1 0x00007fab9db846f6 in g_main_context_iterate.constprop () at /lib64/libglib-2.0.so.0 #2 0x00007fab9db2fd43 in g_main_context_iteration () at /lib64/libglib-2.0.so.0 #3 0x00007fab9e0ac64d in dconf_gdbus_worker_thread () at /usr/lib64/gio/modules/libdconfsettings.so #4 0x00007fab9db602b2 in g_thread_proxy () at /lib64/libglib-2.0.so.0 #5 0x00007fab9c9873f9 in start_thread () at /lib64/libpthread.so.0 #6 0x00007fab9c8b4903 in clone () at /lib64/libc.so.6 Thread 5 (Thread 0x7fab96d97640 (LWP 2822801) "gdbus"): #0 0x00007fab9c8a980f in poll () at /lib64/libc.so.6 #1 0x00007fab9db846f6 in g_main_context_iterate.constprop () at /lib64/libglib-2.0.so.0 #2 0x00007fab9db32033 in g_main_loop_run () at /lib64/libglib-2.0.so.0 #3 0x00007fab9da21d1a in gdbus_shared_thread_func.lto_priv () at /lib64/libgio-2.0.so.0 #4 0x00007fab9db602b2 in g_thread_proxy () at /lib64/libglib-2.0.so.0 #5 0x00007fab9c9873f9 in start_thread () at /lib64/libpthread.so.0 #6 0x00007fab9c8b4903 in clone () at /lib64/libc.so.6 Thread 3 (Thread 0x7fab97e39640 (LWP 2822799) "gmain"): #0 0x00007fab9c8a980f in poll () at /lib64/libc.so.6 #1 0x00007fab9db846f6 in g_main_context_iterate.constprop () at /lib64/libglib-2.0.so.0 #2 0x00007fab9db2fd43 in g_main_context_iteration () at /lib64/libglib-2.0.so.0 #3 0x00007fab9db31961 in glib_worker_main () at /lib64/libglib-2.0.so.0 #4 0x00007fab9db602b2 in g_thread_proxy () at /lib64/libglib-2.0.so.0 #5 0x00007fab9c9873f9 in start_thread () at /lib64/libpthread.so.0 #6 0x00007fab9c8b4903 in clone () at /lib64/libc.so.6 Thread 2 (Thread 0x7fab9873b640 (LWP 2822798) "qemu-system-x86"): #0 0x00007fab9c8af30d in syscall () at /lib64/libc.so.6 #1 0x000055f3f9c1d53a in qemu_event_wait () #2 0x000055f3f9c17c9a in call_rcu_thread () #3 0x000055f3f9c1c689 in qemu_thread_start () #4 0x00007fab9c9873f9 in start_thread () at /lib64/libpthread.so.0 #5 0x00007fab9c8b4903 in clone () at /lib64/libc.so.6 Thread 1 (Thread 0x7fab988e4440 (LWP 2822797) "qemu-system-x86"): #0 0x00007fab9c8a990e in ppoll () at /lib64/libc.so.6 #1 0x000055f3f9c33dd5 in fdmon_poll_wait () #2 0x000055f3f9c26c6a in aio_poll () #3 0x000055f3f99552a5 in handle_hmp_command () #4 0x000055f3f99553cd in monitor_command_cb () #5 0x000055f3f9c29a37 in readline_handle_byte () #6 0x000055f3f995541b in monitor_read () #7 0x000055f3f992373c in gd_vc_in () #8 0x00007fab9d84e22d in _vte_marshal_VOID__STRING_UINTv () at /lib64/libvte-2.91.so.0 #9 0x00007fab9d8e9080 in g_signal_emit_valist () at /lib64/libgobject-2.0.so.0 #10 0x00007fab9d8e91a3 in g_signal_emit () at /lib64/libgobject-2.0.so.0 #11 0x00007fab9d858a7e in vte::terminal::Terminal::emit_commit(std::basic_string_view > const&) () at /lib64/libvte-2.91.so.0 #12 0x00007fab9d85cf1d in vte::terminal::Terminal::send_child(std::basic_string_view > const&) () at /lib64/libvte-2.91.so.0 #13 0x00007fab9d8715bc in vte_terminal_key_press(_GtkWidget*, _GdkEventKey*) () at /lib64/libvte-2.91.so.0 #14 0x00007fab9d47eccc in _gtk_marshal_BOOLEAN__BOXEDv () at /lib64/libgtk-3.so.0 #15 0x00007fab9d8e869a in g_signal_emit_valist () at /lib64/libgobject-2.0.so.0 #16 0x00007fab9d8e91a3 in g_signal_emit () at /lib64/libgobject-2.0.so.0 #17 0x00007fab9d441bb4 in gtk_widget_event_internal.part.0.lto_priv () at /lib64/libgtk-3.so.0 #18 0x00007fab9d45029b in gtk_window_propagate_key_event () at /lib64/libgtk-3.so.0 #19 0x00007fab9d453283 in gtk_window_key_press_event.lto_priv () at /lib64/libgtk-3.so.0 #20 0x00007fab9d47eccc in _gtk_marshal_BOOLEAN__BOXEDv () at /lib64/libgtk-3.so.0 #21 0x00007fab9d8e9080 in g_signal_emit_valist () at /lib64/libgobject-2.0.so.0 #22 0x00007fab9d8e91a3 in g_signal_emit () at /lib64/libgobject-2.0.so.0 #23 0x00007fab9d441bb4 in gtk_widget_event_internal.part.0.lto_priv () at /lib64/libgtk-3.so.0 #24 0x00007fab9d2e000f in propagate_event.lto_priv () at /lib64/libgtk-3.so.0 #25 0x00007fab9d2e1223 in gtk_main_do_event () at /lib64/libgtk-3.so.0 #26 0x00007fab9cfbb633 in _gdk_event_emit () at /lib64/libgdk-3.so.0 #27 0x00007fab9d022ba6 in gdk_event_source_dispatch.lto_priv () at /lib64/libgdk-3.so.0 #28 0x00007fab9db3296f in g_main_context_dispatch () at /lib64/libglib-2.0.so.0 #29 0x000055f3f9c24f58 in main_loop_wait () #30 0x000055f3f9a564b1 in qemu_main_loop () #31 0x000055f3f97609ee in main () take care, Gerd