Re: [PATCH v2 7/8] meson: Display cryto-related information altogether

["Daniel P. Berrangé" <berrange@redhat.com>]

On Thu, Jan 21, 2021 at 10:11:32AM +0000, Daniel P. Berrangé wrote:
> On Thu, Jan 21, 2021 at 10:56:15AM +0100, Philippe Mathieu-Daudé wrote:
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> > ---
> > Cc: Daniel P. Berrange <berrange@redhat.com>
> > ---
> >  meson.build | 34 +++++++++++++++++++---------------
> >  1 file changed, 19 insertions(+), 15 deletions(-)
> > 
> > diff --git a/meson.build b/meson.build
> > index e372b69f163..9274775a81a 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -2453,19 +2453,8 @@
> >  endif
> >  summary(summary_info, bool_yn: true, section: 'Block layer support')
> >  
> > +# Crypto
> 
> Rather than a comment why not introduce grouping in the output
> so it is visible when reading the summary.
> 
> This can be done in meson by calling summary() multiple times
> giving "section: 'Crypto'"  arg.

Sigh, I'm not very good at reading this morning. I see this
is in fact done in this patch, I just couldn't see it in the
diff :-(


...
> > +summary(summary_info, bool_yn: true, section: 'Crypto')


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|