From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B53FC433E0 for ; Thu, 21 Jan 2021 12:04:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A09012395A for ; Thu, 21 Jan 2021 12:04:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A09012395A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38580 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2YhT-0003Zz-9t for qemu-devel@archiver.kernel.org; Thu, 21 Jan 2021 07:04:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60670) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2Yg0-0002jl-7o for qemu-devel@nongnu.org; Thu, 21 Jan 2021 07:03:00 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:30521) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l2Yfy-0007d2-5y for qemu-devel@nongnu.org; Thu, 21 Jan 2021 07:03:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611230577; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6MxdKTvLqhLWwH7oStWcPBwjJgqoDktU1pyt5ldTkLk=; b=PfBphJI1HYhoxDsxLgrMgJI0KJT6KgnVd5ozk9lQ63K/WwUt1zKlLcKw5Njsp/SKfOv7yN T29iV7HQwT/tPRkLCq3jdj08HPl2mexA2x/uoBuvyTjTAOnOLvl4dkQTKl6HA80U6pt+an JYl9/NlvSxMtXy+vBWzHNNlq83pk6i8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-249-lwh-D4K_Nem6TQWdkTKBJQ-1; Thu, 21 Jan 2021 07:02:49 -0500 X-MC-Unique: lwh-D4K_Nem6TQWdkTKBJQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E0460612AE; Thu, 21 Jan 2021 12:02:46 +0000 (UTC) Received: from redhat.com (ovpn-115-126.ams2.redhat.com [10.36.115.126]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5302960CE7; Thu, 21 Jan 2021 12:02:44 +0000 (UTC) Date: Thu, 21 Jan 2021 12:02:41 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [RFC PATCH 2/2] gitlab-ci: Add a job building TCI with Clang Message-ID: <20210121120241.GK3125227@redhat.com> References: <20210110162739.858087-1-f4bug@amsat.org> <20210110162739.858087-3-f4bug@amsat.org> <78a9718b-dec0-cc31-7ada-e815d9022e65@redhat.com> <20210121103250.GH3125227@redhat.com> <20210121112154.GJ3125227@redhat.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.168, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Thomas Huth , Stefan Weil , Richard Henderson , qemu-devel@nongnu.org, Wataru Ashihara , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Wainer dos Santos Moschetta , Alex =?utf-8?Q?Benn=C3=A9e?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Jan 21, 2021 at 12:48:21PM +0100, Philippe Mathieu-Daudé wrote: > On 1/21/21 12:21 PM, Daniel P. Berrangé wrote: > > On Thu, Jan 21, 2021 at 12:18:18PM +0100, Philippe Mathieu-Daudé wrote: > >> On 1/21/21 11:32 AM, Daniel P. Berrangé wrote: > >>> On Thu, Jan 21, 2021 at 11:08:29AM +0100, Thomas Huth wrote: > >>>> On 10/01/2021 17.27, Philippe Mathieu-Daudé wrote: > >>>>> Split the current GCC build-tci job in 2, and use Clang > >>>>> compiler in the new job. > >>>>> > >>>>> Signed-off-by: Philippe Mathieu-Daudé > >>>>> --- > >>>>> RFC in case someone have better idea to optimize can respin this patch. > >>>>> > >>>>> .gitlab-ci.yml | 22 ++++++++++++++++++++-- > >>>>> 1 file changed, 20 insertions(+), 2 deletions(-) > >>>> > >>>> I'm not quite sure whether we should go down this road ... if we wanted to > >>>> have full test coverage for clang, we'd need to duplicate *all* jobs to run > >>>> them once with gcc and once with clang. And that would be just overkill. > >>>> > >>>> I think we already catch most clang-related problems with the clang jobs > >>>> that we already have in our CI, so problems like the ones that you've tried > >>>> to address here should be very, very rare. So I'd rather vote for not > >>>> splitting the job here. > >>> > >>> We can't possibly cope with the fully expanded matrix of what are > >>> theoretically possible combinations. Thus I think we should be guided > >>> by what is expected real world usage by platforms we target. > >>> > >>> Essentially for any given distro we're testing on, our primary focus > >>> should be to use the toolchain that distro will build QEMU with. > >>> > >>> IOW, for Windows and Linux distros our primary focus should be GCC, > >>> while for macOS, and *BSD, our focus should be CLang. > >> > >> Sounds good. > >> > >> Do we need a TCI job on macOS then? > > > > TCI is only relevant if there is no native TCG host impl. > > > > macOS only targets aarch64 and x86_64, both of which have TCG, so there > > is no reason to use TCI on macOS AFAICT > > Yes, fine by me, but Wataru Ashihara reported the bug... ¯\_(ツ)_/¯ It doesn't look like they were using macOS - the message suggests Ubuntu host, and AFAIK, all Ubuntu architectures have support for TCG, so using TCI shouldn't have been required in the first place. I guess we could benefit from a TCI job of some kind that uses CLang on at least 1 platform, since none exists. This does yet again open up the question of whether we should be supporting TCI at all in this particular user's scenario though, since both KVM and TCG are available on Ubuntu x86 hosts already. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|