From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30C9AC433DB for ; Thu, 21 Jan 2021 17:38:17 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A8E1206B5 for ; Thu, 21 Jan 2021 17:38:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A8E1206B5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:32830 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2duR-0006RC-Ex for qemu-devel@archiver.kernel.org; Thu, 21 Jan 2021 12:38:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60238) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2dsO-0004jY-QC for qemu-devel@nongnu.org; Thu, 21 Jan 2021 12:36:08 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:60911) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l2dsK-0006lU-Gn for qemu-devel@nongnu.org; Thu, 21 Jan 2021 12:36:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611250562; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2HXB8FXwhUqBTGDXT07D3W67DubH2hPrCn1w/WeHZCs=; b=Vbuoc15pp5OVZZus0dkXx7HEdC4hJcxYegUblYGVZASKBWaDPqY1kWf01j5CTd9SsRsPBe vZGXFB546v+Whd9c/EdJLXz3Tu/ZulRx0k1rwH7HqvLB9vD62e3GqmlI4WuSf3Lt8gFVwQ SSCP6C5oRYibgatUeudi+nZIupFRD1o= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-460-VmMP8OJKObavkTJPhEmHXQ-1; Thu, 21 Jan 2021 12:36:01 -0500 X-MC-Unique: VmMP8OJKObavkTJPhEmHXQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0A6CA107ACF8; Thu, 21 Jan 2021 17:36:00 +0000 (UTC) Received: from work-vm (ovpn-115-101.ams2.redhat.com [10.36.115.101]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4417160C43; Thu, 21 Jan 2021 17:35:56 +0000 (UTC) Date: Thu, 21 Jan 2021 17:35:53 +0000 From: "Dr. David Alan Gilbert" To: Greg Kurz Subject: Re: [PATCH] virtiofsd: Add _llseek to the seccomp whitelist Message-ID: <20210121173553.GL3072@work-vm> References: <20210121171540.1449777-1-groug@kaod.org> MIME-Version: 1.0 In-Reply-To: <20210121171540.1449777-1-groug@kaod.org> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dgilbert@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=63.128.21.124; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.168, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Stefan Hajnoczi Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Greg Kurz (groug@kaod.org) wrote: > This is how glibc implements lseek(2) on POWER. > > BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1917692 > Signed-off-by: Greg Kurz OK, I'm going to assume that _llseek is present on pretty much everything? Reviewed-by: Dr. David Alan Gilbert > --- > tools/virtiofsd/passthrough_seccomp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/virtiofsd/passthrough_seccomp.c b/tools/virtiofsd/passthrough_seccomp.c > index a60d7da4b4e2..1ecf5bf318b3 100644 > --- a/tools/virtiofsd/passthrough_seccomp.c > +++ b/tools/virtiofsd/passthrough_seccomp.c > @@ -65,6 +65,7 @@ static const int syscall_whitelist[] = { > SCMP_SYS(linkat), > SCMP_SYS(listxattr), > SCMP_SYS(lseek), > + SCMP_SYS(_llseek), /* For POWER */ > SCMP_SYS(madvise), > SCMP_SYS(mkdirat), > SCMP_SYS(mknodat), > -- > 2.26.2 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK