From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C96AC433DB for ; Fri, 22 Jan 2021 12:47:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A5C7F22DCC for ; Fri, 22 Jan 2021 12:47:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A5C7F22DCC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37822 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2vqB-0005ng-Bg for qemu-devel@archiver.kernel.org; Fri, 22 Jan 2021 07:47:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51290) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2vp5-0005DH-PO for qemu-devel@nongnu.org; Fri, 22 Jan 2021 07:45:56 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:44022) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l2vp0-0001sf-LA for qemu-devel@nongnu.org; Fri, 22 Jan 2021 07:45:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611319549; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vxki1qLdIXQMf6eDmoggZE2PQlpfPrI723EJx+YpMoA=; b=daNRobMcwORo59KbhBm/pn8bUsy5+rM5lGQnnqysgIUnqKkZ0/u88MhfgTpXQtGVjYOL4c aKJqeWrfXbrglOFu7ctkYX7epWazVfGJHRn6S8XSqJoP01pNCgFZ4Gvz6yyRv999JDHOSv VZRsxGFwk41AF7ICZSmqZN124LdgY4U= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-458-_L22FuYpPaGFKuDBeeMDSw-1; Fri, 22 Jan 2021 07:45:45 -0500 X-MC-Unique: _L22FuYpPaGFKuDBeeMDSw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B1B18107ACE3; Fri, 22 Jan 2021 12:45:44 +0000 (UTC) Received: from merkur.fritz.box (ovpn-115-18.ams2.redhat.com [10.36.115.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2AEDA6EF40; Fri, 22 Jan 2021 12:45:43 +0000 (UTC) Date: Fri, 22 Jan 2021 13:45:41 +0100 From: Kevin Wolf To: Vladimir Sementsov-Ogievskiy Subject: Re: [PATCH v7 07/11] iotests: add findtests.py Message-ID: <20210122124541.GE15866@merkur.fritz.box> References: <20210116134424.82867-1-vsementsov@virtuozzo.com> <20210116134424.82867-8-vsementsov@virtuozzo.com> <20210122114815.GC15866@merkur.fritz.box> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kwolf@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=63.128.21.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.182, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, mreitz@redhat.com, den@openvz.org, jsnow@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 22.01.2021 um 12:57 hat Vladimir Sementsov-Ogievskiy geschrieben: > 22.01.2021 14:48, Kevin Wolf wrote: > > Am 16.01.2021 um 14:44 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > + def add_group_file(self, fname: str) -> None: > > > + with open(fname) as f: > > > + for line in f: > > > + line = line.strip() > > > + > > > + if (not line) or line[0] == '#': > > > + continue > > > + > > > + words = line.split() > > > + test_file = self.parse_test_name(words[0]) > > > + groups = words[1:] > > > > The previous version still had this: > > > > + if test_file not in self.all_tests: > > + print(f'Warning: {fname}: "{test_file}" test is not found.' > > + ' Skip.') > > + continue > > > > Why did you remove it? I found this useful when I had a wrong test name > > in my group.local. Now it's silently ignored. > > > Because now we use parse_test_name which will raise ValueError, so we > will not go to this if anyway. > > So, wrong name will not be silently ignored, check will fail, and > you'll have to fix group file.. It is suitable? It doesn't, though. Oh, wait... Is it possible that you lost support for group.local altogether? grep for "group.local" comes up empty, and add_group_file() is only defined, but never called. So the reason for the behaviour seems to be that it doesn't even try to parse the group file. Kevin