From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-devel@nongnu.org
Cc: "Pragnesh Patel" <pragnesh.patel@sifive.com>,
"Bin Meng" <bin.meng@windriver.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-block@nongnu.org
Subject: [PULL 2/9] hw/sd: sd: Support CMD59 for SPI mode
Date: Sun, 24 Jan 2021 21:10:59 +0100 [thread overview]
Message-ID: <20210124201106.2602238-3-f4bug@amsat.org> (raw)
In-Reply-To: <20210124201106.2602238-1-f4bug@amsat.org>
From: Bin Meng <bin.meng@windriver.com>
After the card is put into SPI mode, CRC check for all commands
including CMD0 will be done according to CMD59 setting. But this
command is currently unimplemented. Simply allow the decoding of
CMD59, but the CRC remains unchecked.
Signed-off-by: Bin Meng <bin.meng@windriver.com>
Tested-by: Pragnesh Patel <pragnesh.patel@sifive.com>
Reviewed-by: Pragnesh Patel <pragnesh.patel@sifive.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20210123104016.17485-5-bmeng.cn@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/sd/sd.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/hw/sd/sd.c b/hw/sd/sd.c
index 4375ed5b8b2..bfea5547d53 100644
--- a/hw/sd/sd.c
+++ b/hw/sd/sd.c
@@ -1517,18 +1517,12 @@ static sd_rsp_type_t sd_normal_command(SDState *sd, SDRequest req)
if (!sd->spi) {
goto bad_cmd;
}
- goto unimplemented_spi_cmd;
+ return sd_r1;
default:
bad_cmd:
qemu_log_mask(LOG_GUEST_ERROR, "SD: Unknown CMD%i\n", req.cmd);
return sd_illegal;
-
- unimplemented_spi_cmd:
- /* Commands that are recognised but not yet implemented in SPI mode. */
- qemu_log_mask(LOG_UNIMP, "SD: CMD%i not implemented in SPI mode\n",
- req.cmd);
- return sd_illegal;
}
qemu_log_mask(LOG_GUEST_ERROR, "SD: CMD%i in a wrong state\n", req.cmd);
--
2.26.2
next prev parent reply other threads:[~2021-01-24 20:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-24 20:10 [PULL 0/9] SD/MMC patches for 2021-01-24 Philippe Mathieu-Daudé
2021-01-24 20:10 ` [PULL 1/9] hw/sd: ssi-sd: Fix incorrect card response sequence Philippe Mathieu-Daudé
2021-01-24 20:10 ` Philippe Mathieu-Daudé [this message]
2021-01-24 20:11 ` [PULL 3/9] hw/sd: sd: Drop sd_crc16() Philippe Mathieu-Daudé
2021-01-24 20:11 ` [PULL 4/9] util: Add CRC16 (CCITT) calculation routines Philippe Mathieu-Daudé
2021-01-24 20:11 ` [PULL 5/9] hw/sd: ssi-sd: Suffix a data block with CRC16 Philippe Mathieu-Daudé
2021-01-24 20:11 ` [PULL 6/9] hw/sd: ssi-sd: Add a state representing Nac Philippe Mathieu-Daudé
2021-01-24 20:11 ` [PULL 7/9] hw/sd: ssi-sd: Fix the wrong command index for STOP_TRANSMISSION Philippe Mathieu-Daudé
2021-01-24 20:11 ` [PULL 8/9] hw/sd: ssi-sd: Use macros for the dummy value and tokens in the transfer Philippe Mathieu-Daudé
2021-01-24 20:11 ` [PULL 9/9] hw/sd: sd.h: Cosmetic change of using spaces Philippe Mathieu-Daudé
2021-01-25 13:48 ` [PULL 0/9] SD/MMC patches for 2021-01-24 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210124201106.2602238-3-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=bin.meng@windriver.com \
--cc=pragnesh.patel@sifive.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).