From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-devel@nongnu.org
Cc: "Bin Meng" <bin.meng@windriver.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-block@nongnu.org
Subject: [PULL 7/9] hw/sd: ssi-sd: Fix the wrong command index for STOP_TRANSMISSION
Date: Sun, 24 Jan 2021 21:11:04 +0100 [thread overview]
Message-ID: <20210124201106.2602238-8-f4bug@amsat.org> (raw)
In-Reply-To: <20210124201106.2602238-1-f4bug@amsat.org>
From: Bin Meng <bin.meng@windriver.com>
This fixes the wrong command index for STOP_TRANSMISSION, the
required command to interrupt the multiple block read command,
in the old codes. It should be CMD12 (0x4c), not CMD13 (0x4d).
Fixes: 775616c3ae8c ("Partial SD card SPI mode support")
Signed-off-by: Bin Meng <bin.meng@windriver.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20210123104016.17485-10-bmeng.cn@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/sd/ssi-sd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/sd/ssi-sd.c b/hw/sd/ssi-sd.c
index 1cdaf73c292..12dffb6f55e 100644
--- a/hw/sd/ssi-sd.c
+++ b/hw/sd/ssi-sd.c
@@ -83,7 +83,7 @@ static uint32_t ssi_sd_transfer(SSIPeripheral *dev, uint32_t val)
ssi_sd_state *s = SSI_SD(dev);
/* Special case: allow CMD12 (STOP TRANSMISSION) while reading data. */
- if (s->mode == SSI_SD_DATA_READ && val == 0x4d) {
+ if (s->mode == SSI_SD_DATA_READ && val == 0x4c) {
s->mode = SSI_SD_CMD;
/* There must be at least one byte delay before the card responds. */
s->stopping = 1;
--
2.26.2
next prev parent reply other threads:[~2021-01-24 20:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-24 20:10 [PULL 0/9] SD/MMC patches for 2021-01-24 Philippe Mathieu-Daudé
2021-01-24 20:10 ` [PULL 1/9] hw/sd: ssi-sd: Fix incorrect card response sequence Philippe Mathieu-Daudé
2021-01-24 20:10 ` [PULL 2/9] hw/sd: sd: Support CMD59 for SPI mode Philippe Mathieu-Daudé
2021-01-24 20:11 ` [PULL 3/9] hw/sd: sd: Drop sd_crc16() Philippe Mathieu-Daudé
2021-01-24 20:11 ` [PULL 4/9] util: Add CRC16 (CCITT) calculation routines Philippe Mathieu-Daudé
2021-01-24 20:11 ` [PULL 5/9] hw/sd: ssi-sd: Suffix a data block with CRC16 Philippe Mathieu-Daudé
2021-01-24 20:11 ` [PULL 6/9] hw/sd: ssi-sd: Add a state representing Nac Philippe Mathieu-Daudé
2021-01-24 20:11 ` Philippe Mathieu-Daudé [this message]
2021-01-24 20:11 ` [PULL 8/9] hw/sd: ssi-sd: Use macros for the dummy value and tokens in the transfer Philippe Mathieu-Daudé
2021-01-24 20:11 ` [PULL 9/9] hw/sd: sd.h: Cosmetic change of using spaces Philippe Mathieu-Daudé
2021-01-25 13:48 ` [PULL 0/9] SD/MMC patches for 2021-01-24 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210124201106.2602238-8-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=bin.meng@windriver.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).