* [Qemu-devel][PATCH] x86/cpu: Use max host physical address if -cpu max option is applied @ 2021-01-13 9:04 Yang Weijiang 2021-01-13 10:06 ` Paolo Bonzini 2021-01-24 21:08 ` Nathan Chancellor 0 siblings, 2 replies; 9+ messages in thread From: Yang Weijiang @ 2021-01-13 9:04 UTC (permalink / raw) To: pbonzini, seanjc, qemu-devel; +Cc: Yang Weijiang QEMU option -cpu max(max_features) means "Enables all features supported by the accelerator in the current host", this looks true for all the features except guest max physical address width, so add this patch to enable it. Signed-off-by: Yang Weijiang <weijiang.yang@intel.com> --- target/i386/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 35459a38bb..b5943406f7 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -6673,7 +6673,7 @@ static void x86_cpu_realizefn(DeviceState *dev, Error **errp) warned = true; } - if (cpu->host_phys_bits) { + if (cpu->host_phys_bits || cpu->max_features) { /* The user asked for us to use the host physical bits */ cpu->phys_bits = host_phys_bits; if (cpu->host_phys_bits_limit && -- 2.17.2 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [Qemu-devel][PATCH] x86/cpu: Use max host physical address if -cpu max option is applied 2021-01-13 9:04 [Qemu-devel][PATCH] x86/cpu: Use max host physical address if -cpu max option is applied Yang Weijiang @ 2021-01-13 10:06 ` Paolo Bonzini 2021-01-13 15:04 ` Yang Weijiang 2021-01-24 21:08 ` Nathan Chancellor 1 sibling, 1 reply; 9+ messages in thread From: Paolo Bonzini @ 2021-01-13 10:06 UTC (permalink / raw) To: Yang Weijiang, seanjc, qemu-devel On 13/01/21 10:04, Yang Weijiang wrote: > QEMU option -cpu max(max_features) means "Enables all features supported by > the accelerator in the current host", this looks true for all the features > except guest max physical address width, so add this patch to enable it. > > Signed-off-by: Yang Weijiang <weijiang.yang@intel.com> > --- > target/i386/cpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/i386/cpu.c b/target/i386/cpu.c > index 35459a38bb..b5943406f7 100644 > --- a/target/i386/cpu.c > +++ b/target/i386/cpu.c > @@ -6673,7 +6673,7 @@ static void x86_cpu_realizefn(DeviceState *dev, Error **errp) > warned = true; > } > > - if (cpu->host_phys_bits) { > + if (cpu->host_phys_bits || cpu->max_features) { > /* The user asked for us to use the host physical bits */ > cpu->phys_bits = host_phys_bits; > if (cpu->host_phys_bits_limit && > Can you check if this works? diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 35459a38bb..72a79e6019 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -4319,6 +4319,7 @@ static void max_x86_cpu_initfn(Object *obj) if (lmce_supported()) { object_property_set_bool(OBJECT(cpu), "lmce", true, &error_abort); } + object_property_set_bool(OBJECT(cpu), "host-phys-bits", true, &error_abort); } else { object_property_set_str(OBJECT(cpu), "vendor", CPUID_VENDOR_AMD, &error_abort); It should allow people to use -cpu max,host-phys-bits=false. Thanks, Paolo ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [Qemu-devel][PATCH] x86/cpu: Use max host physical address if -cpu max option is applied 2021-01-13 10:06 ` Paolo Bonzini @ 2021-01-13 15:04 ` Yang Weijiang 2021-01-13 15:41 ` Paolo Bonzini 0 siblings, 1 reply; 9+ messages in thread From: Yang Weijiang @ 2021-01-13 15:04 UTC (permalink / raw) To: Paolo Bonzini; +Cc: Yang Weijiang, qemu-devel, seanjc On Wed, Jan 13, 2021 at 11:06:09AM +0100, Paolo Bonzini wrote: > On 13/01/21 10:04, Yang Weijiang wrote: > > QEMU option -cpu max(max_features) means "Enables all features supported by > > the accelerator in the current host", this looks true for all the features > > except guest max physical address width, so add this patch to enable it. > > > > Signed-off-by: Yang Weijiang <weijiang.yang@intel.com> > > --- > > target/i386/cpu.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/target/i386/cpu.c b/target/i386/cpu.c > > index 35459a38bb..b5943406f7 100644 > > --- a/target/i386/cpu.c > > +++ b/target/i386/cpu.c > > @@ -6673,7 +6673,7 @@ static void x86_cpu_realizefn(DeviceState *dev, Error **errp) > > warned = true; > > } > > - if (cpu->host_phys_bits) { > > + if (cpu->host_phys_bits || cpu->max_features) { > > /* The user asked for us to use the host physical bits */ > > cpu->phys_bits = host_phys_bits; > > if (cpu->host_phys_bits_limit && > > > > Can you check if this works? > Hi, Paolo, Yes, below change works for kvm-unit-test/access. Would you add the patch? Thanks! > diff --git a/target/i386/cpu.c b/target/i386/cpu.c > index 35459a38bb..72a79e6019 100644 > --- a/target/i386/cpu.c > +++ b/target/i386/cpu.c > @@ -4319,6 +4319,7 @@ static void max_x86_cpu_initfn(Object *obj) > if (lmce_supported()) { > object_property_set_bool(OBJECT(cpu), "lmce", true, > &error_abort); > } > + object_property_set_bool(OBJECT(cpu), "host-phys-bits", true, > &error_abort); > } else { > object_property_set_str(OBJECT(cpu), "vendor", CPUID_VENDOR_AMD, > &error_abort); > > > It should allow people to use -cpu max,host-phys-bits=false. > > Thanks, > > Paolo ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Qemu-devel][PATCH] x86/cpu: Use max host physical address if -cpu max option is applied 2021-01-13 15:04 ` Yang Weijiang @ 2021-01-13 15:41 ` Paolo Bonzini 0 siblings, 0 replies; 9+ messages in thread From: Paolo Bonzini @ 2021-01-13 15:41 UTC (permalink / raw) To: Yang Weijiang; +Cc: Sean Christopherson, qemu-devel [-- Attachment #1: Type: text/plain, Size: 2114 bytes --] Yes, thanks. Paolo Il mer 13 gen 2021, 15:52 Yang Weijiang <weijiang.yang@intel.com> ha scritto: > On Wed, Jan 13, 2021 at 11:06:09AM +0100, Paolo Bonzini wrote: > > On 13/01/21 10:04, Yang Weijiang wrote: > > > QEMU option -cpu max(max_features) means "Enables all features > supported by > > > the accelerator in the current host", this looks true for all the > features > > > except guest max physical address width, so add this patch to enable > it. > > > > > > Signed-off-by: Yang Weijiang <weijiang.yang@intel.com> > > > --- > > > target/i386/cpu.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/target/i386/cpu.c b/target/i386/cpu.c > > > index 35459a38bb..b5943406f7 100644 > > > --- a/target/i386/cpu.c > > > +++ b/target/i386/cpu.c > > > @@ -6673,7 +6673,7 @@ static void x86_cpu_realizefn(DeviceState *dev, > Error **errp) > > > warned = true; > > > } > > > - if (cpu->host_phys_bits) { > > > + if (cpu->host_phys_bits || cpu->max_features) { > > > /* The user asked for us to use the host physical > bits */ > > > cpu->phys_bits = host_phys_bits; > > > if (cpu->host_phys_bits_limit && > > > > > > > Can you check if this works? > > > Hi, Paolo, > Yes, below change works for kvm-unit-test/access. Would you add the > patch? > > Thanks! > > > diff --git a/target/i386/cpu.c b/target/i386/cpu.c > > index 35459a38bb..72a79e6019 100644 > > --- a/target/i386/cpu.c > > +++ b/target/i386/cpu.c > > @@ -4319,6 +4319,7 @@ static void max_x86_cpu_initfn(Object *obj) > > if (lmce_supported()) { > > object_property_set_bool(OBJECT(cpu), "lmce", true, > > &error_abort); > > } > > + object_property_set_bool(OBJECT(cpu), "host-phys-bits", true, > > &error_abort); > > } else { > > object_property_set_str(OBJECT(cpu), "vendor", CPUID_VENDOR_AMD, > > &error_abort); > > > > > > It should allow people to use -cpu max,host-phys-bits=false. > > > > Thanks, > > > > Paolo > > [-- Attachment #2: Type: text/html, Size: 3092 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Qemu-devel][PATCH] x86/cpu: Use max host physical address if -cpu max option is applied 2021-01-13 9:04 [Qemu-devel][PATCH] x86/cpu: Use max host physical address if -cpu max option is applied Yang Weijiang 2021-01-13 10:06 ` Paolo Bonzini @ 2021-01-24 21:08 ` Nathan Chancellor 2021-01-25 5:41 ` Yang Weijiang 1 sibling, 1 reply; 9+ messages in thread From: Nathan Chancellor @ 2021-01-24 21:08 UTC (permalink / raw) To: Yang Weijiang; +Cc: pbonzini, qemu-devel, seanjc On Wed, Jan 13, 2021 at 05:04:30PM +0800, Yang Weijiang wrote: > QEMU option -cpu max(max_features) means "Enables all features supported by > the accelerator in the current host", this looks true for all the features > except guest max physical address width, so add this patch to enable it. > > Signed-off-by: Yang Weijiang <weijiang.yang@intel.com> > --- > target/i386/cpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/i386/cpu.c b/target/i386/cpu.c > index 35459a38bb..b5943406f7 100644 > --- a/target/i386/cpu.c > +++ b/target/i386/cpu.c > @@ -6673,7 +6673,7 @@ static void x86_cpu_realizefn(DeviceState *dev, Error **errp) > warned = true; > } > > - if (cpu->host_phys_bits) { > + if (cpu->host_phys_bits || cpu->max_features) { > /* The user asked for us to use the host physical bits */ > cpu->phys_bits = host_phys_bits; > if (cpu->host_phys_bits_limit && > -- > 2.17.2 > > Hi, This patch as commit 5a140b255d ("x86/cpu: Use max host physical address if -cpu max option is applied") prevents me from using '-cpu host' while booting an i386_defconfig kernel. $ qemu-system-i386 \ -append console=ttyS0 \ -cpu host \ -display none \ -enable-kvm \ -initrd rootfs.cpio \ -kernel bzImage \ -serial mon:stdio qemu-system-i386: phys-bits should be between 32 and 36 (but is 48) Am I expected to pass "-cpu host,host-phys-bits=false" now or did this do something unexpected? Cheers, Nathan ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Qemu-devel][PATCH] x86/cpu: Use max host physical address if -cpu max option is applied 2021-01-24 21:08 ` Nathan Chancellor @ 2021-01-25 5:41 ` Yang Weijiang 2021-01-25 7:10 ` Nathan Chancellor 0 siblings, 1 reply; 9+ messages in thread From: Yang Weijiang @ 2021-01-25 5:41 UTC (permalink / raw) To: Nathan Chancellor; +Cc: Yang Weijiang, seanjc, qemu-devel, pbonzini On Sun, Jan 24, 2021 at 02:08:29PM -0700, Nathan Chancellor wrote: > On Wed, Jan 13, 2021 at 05:04:30PM +0800, Yang Weijiang wrote: > > QEMU option -cpu max(max_features) means "Enables all features supported by > > the accelerator in the current host", this looks true for all the features > > except guest max physical address width, so add this patch to enable it. > > > > Signed-off-by: Yang Weijiang <weijiang.yang@intel.com> > > --- > > target/i386/cpu.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/target/i386/cpu.c b/target/i386/cpu.c > > index 35459a38bb..b5943406f7 100644 > > --- a/target/i386/cpu.c > > +++ b/target/i386/cpu.c > > @@ -6673,7 +6673,7 @@ static void x86_cpu_realizefn(DeviceState *dev, Error **errp) > > warned = true; > > } > > > > - if (cpu->host_phys_bits) { > > + if (cpu->host_phys_bits || cpu->max_features) { > > /* The user asked for us to use the host physical bits */ > > cpu->phys_bits = host_phys_bits; > > if (cpu->host_phys_bits_limit && > > -- > > 2.17.2 > > > > > > Hi, > > This patch as commit 5a140b255d ("x86/cpu: Use max host physical address > if -cpu max option is applied") prevents me from using '-cpu host' while > booting an i386_defconfig kernel. > > $ qemu-system-i386 \ > -append console=ttyS0 \ > -cpu host \ > -display none \ > -enable-kvm \ > -initrd rootfs.cpio \ > -kernel bzImage \ > -serial mon:stdio > qemu-system-i386: phys-bits should be between 32 and 36 (but is 48) > > Am I expected to pass "-cpu host,host-phys-bits=false" now or did this > do something unexpected? > Hi, Nathan, Could you try Paolo's latest patch? [PULL 03/31] x86/cpu: Use max host physical address if -cpu max option is applied diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 35459a38bb..72a79e6019 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -4319,6 +4319,7 @@ static void max_x86_cpu_initfn(Object *obj) if (lmce_supported()) { object_property_set_bool(OBJECT(cpu), "lmce", true, &error_abort); } + object_property_set_bool(OBJECT(cpu), "host-phys-bits", true, + &error_abort); } else { object_property_set_str(OBJECT(cpu), "vendor", CPUID_VENDOR_AMD, &error_abort); > Cheers, > Nathan ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Qemu-devel][PATCH] x86/cpu: Use max host physical address if -cpu max option is applied 2021-01-25 5:41 ` Yang Weijiang @ 2021-01-25 7:10 ` Nathan Chancellor 2021-01-25 10:42 ` Paolo Bonzini 0 siblings, 1 reply; 9+ messages in thread From: Nathan Chancellor @ 2021-01-25 7:10 UTC (permalink / raw) To: Yang Weijiang; +Cc: pbonzini, qemu-devel, seanjc On Mon, Jan 25, 2021 at 01:41:50PM +0800, Yang Weijiang wrote: > On Sun, Jan 24, 2021 at 02:08:29PM -0700, Nathan Chancellor wrote: > > On Wed, Jan 13, 2021 at 05:04:30PM +0800, Yang Weijiang wrote: > > > QEMU option -cpu max(max_features) means "Enables all features supported by > > > the accelerator in the current host", this looks true for all the features > > > except guest max physical address width, so add this patch to enable it. > > > > > > Signed-off-by: Yang Weijiang <weijiang.yang@intel.com> > > > --- > > > target/i386/cpu.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/target/i386/cpu.c b/target/i386/cpu.c > > > index 35459a38bb..b5943406f7 100644 > > > --- a/target/i386/cpu.c > > > +++ b/target/i386/cpu.c > > > @@ -6673,7 +6673,7 @@ static void x86_cpu_realizefn(DeviceState *dev, Error **errp) > > > warned = true; > > > } > > > > > > - if (cpu->host_phys_bits) { > > > + if (cpu->host_phys_bits || cpu->max_features) { > > > /* The user asked for us to use the host physical bits */ > > > cpu->phys_bits = host_phys_bits; > > > if (cpu->host_phys_bits_limit && > > > -- > > > 2.17.2 > > > > > > > > > > Hi, > > > > This patch as commit 5a140b255d ("x86/cpu: Use max host physical address > > if -cpu max option is applied") prevents me from using '-cpu host' while > > booting an i386_defconfig kernel. > > > > $ qemu-system-i386 \ > > -append console=ttyS0 \ > > -cpu host \ > > -display none \ > > -enable-kvm \ > > -initrd rootfs.cpio \ > > -kernel bzImage \ > > -serial mon:stdio > > qemu-system-i386: phys-bits should be between 32 and 36 (but is 48) > > > > Am I expected to pass "-cpu host,host-phys-bits=false" now or did this > > do something unexpected? > > > Hi, Nathan, > Could you try Paolo's latest patch? > > [PULL 03/31] x86/cpu: Use max host physical address if -cpu max option is applied Hi Yang, That is the version of the patch I tried, which has been pulled into the master branch. Cheers, Nathan ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Qemu-devel][PATCH] x86/cpu: Use max host physical address if -cpu max option is applied 2021-01-25 7:10 ` Nathan Chancellor @ 2021-01-25 10:42 ` Paolo Bonzini 2021-01-25 18:19 ` Nathan Chancellor 0 siblings, 1 reply; 9+ messages in thread From: Paolo Bonzini @ 2021-01-25 10:42 UTC (permalink / raw) To: Nathan Chancellor, Yang Weijiang; +Cc: seanjc, qemu-devel On 25/01/21 08:10, Nathan Chancellor wrote: >>> This patch as commit 5a140b255d ("x86/cpu: Use max host physical address >>> if -cpu max option is applied") prevents me from using '-cpu host' while >>> booting an i386_defconfig kernel. >>> >>> $ qemu-system-i386 \ >>> -append console=ttyS0 \ >>> -cpu host \ >>> -display none \ >>> -enable-kvm \ >>> -initrd rootfs.cpio \ >>> -kernel bzImage \ >>> -serial mon:stdio >>> qemu-system-i386: phys-bits should be between 32 and 36 (but is 48) >>> >>> Am I expected to pass "-cpu host,host-phys-bits=false" now or did this >>> do something unexpected? Yes, it's setting the LM bit for a 32-bit guest. Does this work for you? diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 72a79e6019..70df57337f 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -5081,6 +5081,11 @@ static uint64_t x86_cpu_get_supported_feature_word(FeatureWord w, } else { return ~0; } +#ifdef TARGET_I386 + if (wi->cpuid.eax = 0x80000001) { + r &= ~CPUID_EXT2_LM; + } +#endif if (migratable_only) { r &= x86_cpu_get_migratable_flags(w); } Paolo >> Hi, Nathan, >> Could you try Paolo's latest patch? >> >> [PULL 03/31] x86/cpu: Use max host physical address if -cpu max option is applied > > Hi Yang, > > That is the version of the patch I tried, which has been pulled into the > master branch. > > Cheers, > Nathan > ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [Qemu-devel][PATCH] x86/cpu: Use max host physical address if -cpu max option is applied 2021-01-25 10:42 ` Paolo Bonzini @ 2021-01-25 18:19 ` Nathan Chancellor 0 siblings, 0 replies; 9+ messages in thread From: Nathan Chancellor @ 2021-01-25 18:19 UTC (permalink / raw) To: Paolo Bonzini; +Cc: Yang Weijiang, qemu-devel, seanjc On Mon, Jan 25, 2021 at 11:42:43AM +0100, Paolo Bonzini wrote: > On 25/01/21 08:10, Nathan Chancellor wrote: > > > > This patch as commit 5a140b255d ("x86/cpu: Use max host physical address > > > > if -cpu max option is applied") prevents me from using '-cpu host' while > > > > booting an i386_defconfig kernel. > > > > > > > > $ qemu-system-i386 \ > > > > -append console=ttyS0 \ > > > > -cpu host \ > > > > -display none \ > > > > -enable-kvm \ > > > > -initrd rootfs.cpio \ > > > > -kernel bzImage \ > > > > -serial mon:stdio > > > > qemu-system-i386: phys-bits should be between 32 and 36 (but is 48) > > > > > > > > Am I expected to pass "-cpu host,host-phys-bits=false" now or did this > > > > do something unexpected? > > Yes, it's setting the LM bit for a 32-bit guest. > > Does this work for you? Yes, it does! Tested-by: Nathan Chancellor <natechancellor@gmail.com> > diff --git a/target/i386/cpu.c b/target/i386/cpu.c > index 72a79e6019..70df57337f 100644 > --- a/target/i386/cpu.c > +++ b/target/i386/cpu.c > @@ -5081,6 +5081,11 @@ static uint64_t > x86_cpu_get_supported_feature_word(FeatureWord w, > } else { > return ~0; > } > +#ifdef TARGET_I386 > + if (wi->cpuid.eax = 0x80000001) { This should be a '==': ../target/i386/cpu.c: In function ‘x86_cpu_get_supported_feature_word’: ../target/i386/cpu.c:5085:9: error: suggest parentheses around assignment used as truth value [-Werror=parentheses] 5085 | if (wi->cpuid.eax = 0x80000001) { | ^~ cc1: all warnings being treated as errors > + r &= ~CPUID_EXT2_LM; > + } > +#endif > if (migratable_only) { > r &= x86_cpu_get_migratable_flags(w); > } > > > Paolo > > > > Hi, Nathan, > > > Could you try Paolo's latest patch? > > > > > > [PULL 03/31] x86/cpu: Use max host physical address if -cpu max option is applied > > > > Hi Yang, > > > > That is the version of the patch I tried, which has been pulled into the > > master branch. > > > > Cheers, > > Nathan > > V> ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-01-25 18:21 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2021-01-13 9:04 [Qemu-devel][PATCH] x86/cpu: Use max host physical address if -cpu max option is applied Yang Weijiang 2021-01-13 10:06 ` Paolo Bonzini 2021-01-13 15:04 ` Yang Weijiang 2021-01-13 15:41 ` Paolo Bonzini 2021-01-24 21:08 ` Nathan Chancellor 2021-01-25 5:41 ` Yang Weijiang 2021-01-25 7:10 ` Nathan Chancellor 2021-01-25 10:42 ` Paolo Bonzini 2021-01-25 18:19 ` Nathan Chancellor
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).