From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9779EC433DB for ; Mon, 25 Jan 2021 12:17:34 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E2B79224F9 for ; Mon, 25 Jan 2021 12:17:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E2B79224F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59638 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l40oG-00088x-RB for qemu-devel@archiver.kernel.org; Mon, 25 Jan 2021 07:17:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51226) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l40mX-0007Tg-Ly for qemu-devel@nongnu.org; Mon, 25 Jan 2021 07:15:47 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:37417) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l40mW-0004Yi-Ca for qemu-devel@nongnu.org; Mon, 25 Jan 2021 07:15:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611576943; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xwzncZVTgdKV1aE7Eyg5Hs6Y+iDhkUUuLiouftDMkkc=; b=DtxhaVVk5yfo2RGfi7Ek1ek22C+BPCYYqP1ICqp+IF/4ZRDhhrCk5DM4QMQVjhgrbnAap1 zKxzCQ3+sDAFZCmbZVq5jMLQ6UoVFzJ4uwbooVlZFUA0gMmLrN18kXvFwacWocwYwc+Rfs oPAdKYggdhZMUSV9Kr0Udm8xFJNwQmc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-15-0VfbGpmfO6a65D9_DI3AkQ-1; Mon, 25 Jan 2021 07:15:40 -0500 X-MC-Unique: 0VfbGpmfO6a65D9_DI3AkQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E150D107ACE8; Mon, 25 Jan 2021 12:15:38 +0000 (UTC) Received: from merkur.fritz.box (ovpn-115-150.ams2.redhat.com [10.36.115.150]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1F6905D6AB; Mon, 25 Jan 2021 12:15:30 +0000 (UTC) Date: Mon, 25 Jan 2021 13:15:29 +0100 From: Kevin Wolf To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Subject: Re: [PATCH v2 05/12] meson: Restrict block subsystem processing Message-ID: <20210125121529.GB7107@merkur.fritz.box> References: <20210122204441.2145197-1-philmd@redhat.com> <20210122204441.2145197-6-philmd@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210122204441.2145197-6-philmd@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kwolf@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.255, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Eduardo Habkost , qemu-block@nongnu.org, Michael Roth , qemu-devel@nongnu.org, Markus Armbruster , Claudio Fontana , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 22.01.2021 um 21:44 hat Philippe Mathieu-Daudé geschrieben: > Avoid generating module_block.h and block-gen.c if we are > not going to use them. > > Signed-off-by: Philippe Mathieu-Daudé > --- > Cc: qemu-block@nongnu.org > --- > meson.build | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/meson.build b/meson.build > index 61cbb89cd44..181f8795f5a 100644 > --- a/meson.build > +++ b/meson.build > @@ -1829,7 +1829,9 @@ > > subdir('nbd') > subdir('scsi') > -subdir('block') > +if have_block > + subdir('block') > +endif > > blockdev_ss.add(files( > 'blockdev.c', It feels odd to have a random have_block check in the middle of a whole bunch of lines that all deal with block layer functionality, especially when unconditional ones depend on the conditional one. (nbd, scsi and blockdev.c present in the context here certainly all can't work without block) So should this if block become a bit longer and include all block layer related things nearby? If not, at least a comment explaining why we're doing this would be nice. Kevin