From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69A5CC433E0 for ; Mon, 25 Jan 2021 16:56:07 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F11C82223E for ; Mon, 25 Jan 2021 16:56:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F11C82223E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48956 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l459p-0007wI-Oa for qemu-devel@archiver.kernel.org; Mon, 25 Jan 2021 11:56:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50694) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l454G-0005o7-8g for qemu-devel@nongnu.org; Mon, 25 Jan 2021 11:50:23 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:32415) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l454D-0003NN-Tz for qemu-devel@nongnu.org; Mon, 25 Jan 2021 11:50:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611593416; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZmcZKYJmCLD0ZJHiVSdA1RE7z3tCdaClhT+Z9VzVBR8=; b=gblqe8HVSK7oBguIw7GPYpxdJuVogJ52IvRL7ihOmxo/RdacrpJQP/ozEzbCFLE9k9LCt5 ECWVojlbWSx6GactPVA1sB+nXUNbkeXuDczH7Jf9d38IPU/d3lqikFRTMXQYIygrzeFW3o GrW67aIHsqsS84hf8Qb4sJRjkpDV4ks= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-491-pM8e_944OaGoGkCjTIT6yQ-1; Mon, 25 Jan 2021 11:50:14 -0500 X-MC-Unique: pM8e_944OaGoGkCjTIT6yQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E0CD110054FF; Mon, 25 Jan 2021 16:50:12 +0000 (UTC) Received: from merkur.fritz.box (ovpn-115-150.ams2.redhat.com [10.36.115.150]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6D96619C47; Mon, 25 Jan 2021 16:50:11 +0000 (UTC) Date: Mon, 25 Jan 2021 17:50:09 +0100 From: Kevin Wolf To: Vladimir Sementsov-Ogievskiy Subject: Re: [PATCH v8 0/5] Rework iotests/check Message-ID: <20210125165009.GF7107@merkur.fritz.box> References: <20210123210428.27220-1-vsementsov@virtuozzo.com> <20210125160820.GD7107@merkur.fritz.box> <65a24006-32af-1ce2-fafd-e1ea152e4412@virtuozzo.com> MIME-Version: 1.0 In-Reply-To: <65a24006-32af-1ce2-fafd-e1ea152e4412@virtuozzo.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kwolf@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.255, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-block@nongnu.org, jsnow@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com, den@openvz.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 25.01.2021 um 17:36 hat Vladimir Sementsov-Ogievskiy geschrieben: > 25.01.2021 19:08, Kevin Wolf wrote: > > Am 23.01.2021 um 22:04 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > v8: > > > > > > about linters: > > > > > > I didn't modify 297, as Max already staged 297 modifications to test all files. > > > > > > Also, now I have two complains: > > > +************* Module testenv > > > +testenv.py:158:4: R0915: Too many statements (53/50) (too-many-statements) > > > +************* Module testrunner > > > +testrunner.py:222:4: R0911: Too many return statements (7/6) (too-many-return-statements) > > > Success: no issues found in 5 source files > > > > > > And I feel, I'm tired to refactor it now.. Probably we can ignore them in 297. Probably I can > > > do some refactoring as a follow-up. > > > > I don't think these warning are very helpful, I would agree with > > disabling them (even globally). > > > > When testing this with the other image formats, I found some problems. > > > > 1. The first one probably means that we have changed the order of some > > checks: 150 and 178 have reference outputs for raw and qcow2, but no > > other formats. > > > > Previously, the _supported_fmt line in the test would just skip the test: > > > > $ build/check -vhdx 150 178 > > 150 not run [16:45:46] [16:45:46] not suitable for this image format: vhdx > > 178 not run [16:45:46] [16:45:46] not suitable for this image format: vhdx > > > > Now we seem to test first if a reference output exists and fail: > > > > 150 fail [16:49:18] [16:49:18] ... No qualified output (expected /home/kwolf/source/qemu/tests/qemu-iotests/150.out) > > 178 fail [16:49:18] [16:49:18] ... No qualified output (expected /home/kwolf/source/qemu/tests/qemu-iotests/178.out) > > > Hmm. Still, I do think that new order is better: no reason to run the > test, when we don't have corresponding .out file. So, may be just > change it into "not run", with same "No qualified output (expected > ..)" message, what do you think? Works for me. (There would actually be a reason to run the test, namely for creating the reference output when you add the test. But this didn't leave a .bad file behind before either, and just doing 'touch 123.out' first is easy enough anyway.) Kevin