From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3403C433E9 for ; Mon, 25 Jan 2021 17:10:53 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5BD4E22AAC for ; Mon, 25 Jan 2021 17:10:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5BD4E22AAC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49722 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l45O8-0003wa-12 for qemu-devel@archiver.kernel.org; Mon, 25 Jan 2021 12:10:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55884) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l45LA-0001Wf-RJ for qemu-devel@nongnu.org; Mon, 25 Jan 2021 12:07:48 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:60919) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l45L9-0006bj-3U for qemu-devel@nongnu.org; Mon, 25 Jan 2021 12:07:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611594465; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ElAbcfIr2zC8Tp7vArB4vjCK2w+alQOEFUH3+2B1SZE=; b=hEOS3wkps9QBaU91lFmqgBQwziCQKc6Up1Oks+27e9f7pFndK5vsCnaA/Y+Ik9u2EOf6UH 7gSNjwwNdX7pqwnTBryckB16NqG+k16oySuH761VZ9wbkyPX+40O4QTEy5m06FwtKQYX/e jJT0PkO4ue+E/pIENozr/WAKdt9gsXE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-217-moHOOpvyPv-8MqOqHkj0bw-1; Mon, 25 Jan 2021 12:07:44 -0500 X-MC-Unique: moHOOpvyPv-8MqOqHkj0bw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 03D831922021; Mon, 25 Jan 2021 17:07:43 +0000 (UTC) Received: from merkur.fritz.box (ovpn-115-150.ams2.redhat.com [10.36.115.150]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 23E4271CBF; Mon, 25 Jan 2021 17:07:37 +0000 (UTC) Date: Mon, 25 Jan 2021 18:07:36 +0100 From: Kevin Wolf To: Markus Armbruster Subject: Re: [PATCH 2/3] fdc: Inline fdctrl_connect_drives() into fdctrl_realize_common() Message-ID: <20210125170736.GG7107@merkur.fritz.box> References: <20210125162402.1807394-1-armbru@redhat.com> <20210125162402.1807394-3-armbru@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210125162402.1807394-3-armbru@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kwolf@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.255, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: libvir-list@redhat.com, jsnow@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org, mreitz@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 25.01.2021 um 17:24 hat Markus Armbruster geschrieben: > The previous commit rendered the name fdctrl_realize_common() somewhat > misleading. Get rid of it by inlining the (now pretty simple) > function into its only caller. > > Signed-off-by: Markus Armbruster > --- > hw/block/fdc.c | 23 ++++++++--------------- > 1 file changed, 8 insertions(+), 15 deletions(-) > > diff --git a/hw/block/fdc.c b/hw/block/fdc.c > index c6c9393e29..7fc547c62d 100644 > --- a/hw/block/fdc.c > +++ b/hw/block/fdc.c > @@ -2521,20 +2521,6 @@ void isa_fdc_init_drives(ISADevice *fdc, DriveInfo **fds) > fdctrl_init_drives(&ISA_FDC(fdc)->state.bus, fds); > } > > -static void fdctrl_connect_drives(FDCtrl *fdctrl, DeviceState *fdc_dev, > - Error **errp) The commit message talks about fdctrl_realize_common(). I assume it really means fdctrl_connect_drives() then? Kevin