From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C758BC433DB for ; Mon, 25 Jan 2021 19:18:15 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 100E12067B for ; Mon, 25 Jan 2021 19:18:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 100E12067B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33858 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l47NN-0000iC-Rw for qemu-devel@archiver.kernel.org; Mon, 25 Jan 2021 14:18:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34050) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l474e-0006xW-F5 for qemu-devel@nongnu.org; Mon, 25 Jan 2021 13:58:52 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:27318) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l474b-0006I3-KG for qemu-devel@nongnu.org; Mon, 25 Jan 2021 13:58:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611601127; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zHac+loGt9pvJ3ucyE/+rVawDMRHJawcv3rmbk+zyIM=; b=KSAEMA5R62EEp6W+Y8EW3kFRzivClLWmMB0WHP+q9cAyfcmVgpwqgnGlz5Gj37K3BMC03Q QbY+TVDzQVmXxx35TY0DE+5PQaSwMjMwPbYNZa4/3mYjRIlSMFoCGQlCUkqJ/Ld4v3GIUk NVSc9F7QY1S+oiaDmCu9I0UzZ60yn6s= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-545-udNWGQvbMD-sYO2gYbaV8A-1; Mon, 25 Jan 2021 13:58:46 -0500 X-MC-Unique: udNWGQvbMD-sYO2gYbaV8A-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9C5F58799E0; Mon, 25 Jan 2021 18:58:44 +0000 (UTC) Received: from work-vm (ovpn-114-3.ams2.redhat.com [10.36.114.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0C2AF100AE46; Mon, 25 Jan 2021 18:58:38 +0000 (UTC) Date: Mon, 25 Jan 2021 18:58:36 +0000 From: "Dr. David Alan Gilbert" To: Tom Lendacky Subject: Re: [PATCH v5 2/6] sev/i386: Require in-kernel irqchip support for SEV-ES guests Message-ID: <20210125185836.GP2925@work-vm> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Received-SPF: pass client-ip=216.205.24.124; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.255, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Brijesh Singh , Eduardo Habkost , kvm@vger.kernel.org, "Michael S. Tsirkin" , Connor Kuehl , Sean Christopherson , Marcelo Tosatti , Richard Henderson , qemu-devel@nongnu.org, Paolo Bonzini , Jiri Slaby , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Tom Lendacky (thomas.lendacky@amd.com) wrote: > From: Tom Lendacky > > In prep for AP booting, require the use of in-kernel irqchip support. This > lessens the Qemu support burden required to boot APs. > > Cc: Paolo Bonzini > Cc: Richard Henderson > Cc: Eduardo Habkost > Signed-off-by: Tom Lendacky Reviewed-by: Dr. David Alan Gilbert (I'm failing to fidn a definition of irqchip_required vs allowed) > --- > target/i386/sev.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/target/i386/sev.c b/target/i386/sev.c > index fce2128c07..ddec7ebaa7 100644 > --- a/target/i386/sev.c > +++ b/target/i386/sev.c > @@ -776,6 +776,12 @@ sev_guest_init(const char *id) > sev->api_minor = status.api_minor; > > if (sev_es_enabled()) { > + if (!kvm_kernel_irqchip_allowed()) { > + error_report("%s: SEV-ES guests require in-kernel irqchip support", > + __func__); > + goto err; > + } > + > if (!(status.flags & SEV_STATUS_FLAGS_CONFIG_ES)) { > error_report("%s: guest policy requires SEV-ES, but " > "host SEV-ES support unavailable", > -- > 2.30.0 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK