From: "Michael S. Tsirkin" <mst@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: marcandre.lureau@redhat.com, qemu-devel@nongnu.org, kraxel@redhat.com
Subject: Re: [PATCH 2/2] vhost_user_gpu: Drop dead check for g_malloc() failure
Date: Tue, 26 Jan 2021 09:10:41 -0500 [thread overview]
Message-ID: <20210126091022-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20210126124240.2081959-3-armbru@redhat.com>
On Tue, Jan 26, 2021 at 01:42:40PM +0100, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> hw/display/vhost-user-gpu.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/display/vhost-user-gpu.c b/hw/display/vhost-user-gpu.c
> index 51f1747c4a..db042c7c5e 100644
> --- a/hw/display/vhost-user-gpu.c
> +++ b/hw/display/vhost-user-gpu.c
> @@ -332,7 +332,6 @@ vhost_user_gpu_chr_read(void *opaque)
> }
>
> msg = g_malloc(VHOST_USER_GPU_HDR_SIZE + size);
> - g_return_if_fail(msg != NULL);
>
> r = qemu_chr_fe_read_all(&g->vhost_chr,
> (uint8_t *)&msg->payload, size);
> --
> 2.26.2
next prev parent reply other threads:[~2021-01-26 14:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 12:42 [PATCH 0/2] g_return_if_fail(), g_return_val_if_fail() misuse Markus Armbruster
2021-01-26 12:42 ` [PATCH 1/2] backends/dbus-vmstate: Fix short read error handling Markus Armbruster
2021-01-26 13:09 ` Marc-André Lureau
2021-03-09 20:41 ` Laurent Vivier
2021-01-26 12:42 ` [PATCH 2/2] vhost_user_gpu: Drop dead check for g_malloc() failure Markus Armbruster
2021-01-26 13:09 ` Marc-André Lureau
2021-01-26 14:10 ` Michael S. Tsirkin [this message]
2021-03-09 20:42 ` Laurent Vivier
2021-02-19 9:16 ` [PATCH 0/2] g_return_if_fail(), g_return_val_if_fail() misuse Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210126091022-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).