From: Peter Lieven <pl@kamp.de>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, Peter Lieven <pl@kamp.de>,
qemu-devel@nongnu.org, ct@flyingcircus.io, pbonzini@redhat.com,
mreitz@redhat.com, dillaman@redhat.com
Subject: [PATCH V2 7/7] block/rbd: drop qemu_rbd_refresh_limits
Date: Tue, 26 Jan 2021 12:25:40 +0100 [thread overview]
Message-ID: <20210126112540.11880-8-pl@kamp.de> (raw)
In-Reply-To: <20210126112540.11880-1-pl@kamp.de>
librbd supports 1 byte alignment for all aio operations.
Currently, there is no API call to query limits from the ceph backend.
So drop the bdrv_refresh_limits completely until there is such an API call.
Signed-off-by: Peter Lieven <pl@kamp.de>
---
block/rbd.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/block/rbd.c b/block/rbd.c
index 35dc1dc90e..5f96fbf3d1 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -219,14 +219,6 @@ done:
return;
}
-
-static void qemu_rbd_refresh_limits(BlockDriverState *bs, Error **errp)
-{
- /* XXX Does RBD support AIO on less than 512-byte alignment? */
- bs->bl.request_alignment = 512;
-}
-
-
static int qemu_rbd_set_auth(rados_t cluster, BlockdevOptionsRbd *opts,
Error **errp)
{
@@ -1124,7 +1116,6 @@ static BlockDriver bdrv_rbd = {
.format_name = "rbd",
.instance_size = sizeof(BDRVRBDState),
.bdrv_parse_filename = qemu_rbd_parse_filename,
- .bdrv_refresh_limits = qemu_rbd_refresh_limits,
.bdrv_file_open = qemu_rbd_open,
.bdrv_close = qemu_rbd_close,
.bdrv_reopen_prepare = qemu_rbd_reopen_prepare,
--
2.17.1
prev parent reply other threads:[~2021-01-26 11:35 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 11:25 [PATCH V2 0/7] block/rbd: migrate to coroutines and add write zeroes support Peter Lieven
2021-01-26 11:25 ` [PATCH V2 1/7] block/rbd: bump librbd requirement to luminous release Peter Lieven
2021-02-15 10:11 ` Kevin Wolf
2021-02-15 10:19 ` Daniel P. Berrangé
2021-02-15 11:34 ` Peter Lieven
2021-02-15 12:17 ` Kevin Wolf
2021-02-15 10:24 ` Daniel P. Berrangé
2021-02-15 11:32 ` Peter Lieven
2021-02-15 11:41 ` Daniel P. Berrangé
2021-02-15 11:45 ` Peter Lieven
2021-02-15 11:51 ` Daniel P. Berrangé
2021-02-15 11:55 ` Peter Lieven
2021-02-15 12:02 ` Daniel P. Berrangé
2021-02-15 12:13 ` Kevin Wolf
2021-02-15 13:28 ` Peter Lieven
2021-02-22 21:48 ` Jason Dillaman
2021-01-26 11:25 ` [PATCH V2 2/7] block/rbd: store object_size in BDRVRBDState Peter Lieven
2021-01-26 11:25 ` [PATCH V2 3/7] block/rbd: update s->image_size in qemu_rbd_getlength Peter Lieven
2021-01-26 11:25 ` [PATCH V2 4/7] block/rbd: add bdrv_attach_aio_context Peter Lieven
2021-02-15 10:20 ` Kevin Wolf
2021-02-15 11:48 ` Peter Lieven
2021-01-26 11:25 ` [PATCH V2 5/7] block/rbd: migrate from aio to coroutines Peter Lieven
2021-01-26 11:25 ` [PATCH V2 6/7] block/rbd: add write zeroes support Peter Lieven
2021-01-26 11:25 ` Peter Lieven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210126112540.11880-8-pl@kamp.de \
--to=pl@kamp.de \
--cc=ct@flyingcircus.io \
--cc=dillaman@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).