From: Kevin Wolf <kwolf@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [PATCH] iotests/178: Pass value to invalid option
Date: Tue, 26 Jan 2021 15:01:45 +0100 [thread overview]
Message-ID: <20210126140145.GG4385@merkur.fritz.box> (raw)
In-Reply-To: <20210126123834.115915-1-mreitz@redhat.com>
Am 26.01.2021 um 13:38 hat Max Reitz geschrieben:
> ccd3b3b8112 has deprecated short-hand boolean options (i.e., options
> with values). All options without values are interpreted as boolean
> options, so this includes the invalid option "snapshot.foo" used in
> iotest 178.
>
> So after ccd3b3b8112, 178 fails with:
>
> +qemu-img: warning: short-form boolean option 'snapshot.foo' deprecated
> +Please use snapshot.foo=on instead
>
> Suppress that deprecation warning by passing some value to it (it does
> not matter which, because the option is invalid anyway).
>
> Fixes: ccd3b3b8112b670fdccf8a392b8419b173ffccb4
> ("qemu-option: warn for short-form boolean options")
> Signed-off-by: Max Reitz <mreitz@redhat.com>
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2021-01-26 14:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 12:38 [PATCH] iotests/178: Pass value to invalid option Max Reitz
2021-01-26 14:01 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210126140145.GG4385@merkur.fritz.box \
--to=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).