From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02967C433DB for ; Tue, 26 Jan 2021 14:03:13 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 85BE52255F for ; Tue, 26 Jan 2021 14:03:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85BE52255F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47932 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l4Ow3-0001IN-JF for qemu-devel@archiver.kernel.org; Tue, 26 Jan 2021 09:03:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42822) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l4Our-0000Ol-Ot for qemu-devel@nongnu.org; Tue, 26 Jan 2021 09:01:57 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:53832) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l4Oup-0008Gt-Cs for qemu-devel@nongnu.org; Tue, 26 Jan 2021 09:01:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611669714; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GHmCzCknIKKBE/oBKhXGvfM8yTxTnyomy6vugs0xs/Y=; b=WTqfimG6cslAjcVusrG7uYysOefZjMgI66vUWYz1aiZJ/H5QZ3sEeA4h3KvR5zfoeZ/HWA g9qE9VMjbwuvrOzwxlen4qaKUsPM097+CYDhocSVlTWD9eBWqCRy/NYNCI3fe6VtnMx3Dv 5AuDQXsa44kFcujck+E9Uij2+rOpy3k= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-435-WCtZGi_iO4OvUEe1vx-S-g-1; Tue, 26 Jan 2021 09:01:51 -0500 X-MC-Unique: WCtZGi_iO4OvUEe1vx-S-g-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9AED5801817; Tue, 26 Jan 2021 14:01:50 +0000 (UTC) Received: from merkur.fritz.box (ovpn-114-202.ams2.redhat.com [10.36.114.202]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7E84060C96; Tue, 26 Jan 2021 14:01:46 +0000 (UTC) Date: Tue, 26 Jan 2021 15:01:45 +0100 From: Kevin Wolf To: Max Reitz Subject: Re: [PATCH] iotests/178: Pass value to invalid option Message-ID: <20210126140145.GG4385@merkur.fritz.box> References: <20210126123834.115915-1-mreitz@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210126123834.115915-1-mreitz@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kwolf@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.255, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , qemu-devel@nongnu.org, qemu-block@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 26.01.2021 um 13:38 hat Max Reitz geschrieben: > ccd3b3b8112 has deprecated short-hand boolean options (i.e., options > with values). All options without values are interpreted as boolean > options, so this includes the invalid option "snapshot.foo" used in > iotest 178. > > So after ccd3b3b8112, 178 fails with: > > +qemu-img: warning: short-form boolean option 'snapshot.foo' deprecated > +Please use snapshot.foo=on instead > > Suppress that deprecation warning by passing some value to it (it does > not matter which, because the option is invalid anyway). > > Fixes: ccd3b3b8112b670fdccf8a392b8419b173ffccb4 > ("qemu-option: warn for short-form boolean options") > Signed-off-by: Max Reitz Thanks, applied to the block branch. Kevin