From: "Cédric Le Goater" <clg@kaod.org>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: "Cédric Le Goater" <clg@kaod.org>,
qemu-ppc@nongnu.org, "Greg Kurz" <groug@kaod.org>,
qemu-devel@nongnu.org
Subject: [PATCH 4/7] ppc/pnv: Simplify pnv_bmc_create()
Date: Tue, 26 Jan 2021 18:10:56 +0100 [thread overview]
Message-ID: <20210126171059.307867-5-clg@kaod.org> (raw)
In-Reply-To: <20210126171059.307867-1-clg@kaod.org>
and reuse pnv_bmc_set_pnor() to share the setting of the PNOR.
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
hw/ppc/pnv_bmc.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/hw/ppc/pnv_bmc.c b/hw/ppc/pnv_bmc.c
index 67ebb16c4d5f..86d16b493539 100644
--- a/hw/ppc/pnv_bmc.c
+++ b/hw/ppc/pnv_bmc.c
@@ -260,13 +260,8 @@ IPMIBmc *pnv_bmc_create(PnvPnor *pnor)
Object *obj;
obj = object_new(TYPE_IPMI_BMC_SIMULATOR);
- object_ref(OBJECT(pnor));
- object_property_add_const_link(obj, "pnor", OBJECT(pnor));
qdev_realize(DEVICE(obj), NULL, &error_fatal);
-
- /* Install the HIOMAP protocol handlers to access the PNOR */
- ipmi_sim_register_netfn(IPMI_BMC_SIMULATOR(obj), IPMI_NETFN_OEM,
- &hiomap_netfn);
+ pnv_bmc_set_pnor(IPMI_BMC(obj), pnor);
return IPMI_BMC(obj);
}
--
2.26.2
next prev parent reply other threads:[~2021-01-26 17:16 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 17:10 [PATCH 0/7] ppc/pnv: Misc cleanups Cédric Le Goater
2021-01-26 17:10 ` [PATCH 1/7] ppc/pnv: Add trace events for PCI event notification Cédric Le Goater
2021-01-28 0:44 ` David Gibson
2021-01-26 17:10 ` [PATCH 2/7] ppc/xive: Add firmware bit when dumping the ENDs Cédric Le Goater
2021-01-28 0:45 ` David Gibson
2021-01-26 17:10 ` [PATCH 3/7] ppc/pnv: Use skiboot addresses to load kernel and ramfs Cédric Le Goater
2021-01-27 1:27 ` Murilo Opsfelder Araújo
2021-01-27 7:10 ` Cédric Le Goater
2021-01-27 11:57 ` Murilo Opsfelder Araújo
2021-01-28 0:45 ` Joel Stanley
2021-01-28 7:02 ` Cédric Le Goater
2021-01-28 22:36 ` David Gibson
2021-01-29 9:19 ` Cédric Le Goater
2021-01-28 0:46 ` David Gibson
2021-01-26 17:10 ` Cédric Le Goater [this message]
2021-01-28 0:46 ` [PATCH 4/7] ppc/pnv: Simplify pnv_bmc_create() Joel Stanley
2021-01-28 7:46 ` Cédric Le Goater
2021-01-28 12:04 ` Greg Kurz
2021-01-28 22:41 ` David Gibson
2021-01-28 22:40 ` David Gibson
2021-01-29 8:39 ` Cédric Le Goater
2021-01-31 23:14 ` Andrew Jeffery
2021-01-28 0:49 ` David Gibson
2021-01-26 17:10 ` [PATCH 5/7] ppc/pnv: Discard internal BMC initialization when BMC is external Cédric Le Goater
2021-01-28 0:48 ` Joel Stanley
2021-01-28 7:13 ` Cédric Le Goater
2021-01-28 10:08 ` Joel Stanley
2021-01-28 0:50 ` David Gibson
2021-01-26 17:10 ` [PATCH 6/7] ppc/pnv: Remove default disablement of the PNOR contents Cédric Le Goater
2021-01-28 0:52 ` Joel Stanley
2021-01-28 0:52 ` David Gibson
2021-01-26 17:10 ` [PATCH 7/7] ppc/pnv: Introduce a LPC FW memory region attribute to map the PNOR Cédric Le Goater
2021-01-28 0:53 ` Joel Stanley
2021-01-28 0:54 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210126171059.307867-5-clg@kaod.org \
--to=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).