* [PATCH] docs/interop/qmp-spec: Document the request queue limit
@ 2021-01-27 14:47 Markus Armbruster
2021-01-27 19:26 ` John Snow
2021-02-02 14:29 ` Markus Armbruster
0 siblings, 2 replies; 3+ messages in thread
From: Markus Armbruster @ 2021-01-27 14:47 UTC (permalink / raw)
To: qemu-devel; +Cc: libvir-list, jsnow, peterx
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
docs/interop/qmp-spec.txt | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/docs/interop/qmp-spec.txt b/docs/interop/qmp-spec.txt
index cdf5842555..b0e8351d5b 100644
--- a/docs/interop/qmp-spec.txt
+++ b/docs/interop/qmp-spec.txt
@@ -133,9 +133,11 @@ to pass "id" with out-of-band commands. Passing it with all commands
is recommended for clients that accept capability "oob".
If the client sends in-band commands faster than the server can
-execute them, the server will stop reading the requests from the QMP
-channel until the request queue length is reduced to an acceptable
-range.
+execute them, the server will stop reading requests until the request
+queue length is reduced to an acceptable range.
+
+To ensure commands to be executed out-of-band get read and executed,
+the client should have at most eight in-band commands in flight.
Only a few commands support out-of-band execution. The ones that do
have "allow-oob": true in output of query-qmp-schema.
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] docs/interop/qmp-spec: Document the request queue limit
2021-01-27 14:47 [PATCH] docs/interop/qmp-spec: Document the request queue limit Markus Armbruster
@ 2021-01-27 19:26 ` John Snow
2021-02-02 14:29 ` Markus Armbruster
1 sibling, 0 replies; 3+ messages in thread
From: John Snow @ 2021-01-27 19:26 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel; +Cc: libvir-list, peterx
On 1/27/21 9:47 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> docs/interop/qmp-spec.txt | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/docs/interop/qmp-spec.txt b/docs/interop/qmp-spec.txt
> index cdf5842555..b0e8351d5b 100644
> --- a/docs/interop/qmp-spec.txt
> +++ b/docs/interop/qmp-spec.txt
> @@ -133,9 +133,11 @@ to pass "id" with out-of-band commands. Passing it with all commands
> is recommended for clients that accept capability "oob".
>
> If the client sends in-band commands faster than the server can
> -execute them, the server will stop reading the requests from the QMP
> -channel until the request queue length is reduced to an acceptable
> -range.
> +execute them, the server will stop reading requests until the request
> +queue length is reduced to an acceptable range.
> +
> +To ensure commands to be executed out-of-band get read and executed,
> +the client should have at most eight in-band commands in flight.
>
> Only a few commands support out-of-band execution. The ones that do
> have "allow-oob": true in output of query-qmp-schema.
>
Great to know, thank you!
Reviewed-by: John Snow <jsnow@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] docs/interop/qmp-spec: Document the request queue limit
2021-01-27 14:47 [PATCH] docs/interop/qmp-spec: Document the request queue limit Markus Armbruster
2021-01-27 19:26 ` John Snow
@ 2021-02-02 14:29 ` Markus Armbruster
1 sibling, 0 replies; 3+ messages in thread
From: Markus Armbruster @ 2021-02-02 14:29 UTC (permalink / raw)
To: qemu-devel; +Cc: libvir-list, jsnow, peterx
Queued.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-02 14:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-27 14:47 [PATCH] docs/interop/qmp-spec: Document the request queue limit Markus Armbruster
2021-01-27 19:26 ` John Snow
2021-02-02 14:29 ` Markus Armbruster
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).