From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-22.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C8F9C433E9 for ; Thu, 28 Jan 2021 17:20:10 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1C4B964DF9 for ; Thu, 28 Jan 2021 17:20:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C4B964DF9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43700 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l5Axl-0004yx-1s for qemu-devel@archiver.kernel.org; Thu, 28 Jan 2021 12:20:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50356) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l5AuO-0001vl-LM for qemu-devel@nongnu.org; Thu, 28 Jan 2021 12:16:42 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:25447) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l5AuG-00071l-GI for qemu-devel@nongnu.org; Thu, 28 Jan 2021 12:16:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611854189; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=j3ksu9nNe0xZbiAp7HkhuGsueqPRTRtDq/IxY/aOQik=; b=DkSq/RE/tAGThzvWnA2Bdc+TdaHdRdd3lJMrwW7OPySsZ+R6BEg5h6I70iID0sctMtNkA5 udDXXerFBwR6eb29nSJVDf/Xd1LQpRuvWrvQ2x64EyqqUjKlyhhvVjRfIgdW8aWeMLSULs 0ztNY5tKDkF7Q6pzZ6J7J/Mw663EIio= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-324-eGHnrTayOv6NQJy_XgbQ2w-1; Thu, 28 Jan 2021 12:16:27 -0500 X-MC-Unique: eGHnrTayOv6NQJy_XgbQ2w-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AC949835DE5 for ; Thu, 28 Jan 2021 17:16:26 +0000 (UTC) Received: from work-vm (ovpn-115-60.ams2.redhat.com [10.36.115.60]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BE23260C68; Thu, 28 Jan 2021 17:16:21 +0000 (UTC) Date: Thu, 28 Jan 2021 17:16:19 +0000 From: "Dr. David Alan Gilbert" To: Wainer dos Santos Moschetta Subject: Re: [PATCH] migration/qemu-file: Fix maybe uninitialized on qemu_get_buffer_in_place() Message-ID: <20210128171619.GF2951@work-vm> References: <20210128130625.569900-1-wainersm@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210128130625.569900-1-wainersm@redhat.com> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dgilbert@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=63.128.21.124; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.252, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, quintela@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Wainer dos Santos Moschetta (wainersm@redhat.com) wrote: > Fixed error when compiling migration/qemu-file.c with -Werror=maybe-uninitialized > as shown here: > > ../migration/qemu-file.c: In function 'qemu_get_buffer_in_place': > ../migration/qemu-file.c:604:18: error: 'src' may be used uninitialized in this function [-Werror=maybe-uninitialized] > 604 | *buf = src; > | ~~~~~^~~~~ > cc1: all warnings being treated as errors > > Signed-off-by: Wainer dos Santos Moschetta Yes, I think I had a discussion with someone about this recently but can't find it; the compiler is technically correct, but the only time it's unitialised is the case where it's result doesn't matter. Still, to shut the compiler up: Reviewed-by: Dr. David Alan Gilbert > --- > Passed on CI: https://gitlab.com/wainersm/qemu/-/pipelines/247801576 > > migration/qemu-file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/migration/qemu-file.c b/migration/qemu-file.c > index be21518c57..d6e03dbc0e 100644 > --- a/migration/qemu-file.c > +++ b/migration/qemu-file.c > @@ -595,7 +595,7 @@ size_t qemu_get_buffer_in_place(QEMUFile *f, uint8_t **buf, size_t size) > { > if (size < IO_BUF_SIZE) { > size_t res; > - uint8_t *src; > + uint8_t *src = NULL; > > res = qemu_peek_buffer(f, &src, size, 0); > > -- > 2.28.0 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK