From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, "Stefan Weil" <sw@weilnetz.de>,
"Michael Tokarev" <mjt@tls.msk.ru>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Laurent Vivier" <laurent@vivier.eu>
Subject: [PULL 2/4] tcg/tci: Restrict tci_write_reg16() to 64-bit hosts
Date: Fri, 29 Jan 2021 09:32:34 +0100 [thread overview]
Message-ID: <20210129083236.584238-3-laurent@vivier.eu> (raw)
In-Reply-To: <20210129083236.584238-1-laurent@vivier.eu>
From: Philippe Mathieu-Daudé <f4bug@amsat.org>
Restrict tci_write_reg16() to 64-bit hosts to fix on 32-bit ones:
[520/1115] Compiling C object libqemu-arm-linux-user.fa.p/tcg_tci.c.o
FAILED: libqemu-arm-linux-user.fa.p/tcg_tci.c.o
tcg/tci.c:132:1: error: 'tci_write_reg16' defined but not used [-Werror=unused-function]
tci_write_reg16(tcg_target_ulong *regs, TCGReg index, uint16_t value)
^~~~~~~~~~~~~~~
Fixes: 2f160e0f979 ("tci: Add implementation for INDEX_op_ld16u_i64")
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Stefan Weil <sw@weilnetz.de>
Message-Id: <20210123094107.2340222-1-f4bug@amsat.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
tcg/tci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tcg/tci.c b/tcg/tci.c
index 2311aa7d3ab6..3fc82d3c79d7 100644
--- a/tcg/tci.c
+++ b/tcg/tci.c
@@ -128,11 +128,13 @@ static void tci_write_reg8(tcg_target_ulong *regs, TCGReg index, uint8_t value)
tci_write_reg(regs, index, value);
}
+#if TCG_TARGET_REG_BITS == 64
static void
tci_write_reg16(tcg_target_ulong *regs, TCGReg index, uint16_t value)
{
tci_write_reg(regs, index, value);
}
+#endif
static void
tci_write_reg32(tcg_target_ulong *regs, TCGReg index, uint32_t value)
--
2.29.2
next prev parent reply other threads:[~2021-01-29 8:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 8:32 [PULL 0/4] Trivial branch for 6.0 patches Laurent Vivier
2021-01-29 8:32 ` [PULL 1/4] MAINTAINERS: Update 9pfs tree URL Laurent Vivier
2021-01-29 8:32 ` Laurent Vivier [this message]
2021-01-29 8:32 ` [PULL 3/4] net/slirp.c: Fix spelling error in error message Laurent Vivier
2021-01-29 8:32 ` [PULL 4/4] target/rx: Fix compiler errors for build with sanitizers Laurent Vivier
2021-01-29 11:03 ` [PULL 0/4] Trivial branch for 6.0 patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210129083236.584238-3-laurent@vivier.eu \
--to=laurent@vivier.eu \
--cc=f4bug@amsat.org \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).