From: Kevin Wolf <kwolf@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Cc: jsnow@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org,
mreitz@redhat.com
Subject: Re: [PATCH] iotests/297: pylint: ignore too many statements
Date: Fri, 29 Jan 2021 10:50:18 +0100 [thread overview]
Message-ID: <20210129095018.GB10888@merkur.fritz.box> (raw)
In-Reply-To: <7490fbd7-90d0-c1b9-172e-5d507453bf1a@virtuozzo.com>
Am 28.01.2021 um 21:08 hat Vladimir Sementsov-Ogievskiy geschrieben:
> 28.01.2021 23:04, Vladimir Sementsov-Ogievskiy wrote:
> > Ignore two complains, which now lead to 297 failure on testenv.py and
> > testrunner.py.
> >
> > Fixes: 2e5a2f57db481f18fcf70be2a36b1417370b8476
> > Fixes: d74c754c924ca34e90b7c96ce2f5609d82c0e628
> > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> > ---
>
> Forget to note:
>
> I don't add exclusions to pylintrc intentionally, as I think these
> warnings are reasonable, and it's good that vim ALE show them.. Still,
> adding them to pylintrc works too if you prefer.
I would have disabled the warning completely because I don't think
length in lines is a good measure for code quality. But if we think that
these warnings are in fact reasonable, then we should fix them and not
just disable them partially.
It's the same reason why we have -Werror enabled. If you leave warnings
around without any intention to fix them, the useful warnings will drown
in the masses of intentionally ignored ones.
Kevin
next prev parent reply other threads:[~2021-01-29 9:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 20:04 [PATCH] iotests/297: pylint: ignore too many statements Vladimir Sementsov-Ogievskiy
2021-01-28 20:08 ` Vladimir Sementsov-Ogievskiy
2021-01-29 9:50 ` Kevin Wolf [this message]
2021-01-29 17:57 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210129095018.GB10888@merkur.fritz.box \
--to=kwolf@redhat.com \
--cc=jsnow@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).