Re: [PATCH] tests: Replace deprecated ASN1 code

["Daniel P. Berrangé" <berrange@redhat.com>]

On Fri, Jan 29, 2021 at 01:18:43PM +0100, Stefan Weil wrote:
> Am 29.01.21 um 12:47 schrieb Daniel P. Berrangé:
> 
> > This is really odd.
> > I've got the 4.16.0 tar.gz for libtasn1 and it does not contain any
> > such _Pragma / deprecation warnings.
> > 
> > The libtasn1  git repo *does* contain these pragmas, but only in the
> > dev tree for the unreleased 4.17.0 version.
> > 
> > The homebrew-core.git repo recipe for libtasn1 claims to be using
> > 4.16.0 release
> > 
> >    https://github.com/Homebrew/homebrew-core/blob/master/Formula/libtasn1.rb
> > 
> > and those tarballs match what i have.
> > 
> > None the less it looks like your 4.16.0 installed version is in fact
> > a  git snapshot. Damned if I understand what homebrew is doing.
> > 
> > None the less, given that these deprecations are in libtasn1 git upstream,
> > we're going to have to deal with them.
> > 
> > 
> > Regards,
> > Daniel
> 
> 
> Mea culpa.
> 
> While examining the problem with some tests on new Macs which were reported
> by Peter, I used a local build of libtasn1 with debug information. I also
> tried git master to see whether the problem was fixed there, so my current
> header files were indeed newer than the official 4.16.0 ones. That explains
> why I was the first one to see those error messages.

No problem, I'm queuing your patch anyway, with an expanded commit
msg to say that these deprecations will be in the forthcoming 4.17.0
release.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|