From: Kevin Wolf <kwolf@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: vsementsov@virtuozzo.com, QEMU Developers <qemu-devel@nongnu.org>,
Qemu-block <qemu-block@nongnu.org>
Subject: Re: [PULL 0/2] block: Fix iotests to respect configured Python binary
Date: Fri, 29 Jan 2021 18:17:28 +0100 [thread overview]
Message-ID: <20210129171728.GJ10888@merkur.fritz.box> (raw)
In-Reply-To: <CAFEAcA_5ASnuNjWs8rdRid-VpjFaHX0Y_8cKFRY0ojJKLB7ryA@mail.gmail.com>
Am 29.01.2021 um 17:13 hat Peter Maydell geschrieben:
> On Fri, 29 Jan 2021 at 14:52, Kevin Wolf <kwolf@redhat.com> wrote:
> >
> > The following changes since commit 5101d00d2f1138a73344dc4833587f76d7a5fa5c:
> >
> > Merge remote-tracking branch 'remotes/vivier2/tags/trivial-branch-for-6.0-pull-request' into staging (2021-01-29 10:10:43 +0000)
> >
> > are available in the Git repository at:
> >
> > git://repo.or.cz/qemu/kevin.git tags/for-upstream
> >
> > for you to fetch changes up to 4cea90be62f4f15a63e1a8f7d5d0958f79fdf290:
> >
> > tests/Makefile.include: export PYTHON for check-block.sh (2021-01-29 12:32:36 +0100)
> >
> > ----------------------------------------------------------------
> > Block layer patches:
> >
> > - Fix iotests to respect configured Python binary
> >
> > ----------------------------------------------------------------
>
> This is definitely better so I'm going to apply it, but it seems
> to reveal a pile of iotest failures on FreeBSD:
> [...]
> Failures: 030 040 041 127 256
Hm... I did run 'make check-block' on a FreeBSD VM before sending the
pull request, but it turns out I ran it on the wrong branch. *sigh*
After rerunning it with the right one (and manually so that I get all
tests, not just those in 'make check-block'), however, while I'm seeing
some failures, my list of failing cases and your list are completely
disjoint:
Failures: 115 125 145 182 286 298 300 migrate-bitmaps-postcopy-test
migrate-bitmaps-test
All of these are test cases that are not run during 'make check-block',
so I would assume that they were already broken before.
So there seems to be something more specific to the environment that
made your test cases fail than just FreeBSD.
> though the entire build goes on to succeed (which is probably
> a test framework bug somewhere...)
This is not good, and it can easily be reproduced on Linux by simply
changing the reference output of a test so that it fails. 'check'
doesn't seem to return the right exit code any more.
Kevin
next prev parent reply other threads:[~2021-01-29 17:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 14:52 [PULL 0/2] block: Fix iotests to respect configured Python binary Kevin Wolf
2021-01-29 14:52 ` [PULL 1/2] iotests/testrunner: fix recognition of python tests Kevin Wolf
2021-01-29 14:52 ` [PULL 2/2] tests/Makefile.include: export PYTHON for check-block.sh Kevin Wolf
2021-01-29 16:13 ` [PULL 0/2] block: Fix iotests to respect configured Python binary Peter Maydell
2021-01-29 17:17 ` Kevin Wolf [this message]
2021-02-01 8:36 ` Vladimir Sementsov-Ogievskiy
2021-01-29 17:22 ` Peter Maydell
2021-02-01 21:43 ` Peter Maydell
2021-02-02 9:47 ` Peter Maydell
2021-02-02 11:41 ` Kevin Wolf
2021-02-02 12:43 ` Vladimir Sementsov-Ogievskiy
2021-02-02 13:44 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210129171728.GJ10888@merkur.fritz.box \
--to=kwolf@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).