From: Peter Xu <peterx@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: mst@redhat.com, lersek@redhat.com, qemu-devel@nongnu.org,
dgilbert@redhat.com
Subject: Re: [PATCH v2 1/2] pci: reject too large ROMs
Date: Fri, 29 Jan 2021 17:18:23 -0500 [thread overview]
Message-ID: <20210129221823.GA260413@xz-x1> (raw)
In-Reply-To: <20210129192838.582771-2-pbonzini@redhat.com>
On Fri, Jan 29, 2021 at 08:28:37PM +0100, Paolo Bonzini wrote:
> get_image_size() returns an int64_t, which pci_add_option_rom() assigns
> to an "int" without any range checking. A 32-bit BAR could be up to
> 2 GiB in size, so reject anything above it. In order to accomodate
> a rounded-up size of 2 GiB, change pci_patch_ids's size argument
> to unsigned.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
next prev parent reply other threads:[~2021-01-29 22:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 19:28 [PATCH v2 0/2] pci: add romsize property Paolo Bonzini
2021-01-29 19:28 ` [PATCH v2 1/2] pci: reject too large ROMs Paolo Bonzini
2021-01-29 22:18 ` Peter Xu [this message]
2021-02-01 8:34 ` Philippe Mathieu-Daudé
2021-02-02 10:59 ` Laszlo Ersek
2021-01-29 19:28 ` [PATCH v2 2/2] pci: add romsize property Paolo Bonzini
2021-01-29 19:51 ` BALATON Zoltan
2021-01-29 19:57 ` Paolo Bonzini
2021-01-29 20:06 ` BALATON Zoltan
2021-01-29 20:16 ` Paolo Bonzini
2021-02-01 7:56 ` Gerd Hoffmann
2021-02-01 15:52 ` Peter Xu
2021-02-01 15:54 ` Dr. David Alan Gilbert
2021-02-02 10:05 ` David Edmondson
2021-02-02 11:03 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210129221823.GA260413@xz-x1 \
--to=peterx@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lersek@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).