From: Gerd Hoffmann <kraxel@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: mst@redhat.com, lersek@redhat.com, qemu-devel@nongnu.org,
peterx@redhat.com, dgilbert@redhat.com
Subject: Re: [PATCH v2 2/2] pci: add romsize property
Date: Mon, 1 Feb 2021 08:56:32 +0100 [thread overview]
Message-ID: <20210201075632.lfchwzrzr6aiuplu@sirius.home.kraxel.org> (raw)
In-Reply-To: <20210129192838.582771-3-pbonzini@redhat.com>
Hi,
> + DEFINE_PROP_UINT32("romsize", PCIDevice, romsize, -1),
IIRC we have a DEFINE_PROP_SIZE() which can parse units and therefore
accepts -- for example -- "512k" or "1M".
take care,
Gerd
next prev parent reply other threads:[~2021-02-01 7:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 19:28 [PATCH v2 0/2] pci: add romsize property Paolo Bonzini
2021-01-29 19:28 ` [PATCH v2 1/2] pci: reject too large ROMs Paolo Bonzini
2021-01-29 22:18 ` Peter Xu
2021-02-01 8:34 ` Philippe Mathieu-Daudé
2021-02-02 10:59 ` Laszlo Ersek
2021-01-29 19:28 ` [PATCH v2 2/2] pci: add romsize property Paolo Bonzini
2021-01-29 19:51 ` BALATON Zoltan
2021-01-29 19:57 ` Paolo Bonzini
2021-01-29 20:06 ` BALATON Zoltan
2021-01-29 20:16 ` Paolo Bonzini
2021-02-01 7:56 ` Gerd Hoffmann [this message]
2021-02-01 15:52 ` Peter Xu
2021-02-01 15:54 ` Dr. David Alan Gilbert
2021-02-02 10:05 ` David Edmondson
2021-02-02 11:03 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210201075632.lfchwzrzr6aiuplu@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lersek@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).