From: Stefan Hajnoczi <stefanha@redhat.com>
To: "Volker Rümelin" <vr_qemu@t-online.de>
Cc: Cleber Rosa <crosa@redhat.com>, QEMU <qemu-devel@nongnu.org>,
Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [PATCH] simpletrace: build() missing 2 required positional arguments
Date: Mon, 1 Feb 2021 10:51:11 +0000 [thread overview]
Message-ID: <20210201105111.GA159493@stefanha-x1.localdomain> (raw)
In-Reply-To: <20210131173415.3392-1-vr_qemu@t-online.de>
[-- Attachment #1: Type: text/plain, Size: 1011 bytes --]
On Sun, Jan 31, 2021 at 06:34:15PM +0100, Volker Rümelin wrote:
> Commit 4e66c9ef64 "tracetool: add input filename and line number to
> Event" forgot to add a line number and a filename argument at one
> build method call site.
>
> Traceback (most recent call last):
> File "./scripts/simpletrace.py", line 261, in <module>
> run(Formatter())
> File "./scripts/simpletrace.py", line 236, in run
> process(events, sys.argv[2], analyzer, read_header=read_header)
> File "./scripts/simpletrace.py", line 177, in process
> dropped_event =
> Event.build("Dropped_Event(uint64_t num_events_dropped)")
> TypeError: build() missing 2 required positional arguments:
> 'lineno' and 'filename'
>
> Add the missing arguments.
>
> Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
> ---
> scripts/simpletrace.py | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Thanks, applied to my tracing tree:
https://gitlab.com/stefanha/qemu/commits/tracing
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2021-02-01 10:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-31 17:34 [PATCH] simpletrace: build() missing 2 required positional arguments Volker Rümelin
2021-01-31 19:56 ` Philippe Mathieu-Daudé
2021-02-01 10:51 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210201105111.GA159493@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vr_qemu@t-online.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).