From: Kevin Wolf <kwolf@redhat.com>
To: Sergio Lopez <slp@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
Max Reitz <mreitz@redhat.com>
Subject: Re: [PATCH v3 2/2] block: move blk_exp_close_all() to qemu_cleanup()
Date: Mon, 1 Feb 2021 13:20:30 +0100 [thread overview]
Message-ID: <20210201122030.GB13157@merkur.fritz.box> (raw)
In-Reply-To: <20210121170700.59734-3-slp@redhat.com>
Am 21.01.2021 um 18:07 hat Sergio Lopez geschrieben:
> Move blk_exp_close_all() from bdrv_close() to qemu_cleanup(), before
> bdrv_drain_all_begin().
>
> Export drivers may have coroutines yielding at some point in the block
> layer, so we need to shut them down before draining the block layer,
> as otherwise they may get stuck blk_wait_while_drained().
>
> RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1900505
> Signed-off-by: Sergio Lopez <slp@redhat.com>
This patch loses the call in qemu-nbd and qemu-storage-daemon.
Kevin
next prev parent reply other threads:[~2021-02-01 12:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 17:06 [PATCH v3 0/2] nbd/server: Quiesce coroutines on context switch Sergio Lopez
2021-01-21 17:06 ` [PATCH v3 1/2] block: Avoid processing BDS twice in bdrv_set_aio_context_ignore() Sergio Lopez
2021-01-21 17:31 ` Eric Blake
2021-02-01 12:06 ` Kevin Wolf
2021-02-01 12:34 ` Sergio Lopez
2021-01-21 17:07 ` [PATCH v3 2/2] block: move blk_exp_close_all() to qemu_cleanup() Sergio Lopez
2021-01-21 18:02 ` Eric Blake
2021-02-01 12:20 ` Kevin Wolf [this message]
2021-02-01 12:35 ` Sergio Lopez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210201122030.GB13157@merkur.fritz.box \
--to=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=slp@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).