From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C6B7C433E6 for ; Mon, 1 Feb 2021 16:02:52 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E608264E2B for ; Mon, 1 Feb 2021 16:02:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E608264E2B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50962 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l6bf8-0007tf-TD for qemu-devel@archiver.kernel.org; Mon, 01 Feb 2021 11:02:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43902) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6bXH-0007fP-7g for qemu-devel@nongnu.org; Mon, 01 Feb 2021 10:54:43 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:32798) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l6bXF-0001Y1-1z for qemu-devel@nongnu.org; Mon, 01 Feb 2021 10:54:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612194880; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OlPiP7LP9XDaJ76tLZ7J1B/STRNjlroDMd0L12zdw9U=; b=jM+MmlfBZiBp2Ed6DK26+/tr6UAXygX+h00Dj2wByOCMnDkkBmEtayfZhqUOOnUjXK5P2j q7Ub/732zuXjWiiE6ron4GbZfpxmJTmGQijf3zrm74m/pYJHzUIUTb5bff8QZsZWvVnOb6 F3nyBSAC56vODFPzk3rVO5pLp4Z1fyE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-410-FVPaDIHwNGiEXhw1095Z5A-1; Mon, 01 Feb 2021 10:54:37 -0500 X-MC-Unique: FVPaDIHwNGiEXhw1095Z5A-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AA84E9CC02 for ; Mon, 1 Feb 2021 15:54:36 +0000 (UTC) Received: from work-vm (ovpn-115-16.ams2.redhat.com [10.36.115.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6C9EE1001281; Mon, 1 Feb 2021 15:54:26 +0000 (UTC) Date: Mon, 1 Feb 2021 15:54:23 +0000 From: "Dr. David Alan Gilbert" To: Peter Xu Subject: Re: [PATCH v2 2/2] pci: add romsize property Message-ID: <20210201155423.GH3300@work-vm> References: <20210129192838.582771-1-pbonzini@redhat.com> <20210129192838.582771-3-pbonzini@redhat.com> <20210201075632.lfchwzrzr6aiuplu@sirius.home.kraxel.org> <20210201155259.GE260413@xz-x1> MIME-Version: 1.0 In-Reply-To: <20210201155259.GE260413@xz-x1> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dgilbert@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=63.128.21.124; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.351, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , mst@redhat.com, lersek@redhat.com, Gerd Hoffmann , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Peter Xu (peterx@redhat.com) wrote: > On Mon, Feb 01, 2021 at 08:56:32AM +0100, Gerd Hoffmann wrote: > > Hi, > > > > > + DEFINE_PROP_UINT32("romsize", PCIDevice, romsize, -1), > > > > IIRC we have a DEFINE_PROP_SIZE() which can parse units and therefore > > accepts -- for example -- "512k" or "1M". > > Actually IMHO there's some fair point to make it uint32: even 1 byte would > matter here or migration fails. Hence, we don't need to worry about things > like 512KB or 512KiB, for example. > > Not to mention that I bet 99.99% qemu users won't really use this parameter, > only if we'd migrate across distros. That's rare, we'd copy the exact byte > value of the source ROM size here (e.g. via "info ramblock", or "ls -l" the > romfile then round to pow2 and specify on dest) or we simply copy this param > over from another source VM. Well, we should sometime, set it for the default upstream machine types, so that distros get a better chance of getting their rom images right and consistent. Dave > Thanks, > > -- > Peter Xu > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK