From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Igor Mammedov <imammedo@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Eduardo Habkost <ehabkost@redhat.com>,
Babu Moger <babu.moger@amd.com>
Subject: [PATCH 0/3] i386: Ensure feature names are always defined
Date: Mon, 1 Feb 2021 17:54:01 -0500 [thread overview]
Message-ID: <20210201225404.3941395-1-ehabkost@redhat.com> (raw)
Forgetting to adding feature names to the feature array
seems to be a very common mistake.
Examples:
- Missing name for MSR_VMX_EPT_WB
commit 0723cc8a5558 ("target/i386: add VMX features to named CPU models")
- Missing name for "ibrs" at
https://lore.kernel.org/qemu-devel/0ad4017d-e755-94a3-859e-800661bcd2d1@amd.com
This series fixes the MSR_VMX_EPT_WB problem and adds a runtime
check that should detect similar mistakes even before CPU model
classes are registered.
Eduardo Habkost (3):
i386: Add missing "vmx-ept-wb" feature name
i386: Move asserts to separate x86_cpudef_validate() function
i386: Sanity check CPU model feature sets
target/i386/cpu.c | 31 +++++++++++++++++++++++++++----
1 file changed, 27 insertions(+), 4 deletions(-)
--
2.28.0
next reply other threads:[~2021-02-01 22:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 22:54 Eduardo Habkost [this message]
2021-02-01 22:54 ` [PATCH 1/3] i386: Add missing "vmx-ept-wb" feature name Eduardo Habkost
2021-02-01 22:59 ` Paolo Bonzini
2021-02-01 23:05 ` Eduardo Habkost
2021-02-01 23:28 ` Paolo Bonzini
2021-02-02 0:18 ` Eduardo Habkost
2021-02-02 7:54 ` Paolo Bonzini
2021-02-02 15:25 ` Eduardo Habkost
2021-02-01 22:54 ` [PATCH 2/3] i386: Move asserts to separate x86_cpudef_validate() function Eduardo Habkost
2021-02-02 16:02 ` Philippe Mathieu-Daudé
2021-02-01 22:54 ` [PATCH 3/3] i386: Sanity check CPU model feature sets Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210201225404.3941395-1-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=babu.moger@amd.com \
--cc=imammedo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).