From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: [PATCH v1 07/15] configure: make version_ge more tolerant of shady version input
Date: Tue, 2 Feb 2021 13:39:52 +0000 [thread overview]
Message-ID: <20210202134001.25738-8-alex.bennee@linaro.org> (raw)
In-Reply-To: <20210202134001.25738-1-alex.bennee@linaro.org>
When checking GDB versions we have to tolerate all sorts of random
distro extensions to the version string. While we already attempt to
do some of that before we call version_ge is makes sense to try and
regularise the first input by stripping extraneous -'s. While we at it
convert the old-style shell quoting into a cleaner form t shut up my
editors linter lest it confuse me by underlining the whole line.
Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Tested-by: Thomas Huth <thuth@redhat.com>
---
configure | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index e85d6baf8f..432b83fadf 100755
--- a/configure
+++ b/configure
@@ -198,8 +198,8 @@ has() {
}
version_ge () {
- local_ver1=`echo $1 | tr . ' '`
- local_ver2=`echo $2 | tr . ' '`
+ local_ver1=$(expr "$1" : '\([0-9.]*\)' | tr . ' ')
+ local_ver2=$(echo "$2" | tr . ' ')
while true; do
set x $local_ver1
local_first=${2-0}
--
2.20.1
next prev parent reply other threads:[~2021-02-02 13:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 13:39 [PATCH v1 00/15] testing/gdbstub/docs pre-PR Alex Bennée
2021-02-02 13:39 ` [PATCH v1 01/15] tests/docker: Fix _get_so_libs() for docker-binfmt-image Alex Bennée
2021-02-02 13:39 ` [PATCH v1 02/15] tests/docker: Fix typo in help message Alex Bennée
2021-02-02 13:39 ` [PATCH v1 03/15] tests/docker: make _copy_with_mkdir accept missing files Alex Bennée
2021-02-02 13:39 ` [PATCH v1 04/15] tests/docker: preserve original name when copying libs Alex Bennée
2021-02-02 13:39 ` [PATCH v1 05/15] tests/docker: alias docker-help target for consistency Alex Bennée
2021-02-02 14:19 ` Philippe Mathieu-Daudé
2021-02-02 13:39 ` [PATCH v1 06/15] tests/docker: add a docker-exec-copy-test Alex Bennée
2021-02-02 13:39 ` Alex Bennée [this message]
2021-02-02 14:17 ` [PATCH v1 07/15] configure: make version_ge more tolerant of shady version input Eric Blake
2021-02-02 13:39 ` [PATCH v1 08/15] configure: bump the minimum gdb version for check-tcg to 9.1 Alex Bennée
2021-02-02 13:39 ` [PATCH v1 09/15] tests/tcg: don't silently skip the gdb tests Alex Bennée
2021-02-02 13:39 ` [PATCH v1 10/15] gdbstub: Fix handle_query_xfer_auxv Alex Bennée
2021-02-02 13:39 ` [PATCH v1 11/15] tests/tcg: Replace /bin/true by true (required on macOS) Alex Bennée
2021-02-02 14:23 ` Philippe Mathieu-Daudé
2021-02-02 14:24 ` Philippe Mathieu-Daudé
2021-02-02 18:34 ` Alex Bennée
2021-02-02 21:14 ` Alex Bennée
2021-02-02 13:39 ` [PATCH v1 12/15] scripts/mtest2make.py: export all-%s-targets variable and use it Alex Bennée
2021-02-02 13:39 ` [PATCH v1 13/15] tests/Makefile.include: don't use TARGET_DIRS for check-tcg Alex Bennée
2021-02-02 13:39 ` [PATCH v1 14/15] docs/system: document an example vexpress-a15 invocation Alex Bennée
2021-02-02 13:40 ` [PATCH v1 15/15] docs/system: document an example booting the versatilepb machine Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210202134001.25738-8-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).