From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED247C433E0 for ; Tue, 2 Feb 2021 15:19:20 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A51D64E8F for ; Tue, 2 Feb 2021 15:19:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A51D64E8F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41558 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l6xSZ-0006rZ-NT for qemu-devel@archiver.kernel.org; Tue, 02 Feb 2021 10:19:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52092) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6x6e-0002gu-JN for qemu-devel@nongnu.org; Tue, 02 Feb 2021 09:56:42 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:39659) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l6x6b-0007Wk-KE for qemu-devel@nongnu.org; Tue, 02 Feb 2021 09:56:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612277796; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pD3oFZkXhGLXFUbra3k5VBUbjVE8TkP14HdE3xINsrk=; b=aB8SouYk35vuykoLJukx/vcnm60uosKCo0sn2qJQURCkN/s9Bn/F2vObka0ZosBG6/htJy t6fzjRWdYH1PgyESQgz50pSpkkXZPIU2I/iUULYyLe7DosTHHWea4oaZDMD9XiIIVAFMDQ JytxYASTcR5SalnYumgt3PsYGpINOng= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-553-WydUzHk0Os6fLi8GePJ82A-1; Tue, 02 Feb 2021 09:56:34 -0500 X-MC-Unique: WydUzHk0Os6fLi8GePJ82A-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C38A59CC0F; Tue, 2 Feb 2021 14:56:32 +0000 (UTC) Received: from redhat.com (ovpn-112-202.ams2.redhat.com [10.36.112.202]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 635585C1CF; Tue, 2 Feb 2021 14:56:30 +0000 (UTC) Date: Tue, 2 Feb 2021 14:56:27 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH] iotests: Revert emulator selection to old behaviour Message-ID: <20210202145627.GM4168502@redhat.com> References: <20210202142802.119999-1-kwolf@redhat.com> <48115c56-66cc-3f94-316c-95a9f64879a7@redhat.com> MIME-Version: 1.0 In-Reply-To: <48115c56-66cc-3f94-316c-95a9f64879a7@redhat.com> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.386, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Kevin Wolf , peter.maydell@linaro.org, vsementsov@virtuozzo.com, qemu-devel@nongnu.org, qemu-block@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Feb 02, 2021 at 03:46:11PM +0100, Philippe Mathieu-Daudé wrote: > On 2/2/21 3:28 PM, Kevin Wolf wrote: > > If the qemu-system-{arch} binary for the host architecture can't be > > found, the old 'check' implementation selected the alphabetically first > > system emulator binary that it could find. The new Python implementation > > just uses the first result of glob.iglob(), which has an undefined > > order. > > > > This is a problem that breaks CI because the iotests aren't actually > > prepared to run on any emulator. They should be, so this is really a bug > > in the failing test cases that should be fixed there, but as a quick > > fix, let's revert to the old behaviour to let CI runs succeed again. > > FWIW this is the same problem I had 1 year ago and tried to > fix it by sending QMP 'query-version' (introduced in v0.14): > https://www.mail-archive.com/qemu-devel@nongnu.org/msg675075.html In the current failures the issue isn't the version number. Rather some of the tests (mistakenly) assume the emulator supports PCI, and we're randomly sometimes picking emulator targets that lack PCI. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|