From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0525C433E9 for ; Tue, 2 Feb 2021 16:14:30 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5779064F55 for ; Tue, 2 Feb 2021 16:14:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5779064F55 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39632 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l6yJx-0001Fy-Bz for qemu-devel@archiver.kernel.org; Tue, 02 Feb 2021 11:14:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42850) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6y31-00069R-U0 for qemu-devel@nongnu.org; Tue, 02 Feb 2021 10:57:00 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:59079) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l6y2w-00023C-3q for qemu-devel@nongnu.org; Tue, 02 Feb 2021 10:56:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612281413; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FIeU5vr6P9ETMb5WrDe1IVgUMo9nsV2GwJpRkYb6CD0=; b=UzIapkeEU1SxYG/lEu20y2R2YdcwSNeckq+OcI36h6+uTSA3Bj2VAxRYcELUCqs9dKaDcp iXUCi71VtOA4GgsC8+j5koC/JHHe7W74UEx5gs0PGOwC4hzsXYwHk46GJ+egCEy5ifKFpl ClIrXAuDwzjOfVzb2DrmdeMlqCvwcqE= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-346-YF4BBc7kNXug3eEgERAWSw-1; Tue, 02 Feb 2021 10:56:51 -0500 X-MC-Unique: YF4BBc7kNXug3eEgERAWSw-1 Received: by mail-wm1-f69.google.com with SMTP id u1so1646104wml.2 for ; Tue, 02 Feb 2021 07:56:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=FIeU5vr6P9ETMb5WrDe1IVgUMo9nsV2GwJpRkYb6CD0=; b=HS0AIrIyXdziKspy8flZTdNrK+DYhu5zpQIgKoKvFrZ+8gvK2YMvwN8GmTPy++BKzb CroXiIsZ97ua6o9sy3Wa9JTQLUazEhINn9AJp/4TPplJwv5CRYcte3iglt/e17PCKwTg AXcVXwdPv5e4gT3jc9KQUTFo2yrvYrHcV/6e37wLJXrLf1WkCDuEOLV8kULs9vz8DqOs Z2N0FQ+O04E2EhGmBEfxJhXZdw8KidS/9eCMaLRbKqMw6uHiG3xA/wMf79QF5Lub/vl9 97r0RZecn0OgqHdU/MbD5kN+yS6CaRKfGPKZ3njYh872sWRm7DIC8DbztSr082blfjhO gm4w== X-Gm-Message-State: AOAM533VhUepoAxlZQ0afs1wU8Zt6L12Z8a2YthKmbi1zsR4x9JxkUA7 r03sra4KwGs+9jR9QlRDYh1knq0wxieE4sJiOVStGELHT7gaFJ7uxcnYXMTla2yvZzutVH5Z3oQ begt7WKnjf7IoldNbn0qGdkegUNIrMZXE2VlZ5p8mJcOI/+VVUFsnGV+YieoXcMn1 X-Received: by 2002:a05:600c:28b:: with SMTP id 11mr4281532wmk.98.1612281409534; Tue, 02 Feb 2021 07:56:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJzKYLHerQzAoFfIr5Ish+YXWqEJkYkVd0aR+Ev7o1WaT/vyuU1T9BTgcwcLSBvcLIpm7WrhFg== X-Received: by 2002:a05:600c:28b:: with SMTP id 11mr4281362wmk.98.1612281406773; Tue, 02 Feb 2021 07:56:46 -0800 (PST) Received: from x1w.redhat.com (7.red-83-57-171.dynamicip.rima-tde.net. [83.57.171.7]) by smtp.gmail.com with ESMTPSA id u206sm3928158wme.12.2021.02.02.07.56.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Feb 2021 07:56:46 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH] hw/i386/xen: Remove dead code Date: Tue, 2 Feb 2021 16:56:44 +0100 Message-Id: <20210202155644.998812-1-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.386, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Eduardo Habkost , "Michael S. Tsirkin" , qemu-trivial@nongnu.org, Paul Durrant , Richard Henderson , xen-devel@lists.xenproject.org, Anthony Perard , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" 'drivers_blacklisted' is never accessed, remove it. Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/xen/xen_platform.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/hw/i386/xen/xen_platform.c b/hw/i386/xen/xen_platform.c index 7c4db35debb..01ae1fb1618 100644 --- a/hw/i386/xen/xen_platform.c +++ b/hw/i386/xen/xen_platform.c @@ -60,7 +60,6 @@ struct PCIXenPlatformState { MemoryRegion bar; MemoryRegion mmio_bar; uint8_t flags; /* used only for version_id == 2 */ - int drivers_blacklisted; uint16_t driver_product_version; /* Log from guest drivers */ @@ -245,18 +244,10 @@ static void platform_fixed_ioport_writeb(void *opaque, uint32_t addr, uint32_t v static uint32_t platform_fixed_ioport_readw(void *opaque, uint32_t addr) { - PCIXenPlatformState *s = opaque; - switch (addr) { case 0: - if (s->drivers_blacklisted) { - /* The drivers will recognise this magic number and refuse - * to do anything. */ - return 0xd249; - } else { - /* Magic value so that you can identify the interface. */ - return 0x49d2; - } + /* Magic value so that you can identify the interface. */ + return 0x49d2; default: return 0xffff; } -- 2.26.2