From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38C21C433DB for ; Wed, 3 Feb 2021 10:30:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9CAEA64DF2 for ; Wed, 3 Feb 2021 10:30:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CAEA64DF2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41062 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l7FR1-00029p-E0 for qemu-devel@archiver.kernel.org; Wed, 03 Feb 2021 05:30:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40510) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7FOz-00006v-Pk for qemu-devel@nongnu.org; Wed, 03 Feb 2021 05:28:49 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:41959) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l7FOy-0008Te-65 for qemu-devel@nongnu.org; Wed, 03 Feb 2021 05:28:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612348126; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Zg3CMFz8kPgmp6u9HGBkVNKI/3kqWjMIRaFOoHro+Q0=; b=flGApf1n5GafiNXAQ2lecV6SDKOD6EXvXM8wcxIyiVIa+EsSi0hKC4jrvcdEnqFWx7YBw9 kOWDyPFS2rqXZsLTlGf4seN+5/Af0LfNmkGaZY3Krjo6TBQ5vtnCF9qocdhrFX1yPE6g38 ytz9wcrHvG7QEvmy2pAb/U2S/xhkqmc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-417-TWESD4UaNuWrZ8KyCLkdCA-1; Wed, 03 Feb 2021 05:28:40 -0500 X-MC-Unique: TWESD4UaNuWrZ8KyCLkdCA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 92FBE100C661; Wed, 3 Feb 2021 10:28:39 +0000 (UTC) Received: from redhat.com (ovpn-115-117.ams2.redhat.com [10.36.115.117]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AE0677771D; Wed, 3 Feb 2021 10:28:11 +0000 (UTC) Date: Wed, 3 Feb 2021 10:28:08 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH 10/12] tests/qemu-iotests: Replace the words 'blacklist/whitelist' Message-ID: <20210203102757.GL300990@redhat.com> References: <20210202205824.1085853-1-philmd@redhat.com> <20210202205824.1085853-11-philmd@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210202205824.1085853-11-philmd@redhat.com> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.386, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Eduardo Otubo , Kevin Wolf , qemu-block@nongnu.org, Peter Maydell , Michael Roth , qemu-devel@nongnu.org, "Dr. David Alan Gilbert" , Alex Williamson , Gerd Hoffmann , Stefan Hajnoczi , Max Reitz , Alex =?utf-8?Q?Benn=C3=A9e?= , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Feb 02, 2021 at 09:58:22PM +0100, Philippe Mathieu-Daudé wrote: > Follow the inclusive terminology from the "Conscious Language in your > Open Source Projects" guidelines [*] and replace the words "blacklist" > and "whitelist" appropriately. > > [*] https://github.com/conscious-lang/conscious-lang-docs/blob/main/faq.md > > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/qemu-iotests/149 | 14 +++++++------- > tests/qemu-iotests/149.out | 8 ++++---- > 2 files changed, 11 insertions(+), 11 deletions(-) > > diff --git a/tests/qemu-iotests/149 b/tests/qemu-iotests/149 > index 328fd05a4c9..b1d3f5fad67 100755 > --- a/tests/qemu-iotests/149 > +++ b/tests/qemu-iotests/149 > @@ -500,7 +500,7 @@ configs = [ > > ] > > -blacklist = [ > +denylist = [ > # We don't have a cast-6 cipher impl for QEMU yet > "cast6-256-xts-plain64-sha1", > "cast6-128-xts-plain64-sha1", > @@ -510,17 +510,17 @@ blacklist = [ > "twofish-192-xts-plain64-sha1", > ] "skiplist" better describes the purpose of this. > > -whitelist = [] > +allowlist = [] > if "LUKS_CONFIG" in os.environ: > - whitelist = os.environ["LUKS_CONFIG"].split(",") > + allowlist = os.environ["LUKS_CONFIG"].split(",") And "filterlist" > > for config in configs: > - if config.name in blacklist: > - iotests.log("Skipping %s in blacklist" % config.name) > + if config.name in denylist: > + iotests.log("Skipping %s in denylist" % config.name) > continue > > - if len(whitelist) > 0 and config.name not in whitelist: > - iotests.log("Skipping %s not in whitelist" % config.name) > + if len(allowlist) > 0 and config.name not in allowlist: > + iotests.log("Skipping %s not in allowlist" % config.name) > continue > > test_once(config, qemu_img=False) Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|