From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Wainer dos Santos Moschetta <wainersm@redhat.com>
Cc: "misono.tomohiro@fujitsu.com" <misono.tomohiro@fujitsu.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"stefanha@redhat.com" <stefanha@redhat.com>
Subject: Re: [PATCH 1/1] virtiofsd: Allow to build it without the tools
Date: Wed, 3 Feb 2021 11:30:14 +0000 [thread overview]
Message-ID: <20210203113014.GG2950@work-vm> (raw)
In-Reply-To: <41d8b908-652f-a8c4-0bef-7420c65bd1d2@redhat.com>
* Wainer dos Santos Moschetta (wainersm@redhat.com) wrote:
>
> On 2/2/21 2:55 AM, misono.tomohiro@fujitsu.com wrote:
> > > Subject: [PATCH 1/1] virtiofsd: Allow to build it without the tools
> > >
> > > This changed the Meson build script to allow virtiofsd be built even
> > > though the tools build is disabled, thus honoring the --enable-virtiofsd
> > > option.
> > >
> > > Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
> > I misunderstood that virtiofsd builds somehow depends on tools build at that time.
> > Thanks for fixing. I did quick build test.
> Thanks for the review and test!
>
> If not needed a v2 for this patch, please could the maintainer add to the
> commit message:
>
> Fixes: cece116c939d219070b250338439c2d16f94e3da (configure: add option for
> virtiofsd)
OK, I cna add that; I'll take it through virtiofs next time I need to do
a pull.
> - Wainer
>
> >
> > Reviewed-by: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com>
> >
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2021-02-03 11:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 21:14 [PATCH 0/1] Allow to build virtiofsd without the entire tools Wainer dos Santos Moschetta
2021-02-01 21:14 ` [PATCH 1/1] virtiofsd: Allow to build it without the tools Wainer dos Santos Moschetta
2021-02-02 5:55 ` misono.tomohiro
2021-02-02 12:58 ` Wainer dos Santos Moschetta
2021-02-03 11:30 ` Dr. David Alan Gilbert [this message]
2021-02-16 10:59 ` Dr. David Alan Gilbert
2021-02-03 14:41 ` Stefan Hajnoczi
2021-02-01 23:04 ` [PATCH 0/1] Allow to build virtiofsd without the entire tools Paolo Bonzini
2021-02-02 12:48 ` Wainer dos Santos Moschetta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210203113014.GG2950@work-vm \
--to=dgilbert@redhat.com \
--cc=misono.tomohiro@fujitsu.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).