qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Aaron Lindsay <aaron@os.amperecomputing.com>
To: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Cc: Andrew Jones <drjones@redhat.com>,
	Juan Quintela <quintela@redhat.com>,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
	Aaron Lindsay <aaron@os.amperecomputing.com>,
	qemu-arm <qemu-arm@nongnu.org>,
	philmd@redhat.com
Subject: [PATCH] target/arm: Don't migrate CPUARMState.features
Date: Wed,  3 Feb 2021 11:13:40 -0500	[thread overview]
Message-ID: <20210203161340.55210-1-aaron@os.amperecomputing.com> (raw)
In-Reply-To: <CAFEAcA-qq-Eue+ktR1tNO7FZdtCe428=5vdA5472W-16p=d75A@mail.gmail.com>

As feature flags are added or removed, the meanings of bits in the
`features` field can change between QEMU versions, causing migration
failures. Additionally, migrating the field is not useful because it is
a constant function of the CPU being used.

Signed-off-by: Aaron Lindsay <aaron@os.amperecomputing.com>
Suggested-by: Peter Maydell <peter.maydell@linaro.org>
---
 target/arm/machine.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/arm/machine.c b/target/arm/machine.c
index c9e9fd0a12..7f2511b6ed 100644
--- a/target/arm/machine.c
+++ b/target/arm/machine.c
@@ -834,7 +834,7 @@ const VMStateDescription vmstate_arm_cpu = {
         VMSTATE_UINT64(env.exclusive_addr, ARMCPU),
         VMSTATE_UINT64(env.exclusive_val, ARMCPU),
         VMSTATE_UINT64(env.exclusive_high, ARMCPU),
-        VMSTATE_UINT64(env.features, ARMCPU),
+        VMSTATE_UNUSED(sizeof(uint64_t)),
         VMSTATE_UINT32(env.exception.syndrome, ARMCPU),
         VMSTATE_UINT32(env.exception.fsr, ARMCPU),
         VMSTATE_UINT64(env.exception.vaddress, ARMCPU),
-- 
2.17.1



  parent reply	other threads:[~2021-02-03 16:18 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-03  4:01 ARM Snapshots Not Backwards-Compatible Aaron Lindsay
2021-02-03  8:21 ` Philippe Mathieu-Daudé
2021-02-03 10:27   ` Dr. David Alan Gilbert
2021-02-03 10:38     ` Peter Maydell
2021-02-03 10:49       ` Dr. David Alan Gilbert
2021-02-03 10:52         ` Peter Maydell
2021-02-03 10:59           ` Dr. David Alan Gilbert
2021-02-03 16:04             ` Philippe Mathieu-Daudé
2021-02-03 12:44           ` Andrew Jones
2021-02-03 15:45             ` aaron--- via
2021-02-03 15:53               ` Andrew Jones
2021-02-03 10:01 ` Peter Maydell
2021-02-03 14:58   ` Aaron Lindsay
2021-02-03 15:02     ` Philippe Mathieu-Daudé
2021-02-03 15:10       ` Dr. David Alan Gilbert
2021-02-03 15:26         ` Peter Maydell
2021-02-03 15:54           ` Aaron Lindsay
2021-02-03 16:13           ` Aaron Lindsay [this message]
2021-02-03 16:24             ` [PATCH] target/arm: Don't migrate CPUARMState.features Philippe Mathieu-Daudé
2021-02-03 20:06             ` Andrew Jones
2021-02-08 13:11             ` Peter Maydell
2021-02-03 15:42         ` ARM Snapshots Not Backwards-Compatible aaron--- via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210203161340.55210-1-aaron@os.amperecomputing.com \
    --to=aaron@os.amperecomputing.com \
    --cc=dgilbert@redhat.com \
    --cc=drjones@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).