From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org
Subject: [PATCH v5 23/31] linux-user/aarch64: Implement PR_MTE_TCF and PR_MTE_TAG
Date: Wed, 3 Feb 2021 09:00:02 -1000 [thread overview]
Message-ID: <20210203190010.759771-24-richard.henderson@linaro.org> (raw)
In-Reply-To: <20210203190010.759771-1-richard.henderson@linaro.org>
These prctl fields are required for the function of MTE.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
linux-user/aarch64/target_syscall.h | 9 ++++++
linux-user/syscall.c | 43 +++++++++++++++++++++++++++++
2 files changed, 52 insertions(+)
diff --git a/linux-user/aarch64/target_syscall.h b/linux-user/aarch64/target_syscall.h
index 820601dfcc..76f6c3391d 100644
--- a/linux-user/aarch64/target_syscall.h
+++ b/linux-user/aarch64/target_syscall.h
@@ -33,5 +33,14 @@ struct target_pt_regs {
#define TARGET_PR_SET_TAGGED_ADDR_CTRL 55
#define TARGET_PR_GET_TAGGED_ADDR_CTRL 56
# define TARGET_PR_TAGGED_ADDR_ENABLE (1UL << 0)
+/* MTE tag check fault modes */
+# define TARGET_PR_MTE_TCF_SHIFT 1
+# define TARGET_PR_MTE_TCF_NONE (0UL << TARGET_PR_MTE_TCF_SHIFT)
+# define TARGET_PR_MTE_TCF_SYNC (1UL << TARGET_PR_MTE_TCF_SHIFT)
+# define TARGET_PR_MTE_TCF_ASYNC (2UL << TARGET_PR_MTE_TCF_SHIFT)
+# define TARGET_PR_MTE_TCF_MASK (3UL << TARGET_PR_MTE_TCF_SHIFT)
+/* MTE tag inclusion mask */
+# define TARGET_PR_MTE_TAG_SHIFT 3
+# define TARGET_PR_MTE_TAG_MASK (0xffffUL << TARGET_PR_MTE_TAG_SHIFT)
#endif /* AARCH64_TARGET_SYSCALL_H */
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index ba4da7f8a6..61bf6148e7 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -10985,17 +10985,53 @@ static abi_long do_syscall1(void *cpu_env, int num, abi_long arg1,
{
abi_ulong valid_mask = TARGET_PR_TAGGED_ADDR_ENABLE;
CPUARMState *env = cpu_env;
+ ARMCPU *cpu = env_archcpu(env);
+
+ if (cpu_isar_feature(aa64_mte, cpu)) {
+ valid_mask |= TARGET_PR_MTE_TCF_MASK;
+ valid_mask |= TARGET_PR_MTE_TAG_MASK;
+ }
if ((arg2 & ~valid_mask) || arg3 || arg4 || arg5) {
return -TARGET_EINVAL;
}
env->tagged_addr_enable = arg2 & TARGET_PR_TAGGED_ADDR_ENABLE;
+
+ if (cpu_isar_feature(aa64_mte, cpu)) {
+ switch (arg2 & TARGET_PR_MTE_TCF_MASK) {
+ case TARGET_PR_MTE_TCF_NONE:
+ case TARGET_PR_MTE_TCF_SYNC:
+ case TARGET_PR_MTE_TCF_ASYNC:
+ break;
+ default:
+ return -EINVAL;
+ }
+
+ /*
+ * Write PR_MTE_TCF to SCTLR_EL1[TCF0].
+ * Note that the syscall values are consistent with hw.
+ */
+ env->cp15.sctlr_el[1] =
+ deposit64(env->cp15.sctlr_el[1], 38, 2,
+ arg2 >> TARGET_PR_MTE_TCF_SHIFT);
+
+ /*
+ * Write PR_MTE_TAG to GCR_EL1[Exclude].
+ * Note that the syscall uses an include mask,
+ * and hardware uses an exclude mask -- invert.
+ */
+ env->cp15.gcr_el1 =
+ deposit64(env->cp15.gcr_el1, 0, 16,
+ ~arg2 >> TARGET_PR_MTE_TAG_SHIFT);
+ arm_rebuild_hflags(env);
+ }
return 0;
}
case TARGET_PR_GET_TAGGED_ADDR_CTRL:
{
abi_long ret = 0;
CPUARMState *env = cpu_env;
+ ARMCPU *cpu = env_archcpu(env);
if (arg2 || arg3 || arg4 || arg5) {
return -TARGET_EINVAL;
@@ -11003,6 +11039,13 @@ static abi_long do_syscall1(void *cpu_env, int num, abi_long arg1,
if (env->tagged_addr_enable) {
ret |= TARGET_PR_TAGGED_ADDR_ENABLE;
}
+ if (cpu_isar_feature(aa64_mte, cpu)) {
+ /* See above. */
+ ret |= (extract64(env->cp15.sctlr_el[1], 38, 2)
+ << TARGET_PR_MTE_TCF_SHIFT);
+ ret = deposit64(ret, TARGET_PR_MTE_TAG_SHIFT, 16,
+ ~env->cp15.gcr_el1);
+ }
return ret;
}
#endif /* AARCH64 */
--
2.25.1
next prev parent reply other threads:[~2021-02-03 19:32 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 18:59 [PATCH v5 00/31] target-arm: Implement ARMv8.5-MemTag, user mode Richard Henderson
2021-02-03 18:59 ` [PATCH v5 01/31] tcg: Introduce target-specific page data for user-only Richard Henderson
2021-02-03 18:59 ` [PATCH v5 02/31] linux-user: Introduce PAGE_ANON Richard Henderson
2021-02-03 18:59 ` [PATCH v5 03/31] exec: Use uintptr_t for guest_base Richard Henderson
2021-02-03 19:08 ` Philippe Mathieu-Daudé
2021-02-03 19:10 ` Richard Henderson
2021-02-03 19:20 ` Philippe Mathieu-Daudé
2021-02-03 18:59 ` [PATCH v5 04/31] exec: Use uintptr_t in cpu_ldst.h Richard Henderson
2021-02-03 18:59 ` [PATCH v5 05/31] exec: Improve types for guest_addr_valid Richard Henderson
2021-02-03 18:59 ` [PATCH v5 06/31] linux-user: Check for overflow in access_ok Richard Henderson
2021-02-03 18:59 ` [PATCH v5 07/31] linux-user: Tidy VERIFY_READ/VERIFY_WRITE Richard Henderson
2021-02-03 18:59 ` [PATCH v5 08/31] bsd-user: " Richard Henderson
2021-02-03 18:59 ` [PATCH v5 09/31] linux-user: Do not use guest_addr_valid for h2g_valid Richard Henderson
2021-02-03 18:59 ` [PATCH v5 10/31] linux-user: Fix guest_addr_valid vs reserved_va Richard Henderson
2021-02-03 18:59 ` [PATCH v5 11/31] exec: Introduce cpu_untagged_addr Richard Henderson
2021-02-08 13:34 ` Peter Maydell
2021-02-03 18:59 ` [PATCH v5 12/31] exec: Use cpu_untagged_addr in g2h; split out g2h_untagged Richard Henderson
2021-02-08 13:39 ` Peter Maydell
2021-02-03 18:59 ` [PATCH v5 13/31] linux-user: Explicitly untag memory management syscalls Richard Henderson
2021-02-08 14:10 ` Peter Maydell
2021-02-08 16:33 ` Peter Maydell
2021-02-03 18:59 ` [PATCH v5 14/31] linux-user: Use guest_range_valid in access_ok Richard Henderson
2021-02-08 13:47 ` Peter Maydell
2021-02-03 18:59 ` [PATCH v5 15/31] exec: Rename guest_{addr,range}_valid to *_untagged Richard Henderson
2021-02-08 13:48 ` [PATCH v5 15/31] exec: Rename guest_{addr, range}_valid " Peter Maydell
2021-02-03 18:59 ` [PATCH v5 16/31] linux-user: Use cpu_untagged_addr in access_ok; split out *_untagged Richard Henderson
2021-02-08 13:50 ` Peter Maydell
2021-02-03 18:59 ` [PATCH v5 17/31] linux-user: Move lock_user et al out of line Richard Henderson
2021-02-08 13:50 ` Peter Maydell
2021-02-03 18:59 ` [PATCH v5 18/31] linux-user: Fix types in uaccess.c Richard Henderson
2021-02-08 13:53 ` Peter Maydell
2021-02-03 18:59 ` [PATCH v5 19/31] linux-user: Handle tags in lock_user/unlock_user Richard Henderson
2021-02-08 13:57 ` Peter Maydell
2021-02-08 17:32 ` Richard Henderson
2021-02-03 18:59 ` [PATCH v5 20/31] linux-user/aarch64: Implement PR_TAGGED_ADDR_ENABLE Richard Henderson
2021-02-03 19:00 ` [PATCH v5 21/31] target/arm: Improve gen_top_byte_ignore Richard Henderson
2021-02-03 19:00 ` [PATCH v5 22/31] target/arm: Use the proper TBI settings for linux-user Richard Henderson
2021-02-03 19:00 ` Richard Henderson [this message]
2021-02-03 19:00 ` [PATCH v5 24/31] linux-user/aarch64: Implement PROT_MTE Richard Henderson
2021-02-03 19:00 ` [PATCH v5 25/31] target/arm: Split out syndrome.h from internals.h Richard Henderson
2021-02-03 19:00 ` [PATCH v5 26/31] linux-user/aarch64: Pass syndrome to EXC_*_ABORT Richard Henderson
2021-02-03 19:00 ` [PATCH v5 27/31] linux-user/aarch64: Signal SEGV_MTESERR for sync tag check fault Richard Henderson
2021-02-03 19:00 ` [PATCH v5 28/31] linux-user/aarch64: Signal SEGV_MTEAERR for async tag check error Richard Henderson
2021-02-03 19:00 ` [PATCH v5 29/31] target/arm: Add allocation tag storage for user mode Richard Henderson
2021-02-03 19:00 ` [PATCH v5 30/31] target/arm: Enable MTE for user-only Richard Henderson
2021-02-03 19:00 ` [PATCH v5 31/31] tests/tcg/aarch64: Add mte smoke tests Richard Henderson
2021-02-03 19:57 ` [PATCH v5 00/31] target-arm: Implement ARMv8.5-MemTag, user mode no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210203190010.759771-24-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).